From 14fe315c62e1953dc87dc6f4bddbbc0b022ad9fa Mon Sep 17 00:00:00 2001 From: thiemowmde Date: Wed, 24 Apr 2024 13:54:54 +0200 Subject: [PATCH] Mark private MWReferenceModel setters as such This just documents the current status quo. These methods are not used anywhere, and probably shouldn't: https://codesearch.wmcloud.org/search/?q=%5Cbset%28ExtendsRef%7CList%28Key%7CGroup%7CIndex%29%29%5Cb The only place these should ever be called from is from newFromReferenceNode in the same class. Bug: T363096 Change-Id: Ic28dbb5cbb2beb98c9fe6d283ed87d879728da0f --- modules/ve-cite/ve.dm.MWReferenceModel.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/ve-cite/ve.dm.MWReferenceModel.js b/modules/ve-cite/ve.dm.MWReferenceModel.js index dfb7a0faa..92f2728ef 100644 --- a/modules/ve-cite/ve.dm.MWReferenceModel.js +++ b/modules/ve-cite/ve.dm.MWReferenceModel.js @@ -245,6 +245,7 @@ ve.dm.MWReferenceModel.prototype.getDocument = function () { /** * Set key of reference in list. * + * @private * @param {string} listKey Reference's list key */ ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) { @@ -254,6 +255,7 @@ ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) { /** * Set the name of the parent reference that is being extended by the current reference. * + * @private * @param {string} extendsRef References parent */ ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) { @@ -263,6 +265,7 @@ ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) { /** * Set name of the group a references list is in. * + * @private * @param {string} listGroup References list's group */ ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) { @@ -272,6 +275,7 @@ ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) { /** * Set the index of reference in list. * + * @private * @param {string} listIndex Reference's list index */ ve.dm.MWReferenceModel.prototype.setListIndex = function ( listIndex ) {