mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-15 10:15:24 +00:00
f0539e0c1e
PHP is not strongly typed, so it's not a good idea to use scalars of different types (here it's an integer vs the string 'new') to represent different possibilities. This can have bad effects when type juggling occurs, and it's also harder to figure out what the type of the parameter can be (because a numeric ID might have been passed as a string). Using integer vs null avoids all of this, and also allows us to use nullable typehints. These changes were partly copied from If981cb35bf19a8469aa6c43c907e107cf8c65bc2 and should help with the migration to the Filter value objects. Change-Id: I8837d46c3c33761fea53f67b530b721dc7bd49b0 |
||
---|---|---|
.. | ||
unit | ||
AbuseFilterConsequencesTest.php | ||
AbuseFilterCreateAccountTestTrait.php | ||
AbuseFilterDBTest.php | ||
AbuseFilterParserEquivsetTest.php | ||
AbuseFilterSaveTest.php | ||
AbuseFilterUploadTestTrait.php | ||
AbuseFilterVariableGeneratorDBTest.php | ||
UpdateVarDumpsTest.php |