mediawiki-extensions-AbuseF.../tests/phpunit
Daimona Eaytoy f0539e0c1e Represent new filters with null instead of 'new'
PHP is not strongly typed, so it's not a good idea to use scalars of
different types (here it's an integer vs the string 'new') to represent
different possibilities. This can have bad effects when type juggling
occurs, and it's also harder to figure out what the type of the
parameter can be (because a numeric ID might have been passed as a
string). Using integer vs null avoids all of this, and also allows us to
use nullable typehints.

These changes were partly copied from
If981cb35bf19a8469aa6c43c907e107cf8c65bc2 and should help with the
migration to the Filter value objects.

Change-Id: I8837d46c3c33761fea53f67b530b721dc7bd49b0
2020-10-10 12:23:50 +02:00
..
unit Represent new filters with null instead of 'new' 2020-10-10 12:23:50 +02:00
AbuseFilterConsequencesTest.php Merge "Add a new FilterProfiler service" 2020-10-10 10:08:58 +00:00
AbuseFilterCreateAccountTestTrait.php Add test traits for uploads and account creation 2020-10-04 13:16:58 +00:00
AbuseFilterDBTest.php Rewrite the VariableHolder code to translate deprecated variables 2020-09-29 15:06:14 +00:00
AbuseFilterParserEquivsetTest.php Introduce a KeywordsManager service 2020-09-28 23:03:52 +00:00
AbuseFilterSaveTest.php Represent new filters with null instead of 'new' 2020-10-10 12:23:50 +02:00
AbuseFilterUploadTestTrait.php Add test traits for uploads and account creation 2020-10-04 13:16:58 +00:00
AbuseFilterVariableGeneratorDBTest.php Add test traits for uploads and account creation 2020-10-04 13:16:58 +00:00
UpdateVarDumpsTest.php updateVarDumps: avoid using services in the constructor 2020-10-03 23:23:37 +00:00