Go to file
Daimona Eaytoy f0539e0c1e Represent new filters with null instead of 'new'
PHP is not strongly typed, so it's not a good idea to use scalars of
different types (here it's an integer vs the string 'new') to represent
different possibilities. This can have bad effects when type juggling
occurs, and it's also harder to figure out what the type of the
parameter can be (because a numeric ID might have been passed as a
string). Using integer vs null avoids all of this, and also allows us to
use nullable typehints.

These changes were partly copied from
If981cb35bf19a8469aa6c43c907e107cf8c65bc2 and should help with the
migration to the Filter value objects.

Change-Id: I8837d46c3c33761fea53f67b530b721dc7bd49b0
2020-10-10 12:23:50 +02:00
.phan Integrate with Renameuser 2020-10-01 08:10:22 +00:00
db_patches Merge "Actually apply patch-afl_change_deleted_patrolled." 2020-10-05 08:15:48 +00:00
i18n Localisation updates from https://translatewiki.net. 2020-10-09 08:24:34 +02:00
includes Represent new filters with null instead of 'new' 2020-10-10 12:23:50 +02:00
maintenance updateVarDumps: avoid using services in the constructor 2020-10-03 23:23:37 +00:00
modules Merge "ext.abuseFilter.edit.js - minor cleanup" 2020-09-30 09:30:14 +00:00
tests Represent new filters with null instead of 'new' 2020-10-10 12:23:50 +02:00
.eslintrc.json eslint config tweaks 2020-06-09 19:39:03 +01:00
.gitignore Add config for Selenium and basic tests 2019-09-17 16:23:07 +00:00
.gitreview Whoops, track not trace 2016-10-24 17:01:30 -07:00
.phpcs.xml Fix remaining PHPCS issues 2020-01-21 12:36:37 +00:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-10 21:00:53 +00:00
AbuseFilter.alias.php Add aliases for Serbian language 2018-12-24 02:16:55 +00:00
abusefilter.tables.pg.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sqlite.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 2018-09-01 05:29:54 +00:00
composer.json build: Updating mediawiki/mediawiki-phan-config to 0.10.3 2020-09-24 18:26:44 +00:00
COPYING Add COPYING 2014-01-22 21:21:10 +00:00
extension.json Merge "Add a new FilterProfiler service" 2020-10-10 10:08:58 +00:00
Gruntfile.js eslint config tweaks 2020-06-09 19:39:03 +01:00
hooks.txt Introduce a KeywordsManager service 2020-09-28 23:03:52 +00:00
package-lock.json build: Updating bl to 4.0.3 2020-09-09 18:15:30 +00:00
package.json build: Updating npm dependencies 2020-09-03 09:31:08 +00:00