mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git
synced 2024-11-24 14:13:54 +00:00
9f2906e34b
This patch removes the dependency of saveFilter on the ContextSource kitchen sink. It also removes some unneded dependency, and adds $originalRow/$originalActions as parameter, rather than hacky properties in $newRow that are easy to forget. The related test can also be greatly simplified. This also introduces a behaviour change: checking $newRow instead of the Request allows us to account for values normalization done in AbuseFilterViewEdit::loadRequest, and to also work correctly for imports (and generally speaking, it makes the method suitable for an AbuseFilterEdit API module, too). Next step is moving this method to a service. Some signatures, indenting, name choices etc. are subpar, but this is just because these methods are temporary anyway. Bug: T213037 Change-Id: I235b928d7b9c2ef1c46ea0bf3e3ed212500b4161 |
||
---|---|---|
.. | ||
parserTests | ||
parserTestsEquivset | ||
phpunit | ||
selenium |