Go to file
Daimona Eaytoy 9f2906e34b Reduce dependencies of AbuseFilter::saveFilter
This patch removes the dependency of saveFilter on the ContextSource
kitchen sink. It also removes some unneded dependency, and adds
$originalRow/$originalActions as parameter, rather than hacky properties
in $newRow that are easy to forget. The related test can also be greatly
simplified.

This also introduces a behaviour change: checking $newRow instead of the Request allows us
to account for values normalization done in
AbuseFilterViewEdit::loadRequest, and to also work correctly for imports
(and generally speaking, it makes the method suitable for an
AbuseFilterEdit API module, too).

Next step is moving this method to a service. Some signatures,
indenting, name choices etc. are subpar, but this is just because these
methods are temporary anyway.

Bug: T213037
Change-Id: I235b928d7b9c2ef1c46ea0bf3e3ed212500b4161
2020-10-09 11:52:02 +00:00
.phan Integrate with Renameuser 2020-10-01 08:10:22 +00:00
db_patches Merge "Actually apply patch-afl_change_deleted_patrolled." 2020-10-05 08:15:48 +00:00
i18n Localisation updates from https://translatewiki.net. 2020-10-07 08:34:11 +02:00
includes Reduce dependencies of AbuseFilter::saveFilter 2020-10-09 11:52:02 +00:00
maintenance updateVarDumps: avoid using services in the constructor 2020-10-03 23:23:37 +00:00
modules Merge "ext.abuseFilter.edit.js - minor cleanup" 2020-09-30 09:30:14 +00:00
tests Reduce dependencies of AbuseFilter::saveFilter 2020-10-09 11:52:02 +00:00
.eslintrc.json eslint config tweaks 2020-06-09 19:39:03 +01:00
.gitignore Add config for Selenium and basic tests 2019-09-17 16:23:07 +00:00
.gitreview
.phpcs.xml Fix remaining PHPCS issues 2020-01-21 12:36:37 +00:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-10 21:00:53 +00:00
AbuseFilter.alias.php Add aliases for Serbian language 2018-12-24 02:16:55 +00:00
abusefilter.tables.pg.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
abusefilter.tables.sqlite.sql Actually apply patch-afl_change_deleted_patrolled. 2020-09-21 14:52:22 +00:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 2018-09-01 05:29:54 +00:00
composer.json build: Updating mediawiki/mediawiki-phan-config to 0.10.3 2020-09-24 18:26:44 +00:00
COPYING
extension.json Move log formatters to a separate directory and namespace 2020-10-07 16:25:38 +02:00
Gruntfile.js eslint config tweaks 2020-06-09 19:39:03 +01:00
hooks.txt Introduce a KeywordsManager service 2020-09-28 23:03:52 +00:00
package-lock.json build: Updating bl to 4.0.3 2020-09-09 18:15:30 +00:00
package.json build: Updating npm dependencies 2020-09-03 09:31:08 +00:00