Daimona Eaytoy 2de5fce177 Refactor ConsequencesExecutor to process consequences in more steps ... Introduce shorter methods, one for each steps, so that it's easier to understand what the code is doing and figure out if the order makes sense. The ConsequencesExecutor test is now a proper unit test. Also simplify AbuseFilterConsequencesTest, removing old/wrong logic and fixing two expected values that were actually wrong (but worked because of the aforementioned wrong logic). The only functional changes should be: - We pick the longest block *after* checking the ConsequenceDisabler consequences, so e.g. if a filter has a long block + warn and another filter has a shorter block, we still keep the second one if warn will disable the block. - Remove disallow in presence of dangerous actions after checking ConsequenceDisabler's and deduplicating blocks. Otherwise we may remove disallow for filters where block (etc.) doesn't end up being disabled. We may also want to consider not removing disallow at all, now that messages are customizable. Bug: T303059 Change-Id: If00adbf2056758222eaaea70b16d3b4f89502c20		2022-03-19 15:49:36 +00:00
..
Api	Merge "Cast filter id to integer in AbuseLogPrivateDetails output"	2022-03-12 17:22:55 +00:00
ChangeTags	Introduce ActionSpecifier	2022-02-18 11:30:56 +00:00
Consequences	Refactor ConsequencesExecutor to process consequences in more steps	2022-03-19 15:49:36 +00:00
EditBox	Rename AbuseFilterCachingParser -> FilterEvaluator	2021-09-08 13:40:47 +02:00
Filter	build: Updating dependencies	2021-07-21 18:51:18 +00:00
Hooks	Use namespaced Renameuser classes	2022-03-06 17:10:41 +00:00
LogFormatter	Add a service to format filter specs	2020-12-19 14:22:08 +01:00
Pager	Clean up AbuseLogPager	2022-02-11 11:21:12 +01:00
Parser	Fix logging for parser exceptions	2022-03-07 13:32:54 +01:00
Special	Use updated ObjectFactory namespace	2022-03-09 22:17:07 +00:00
VariableGenerator	Replace WikiPage::factory in non-test code	2021-09-01 04:55:25 +00:00
Variables	Use new namespace for MediaWiki\Revision\RevisionLookup	2022-02-26 20:39:01 +01:00
View	Refactor ConsequencesExecutor to process consequences in more steps	2022-03-19 15:49:36 +00:00
Watcher	build: Updating dependencies	2021-07-21 18:51:18 +00:00
AbuseFilter.php	Drop non namespaced back compat aliases	2022-02-06 14:16:10 +00:00
AbuseFilterChangesList.php	Stop requiring the Skin interface in AbuseFilterChangesList	2021-09-25 10:28:50 +02:00
AbuseFilterPermissionManager.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
AbuseFilterPreAuthenticationProvider.php	SECURITY: Use an anonymous user as creator for autocreations	2021-04-16 14:34:16 -05:00
AbuseFilterServices.php	Rename ParserFactory -> RuleCheckerFactory	2021-09-08 21:59:34 +02:00
AbuseLogger.php	Remove afl_filter entirely	2021-09-18 11:06:10 +00:00
AbuseLoggerFactory.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
ActionSpecifier.php	Introduce ActionSpecifier	2022-02-18 11:30:56 +00:00
BlockAutopromoteStore.php	Add logging when the 'block' action fails	2022-03-05 19:12:53 +00:00
CentralDBManager.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
CentralDBNotAvailableException.php
EchoNotifier.php	Improve wording for throttled filter warnings	2022-02-22 11:10:19 +00:00
EditRevUpdater.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
EditStashCache.php	Refactor ParserStatus	2021-09-17 11:25:54 +00:00
EmergencyCache.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterCompare.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterImporter.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterLookup.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterProfiler.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterRunner.php	Introduce ActionSpecifier	2022-02-18 11:30:56 +00:00
FilterRunnerFactory.php	Rename ParserFactory -> RuleCheckerFactory	2021-09-08 21:59:34 +02:00
FilterStore.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
FilterUser.php	Add logging when the 'block' action fails	2022-03-05 19:12:53 +00:00
FilterValidator.php	build: Upgrade mediawiki-phan-config to 0.11.1	2021-12-05 11:29:54 +00:00
GlobalNameUtils.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
InvalidImportDataException.php	Adjust code coverage	2020-11-19 22:40:26 +00:00
KeywordsManager.php	build: Updating dependencies	2021-07-21 18:51:18 +00:00
RunnerData.php	Refactor ParserStatus	2021-09-17 11:25:54 +00:00
ServiceWiring.php	Improve wording for throttled filter warnings	2022-02-22 11:10:19 +00:00
SpecsFormatter.php	Improve wording for throttled filter warnings	2022-02-22 11:10:19 +00:00
TableDiffFormatterFullContext.php	Move remaining classes to own namespace	2021-01-04 12:11:58 +01:00
TextExtractor.php	Change comment for TextExtractor getNativeData to getText	2022-03-04 11:01:13 +02:00
ThrottleFilterPresentationModel.php	Improve wording for throttled filter warnings	2022-02-22 11:10:19 +00:00