wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-09-24 10:48:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up AbuseLogPager

Browse source 
- Make $mConds private and rename it.
- Use the injected permission manager.

Change-Id: Ie92b63da50264226bde5b3b361916bb31fd9448e
This commit is contained in:
Matěj Suchánek 2022-02-11 11:21:12 +01:00
parent 6b9098eae1
commit 95c0978dc6
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/Pager/AbuseLogPager.php
View file

@ -26,7 +26,7 @@ class AbuseLogPager extends ReverseChronologicalPager {
/**
* @var array
*/
public $mConds;
private $conds;
/** @var LinkBatchFactory */
private $linkBatchFactory;
@ -66,7 +66,7 @@ class AbuseLogPager extends ReverseChronologicalPager {
array $hideEntries = []
) {
parent::__construct( $context, $linkRenderer );
$this->mConds = $conds;
$this->conds = $conds;
$this->linkBatchFactory = $linkBatchFactory;
$this->permissionManager = $permManager;
$this->afPermissionManager = $afPermissionManager;
@ -341,10 +341,6 @@ class AbuseLogPager extends ReverseChronologicalPager {
* @return array
*/
public function getQueryInfo() {
$afPermManager = AbuseFilterServices::getPermissionManager();
$conds = $this->mConds;
$info = [
'tables' => [ 'abuse_filter_log', 'abuse_filter', 'revision' ],
'fields' => [
@ -352,7 +348,7 @@ class AbuseLogPager extends ReverseChronologicalPager {
$this->mDb->tableName( 'abuse_filter' ) . '.*',
'rev_id',
],
'conds' => $conds,
'conds' => $this->conds,
'join_conds' => [
'abuse_filter' => [
'LEFT JOIN',
@ -383,7 +379,7 @@ class AbuseLogPager extends ReverseChronologicalPager {
];
}
if ( !$afPermManager->canSeeHiddenLogEntries( $this->getUser() ) ) {
if ( !$this->afPermissionManager->canSeeHiddenLogEntries( $this->getUser() ) ) {
$info['conds']['afl_deleted'] = 0;
}