Commit graph

4465 commits

Author SHA1 Message Date
Brad Jorsch f6349e7a32 Update tests that fail with comment/actor migration
* AbuseFilterConsequencesTest is somehow leaving blocks behind. Mark
  ipblocks as being used to avoid that.
* AFComputedVariable::getLastPageAuthors() uses indeterminate order for
  multiple revisions with the same timestamp. Fall back to rev_id
  ordering like MySQL accidentally did before.
* AbuseFilterTest tries to create revisions attributed to users that
  don't exist. Switch to interwiki usernames.

Change-Id: I30f7cdcc3875f3f7af116c1e41e88f62ab9e91d0
2018-11-09 17:03:36 -05:00
Translation updater bot 6e275011a4 Localisation updates from https://translatewiki.net.
Change-Id: Ie648e875b31b3d199484a894e5df3b2e751ae71e
2018-11-08 22:17:58 +01:00
jenkins-bot 58018ac7cc Merge "Use log channel 'AbuseFilter' instead of 'AbuseFilter<Suffix>'" 2018-11-08 14:32:58 +00:00
Translation updater bot 2d9d777997 Localisation updates from https://translatewiki.net.
Change-Id: I154145679816a8e180ff3198a08e5a99aa2b8c7d
2018-11-07 22:21:40 +01:00
Timo Tijhof e7c0d5f238 Use log channel 'AbuseFilter' instead of 'AbuseFilter<Suffix>'
The channels are a fairly low-level primitive. Having multiple
in production for the same extension I think makes the logs
difficult to navigate and easy to miss things.

For the purpose of grouping, we have normalized_message instead,
which works by using the Monolog template string capabilities,
this is enabled in WMF Logstash (and in Beta).

Change-Id: I10b1fd2d9bdfe518089c053d77fef568170ecb65
2018-11-07 20:21:10 +00:00
Daimona Eaytoy 6658a24554 Remove typehint to avoid fatal error
Temporarily remove the typehint, as it causes some fatals. This doesn't
solve the underlying problem, for which we should first investigate with
I35bfc483a0c69a5cbd38eae8ba299189955fa1ec.

Bug: T208144
Change-Id: I0fdda51010243690ff3806c16d4e203c9ccd8e0a
2018-11-07 11:23:50 +01:00
Translation updater bot e580a51603 Localisation updates from https://translatewiki.net.
Change-Id: I22e7b799b2c1e620af4ed50c978855e44ba09e54
2018-11-05 22:24:16 +01:00
Translation updater bot 98cd23258f Localisation updates from https://translatewiki.net.
Change-Id: I67c551f995973ef31882cd81a61c961480ed371e
2018-11-04 22:41:56 +01:00
Translation updater bot 6ac1dc67c2 Localisation updates from https://translatewiki.net.
Change-Id: Ic1bb25684307511c6e0821359255c520dd88f374
2018-11-03 11:02:31 +01:00
jenkins-bot 917895b92c Merge "Replace deprecated OutputPage::parse/parseInline()" 2018-10-29 21:56:41 +00:00
Translation updater bot 88fc3863af Localisation updates from https://translatewiki.net.
Change-Id: I40a763361c749ba0225a1e289b00a66e3bf19f64
2018-10-29 22:14:00 +01:00
Translation updater bot 1fc297dad2 Localisation updates from https://translatewiki.net.
Change-Id: I53223e1c69594ba3ace56b8d416d88c368926c9c
2018-10-28 22:21:40 +01:00
Translation updater bot 61f4a48c5c Localisation updates from https://translatewiki.net.
Change-Id: I99eff0fe7a700cd3b387c4008774c44ec64b5bd8
2018-10-26 22:24:03 +02:00
C. Scott Ananian b73786df5c Replace deprecated OutputPage::parse/parseInline()
The OutputPage::parse/parseInline() methods emit untidy output and
are often used with the wrong user interface/content language
selection.  Replace with new methods added in 1.33 which are
tidy and consistent.

Bug: T198214
Depends-On: Ica79c2acbc542ef37f971c0be2582ae771a23bd0
Change-Id: Iec8071f4e50f169356e4f68ccb746c55f1606ea6
2018-10-26 13:33:20 -04:00
Translation updater bot 78e1b1edd9 Localisation updates from https://translatewiki.net.
Change-Id: Ifa609d816dfb5096de8d16e0869cf05bbda8932f
2018-10-25 22:38:30 +02:00
jenkins-bot c8d85e27b8 Merge "Use proper cache key construction for throttle, rules, and autoblock keys" 2018-10-24 10:10:51 +00:00
jenkins-bot 108ec1117f Merge "Reload the test user instance before checking the edit count" 2018-10-23 18:53:33 +00:00
Aaron Schulz 3191c2adc4 Reload the test user instance before checking the edit count
These are updated in deferred updates and should not rely on the same
User instance being used in those updates. This also avoids convoluted
logic in User to set the new edit count for various cases.

Change-Id: I6d239a5ea286afb10d9e317b2ee1436de60f7e4f
2018-10-23 18:06:12 +00:00
Daimona Eaytoy 103dfa3b66 Remove info leak
Oversighted/deleted edits and log actions were entirely accessible to
non-oversighters via AbuseFilter/examine for RC, and via AbuseFilter/test.
Now, we take into account the revision/log visibility and user permissions to
determine what to show.
Other changes in this patch:
*Show the examine link if and only if the user can examine the given row
*If a revision is hidden but the user can see it, don't hide its elements in
 ChangesList (only leave them striked/greyed)
*Make APIs better understand revision visibility.
*Make a clear distinction between deleted and suppressed edits/log
entries.

Co-authored with rxy <git@rxy.jp>

Bug: T207085
Change-Id: Icfa48e366a7e5e3abd5d2155ecfddfc09b378088
2018-10-23 10:53:39 +00:00
Translation updater bot 428a73f7e4 Localisation updates from https://translatewiki.net.
Change-Id: If6b50d1321158575983b66382d134c4f7ee08a81
2018-10-22 22:15:15 +02:00
Translation updater bot ee2bebf8e5 Localisation updates from https://translatewiki.net.
Change-Id: I63491d7709d6c7d2feaf249e284ba45475daf037
2018-10-21 22:37:32 +02:00
Aaron Schulz 5071c6574a Use proper cache key construction for throttle, rules, and autoblock keys
Change-Id: I72ab39048f955d4262fae81141cf97243e5cd184
2018-10-21 00:42:08 -07:00
Translation updater bot 304fd90b9c Localisation updates from https://translatewiki.net.
Change-Id: I62091c8d3e0c58b63c3fa05f12ca5a8f5e842c7c
2018-10-20 22:34:35 +02:00
Translation updater bot 0250d2f2e6 Localisation updates from https://translatewiki.net.
Change-Id: I40db2105f615f90a07ef33dee2bac085a5ae12fe
2018-10-19 22:19:42 +02:00
jenkins-bot 97602b8a68 Merge "Remove useless array_filter" 2018-10-19 10:14:56 +00:00
Translation updater bot 9bec66ddee Localisation updates from https://translatewiki.net.
Change-Id: I39b9876923fe04c0a4a1d98371ed2f843f4ff382
2018-10-18 22:34:04 +02:00
jenkins-bot 7e151f5edc Merge "Unbreak short circuit for arrays" 2018-10-18 04:04:31 +00:00
Translation updater bot ac30976f9c Localisation updates from https://translatewiki.net.
Change-Id: If12802da154144461650f2dc6131293ef22244f3
2018-10-17 23:43:52 +02:00
jenkins-bot eb1303c8cd Merge "Revert "Add typehinting for every object-only parameter"" 2018-10-17 03:09:55 +00:00
Jforrester 1ed75b4ae0 Revert "Add typehinting for every object-only parameter"
This reverts commit 69d7669069.

Reason for revert: Causing UBN train blocker

Bug: T207220
Change-Id: I3445d9b3065149e2beb149e10fbbf5502b480f57
2018-10-17 01:22:23 +00:00
Translation updater bot 2caea00544 Localisation updates from https://translatewiki.net.
Change-Id: I62549d63aff6688d60c60110b61e6f8c9627874d
2018-10-16 22:17:10 +02:00
jenkins-bot 7a8a2fa3e1 Merge "Add typehinting for every object-only parameter" 2018-10-16 02:48:39 +00:00
Translation updater bot 6f6186ed96 Localisation updates from https://translatewiki.net.
Change-Id: Iae90d832fda8196d20899961c383d616cb83d881
2018-10-15 22:15:41 +02:00
Daimona Eaytoy 69d7669069 Add typehinting for every object-only parameter
This patch covers every object-only parameter, adding a typehint for it
to avoid errors.

Change-Id: Iebf700621b9dbff78c3bd8f3c136ed15ef4b8d4b
2018-10-15 09:56:09 +02:00
Translation updater bot 7752e8ce1e Localisation updates from https://translatewiki.net.
Change-Id: I025f351ecf1311a89c9e8a4bf8eafd1bee1d8e20
2018-10-14 22:24:44 +02:00
jenkins-bot fea08f45b8 Merge "Avoid useless error message for regexfailure exception" 2018-10-14 13:47:37 +00:00
jenkins-bot 0109477607 Merge "Open the page for editing warning message in a new tab" 2018-10-14 13:38:33 +00:00
Matěj Suchánek a3cc3dff75 Remove some $wgUser usage
Bug: T159299
Change-Id: I1613e2bb0c551cbadc0c57351fc40bd9e21abf52
Depends-On: I35adef06dfc799cddeddfa6c5eed53b8b1bb7282
Depends-On: Id19a6d883ac6e0cc9c26c923486bca0e414ecaa7
2018-10-14 11:24:52 +02:00
jenkins-bot c2f5540928 Merge "Use fake timestamps for time-related tests" 2018-10-13 22:19:31 +00:00
Translation updater bot 62ba562cf1 Localisation updates from https://translatewiki.net.
Change-Id: I1edd45c34bf89e7ae756d6d2c81a06f046adceac
2018-10-13 10:19:01 +02:00
Daimona Eaytoy cbd57fe7a1 Simplify test parameters
Instead of having lots of huge arrays, use a fixed one and only
overwrite the needed parameters.

Change-Id: I3b2e763bd8835207dc5df1db43d3e1881e6961c3
2018-10-12 16:40:44 +02:00
Daimona Eaytoy f780704d14 Open the page for editing warning message in a new tab
Or in a new window, depending on user settings. In any case, not in the
current window without warning before leaving.

Change-Id: Ia64db1f9491d9cc55bee99321f0f14bd78785140
2018-10-12 10:40:05 +02:00
Translation updater bot c99328a6e6 Localisation updates from https://translatewiki.net.
Change-Id: If02c4105f7681166757c9485a87a2cbbd10940db
2018-10-11 22:37:03 +02:00
jenkins-bot 56fd27461a Merge "Allow selecting custom disallow message" 2018-10-11 18:32:48 +00:00
se4598 9d12e1b353 Allow selecting custom disallow message
You can now select a custom message to be displayed for disallowing a edit
the same way as for warn mode. This can be the same or a totally different
message.

This also solves the usecase, when a edit filter is set to warn AND disallow,
to be able to show the user a custom message, but the generic is shown
on the second try (disallow). Now it can be only set to disallow.

Bug: T27086
Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2018-10-11 10:35:01 +02:00
Translation updater bot 4cfc75b4a2 Localisation updates from https://translatewiki.net.
Change-Id: Ie0bcec0db146a5fe8fe181022c4ff7bc49f23cd5
2018-10-10 22:24:02 +02:00
Daimona Eaytoy 2ad63c95ef Use fake timestamps for time-related tests
With the hope to finally unbreak such tests, making them much more
stable and clean.

Bug: T206501
Change-Id: I275a088b9b21f47892b4e3c4cd11ef8680a9e6d9
2018-10-10 20:26:52 +02:00
jenkins-bot f9b0856e32 Merge "Simplify user_age test" 2018-10-10 00:18:07 +00:00
Translation updater bot 3ada124f9f Localisation updates from https://translatewiki.net.
Change-Id: Ie38e5acd230cec906e46898953a5d5c63c22233b
2018-10-09 22:12:42 +02:00
Daimona Eaytoy 70b60e5906 Simplify user_age test
This simplifies the test for user_age, although I'm not totally sure it
will be fixed. AFAICS, there's nothing wrong in there, but we'll see on
future phpunit executions.

Bug: T206501
Change-Id: Iee1a2a65d08c2cffc7a0d655be1eadb018d8bf37
2018-10-09 12:46:47 +02:00