Commit graph

4638 commits

Author SHA1 Message Date
jenkins-bot a813140e44 Merge "Unbreak /examine for old log entries" 2018-09-16 12:00:34 +00:00
jenkins-bot 3902b35a0d Merge "Allow testing account autocreation" 2018-09-16 11:57:41 +00:00
Translation updater bot a88fe64d49 Localisation updates from https://translatewiki.net.
Change-Id: Id5d085d26d56c79551eb2869cb43ac0ddf70b7bd
2018-09-15 09:53:34 +02:00
Daimona Eaytoy fc867a1c5c Allow testing account autocreation
Bug: T204231
Change-Id: If566cfdeb4cdbb78833077da09aeef33754f88d3
2018-09-14 13:09:07 +02:00
Daimona Eaytoy 31729b044e Unbreak /examine for old log entries
For the moment, this is a simple workaround to get them back working.
Ideally we'd also need a maintenance script to update var dumps as I
wrote in the task, but it needs more thinking (see Phab).

Bug: T204236
Change-Id: Ia20a2eb495557f46f789467a96e654ec6cd3f355
2018-09-13 18:42:47 +02:00
Matěj Suchánek 6eb5d9766b Use correct variable in AbuseFilter::addLogEntries
The data was inserted to the foreign database, so the id needs
to be fetch from that one.

Change-Id: I8eef8d74fc924829447e31f4445154b01b92aa7a
2018-09-13 11:57:55 +02:00
Translation updater bot 3016f32e3a Localisation updates from https://translatewiki.net.
Change-Id: I7c4bae9aeb5d4cd400036ee2c387329d97cc29d4
2018-09-13 10:15:08 +02:00
Translation updater bot 576d7e88d6 Localisation updates from https://translatewiki.net.
Change-Id: I943e6f99161d5cf7d9b6b8b01198d988c8e84d8c
2018-09-12 09:18:20 +02:00
Translation updater bot e3fb7dba0e Localisation updates from https://translatewiki.net.
Change-Id: I264760102dfb8df4fe3266c4483ff8e3dff888de
2018-09-11 10:24:01 +02:00
Translation updater bot 7877a7a472 Localisation updates from https://translatewiki.net.
Change-Id: I91dfe818335762ab64213736dedfb3536ea3b261
2018-09-10 09:31:20 +02:00
jenkins-bot a0a4755c59 Merge "Remove unused method from parser" 2018-09-09 12:32:56 +00:00
jenkins-bot 121df619da Merge "Improve coverage for AbuseFilterTokenizer" 2018-09-09 12:30:49 +00:00
jenkins-bot 151b1f6779 Merge "Make searched filters highlighting multibyte safe" 2018-09-09 12:25:17 +00:00
jenkins-bot dee934cd5a Merge "Partly unbreak throttle action" 2018-09-09 12:03:40 +00:00
jenkins-bot e4f986a661 Merge "Add full tests for deprecated variables" 2018-09-09 11:55:03 +00:00
jenkins-bot fb864408e3 Merge "Replace wfDebug and wfDebugLog with logger" 2018-09-09 11:55:02 +00:00
Translation updater bot 2933534a61 Localisation updates from https://translatewiki.net.
Change-Id: I1dcecd6265fcd04248f147a2aae34bdffe1520e9
2018-09-09 10:35:39 +02:00
Daimona Eaytoy 8885a5983e Partly unbreak throttle action
This action have ALWAYS had this problem: when creating a new filter,
the temporary ID is 'new', and the throttle ID is then 'new'.
This is used when creating/checking throttle keys to determine if the
user should be throttled. However, the 'new' key is not unique and
(although it's not the only part of the key), it may lead to
unpredictable behaviours. I'm not sure if this solves the task below,
but can probably help.
Also added a FIXME that we should handle shortly.

Bug: T195699
Change-Id: Id3b0ff524c52fb57fdd72f9608f758f8383e4320
2018-09-09 07:09:14 +00:00
Translation updater bot ca444f1df3 Localisation updates from https://translatewiki.net.
Change-Id: Iaea77329cb32bbc737b9353049b25bc6985a6024
2018-09-08 10:37:54 +02:00
L10n-bot 73983110f1 Merge "Localisation updates from https://translatewiki.net." 2018-09-07 07:04:10 +00:00
Translation updater bot 0eb5cedda2 Localisation updates from https://translatewiki.net.
Change-Id: I9b71f77923f6ac04a9b3a7bdda7d17fd531c5200
2018-09-07 09:02:12 +02:00
libraryupgrader 8913080a6b build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I0a070fd297aa28995462bc1a34a2681498f40cee
2018-09-07 06:41:55 +00:00
Translation updater bot 1fa52a1c67 Localisation updates from https://translatewiki.net.
Change-Id: I8919d27ddc376a50886a57e174907e18ec92685c
2018-09-06 09:00:23 +02:00
jenkins-bot 9cd7886f73 Merge "Change events used with the Ace editor" 2018-09-05 17:28:15 +00:00
jenkins-bot a3882d8c4a Merge "Only select needed columns in queries" 2018-09-05 17:11:42 +00:00
jenkins-bot a9f9742b28 Merge "Remove the last PHPCS exclusion" 2018-09-05 17:07:51 +00:00
MarcoAurelio 5b401328ac Use pinned npm dev dependency versions
To avoid upstream breaking stuff.

Change-Id: Ide83b44a4bc6af603e3844d0b66c22f3182ed482
2018-09-04 22:16:32 +00:00
Translation updater bot 16d656d293 Localisation updates from https://translatewiki.net.
Change-Id: Ib74dd3ece376ce5733f5a6680c534df42a7b2dce
2018-09-04 22:19:20 +02:00
Translation updater bot b6fcca555f Localisation updates from https://translatewiki.net.
Change-Id: Ied96eeccbd9915eaeb42d4286197b5c398457d9d
2018-09-03 22:14:45 +02:00
jenkins-bot 19853f6131 Merge "build: Update npm dev dependencies to latests versions" 2018-09-03 17:13:09 +00:00
jenkins-bot 317260a1ea Merge "Break long lines in JS code" 2018-09-03 17:13:07 +00:00
MarcoAurelio 94e079dc9b build: Update npm dev dependencies to latests versions
stylelint has v. 9.5.0 avalaible but stylelint-config-wikimedia
does require stylelint v. 9.2.0 or throws 'npm WARN' alerts. Can
be updated later.

npm WARN "eslint-config-wikimedia@0.7.2 requires a peer of eslint-plugin
-qunit@^3.3.0 but none was installed" fixed by adding that dev dep.

Depends-On: If9d5f8d4c341f2f273eda3f1fd54d59a04a9d263
Change-Id: I2de8e728c4c190c3f90653490ea48d0124a001e0
2018-09-03 16:34:07 +00:00
Daimona Eaytoy 063bdf0a4b Change events used with the Ace editor
Use an Ace-builtin "change" event on the editor so that it also triggers
for search&replace. Also, use "change" instead of "keyup" on the
textarea, just to be sure not to miss anything.

Bug: T203391
Change-Id: Ib246c30a575d140642c74e8ac08b24bdeaaf0347
2018-09-03 16:05:14 +02:00
Daimona Eaytoy e65a69b6fe Only select needed columns in queries
Using '*' is handy, but we often end up selecting too much stuff.

Change-Id: I16d791ff8de6596de4fb65b1032b225f0bd65bf3
2018-09-03 14:12:41 +02:00
jenkins-bot 7cce6d1864 Merge "Remove _age variables from cache keys" 2018-09-03 12:08:29 +00:00
Daimona Eaytoy db4a0a1eec Break long lines in JS code
Bug: T203365
Change-Id: If9d5f8d4c341f2f273eda3f1fd54d59a04a9d263
2018-09-03 10:49:24 +02:00
Daimona Eaytoy 63803568d6 Remove the last PHPCS exclusion
Bug: T178007
Change-Id: I5ddb811c2cb15040a859a63b64873f0fa53508ee
2018-09-03 10:42:30 +02:00
Daimona Eaytoy 48989ffcda Remove PHPCS exclusion and fix it
Again, we're left with only one exclusion that I don't know how to fix.
See phab for a longer explanation.

Bug: T178007
Change-Id: I017097abef755bc65c77a5658ad92320bc42d78b
2018-09-03 09:33:29 +02:00
libraryupgrader 5cdab14eb8 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
The following sniffs are failing and were disabled:
* Squiz.PHP.NonExecutableCode.Unreachable

Change-Id: Ic3f031974008776f272d1ee77093c6d170f27ae9
2018-09-02 22:05:58 +00:00
libraryupgrader 7decca9bdd build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: Icb04f4dcd56bfd3c7525e746e84fed8c482a038c
2018-09-01 05:29:54 +00:00
Translation updater bot 2373082c2f Localisation updates from https://translatewiki.net.
Change-Id: Ie0868ccba613c4a89e1f1215c2b3ecfef58a7f3d
2018-08-31 22:16:45 +02:00
Daimona Eaytoy 75b3321df0 Bump taint-check plugin to 1.3.1
Currently at 1.3.0.

Change-Id: Id5fcbe8421de239e5ae8c096d24c4366324e5fcc
2018-08-31 13:39:25 +02:00
Translation updater bot e3b9aa002d Localisation updates from https://translatewiki.net.
Change-Id: Iba6a981fea0b62d5e088b0bda7b8ebdec5251d88
2018-08-29 22:27:46 +02:00
Daimona Eaytoy bffba28713 Add full tests for deprecated variables
This test checks every deprecated variable to be identical to the
newly-named one, and to emit a debug notice. It also changes such debug
to be emitted via logger instead of wfDebug.

Bug: T201193
Bug: T173889
Change-Id: Ie55746bb7731062ae2d46d84857af2a05d78cf4c
2018-08-29 11:00:28 +02:00
Daimona Eaytoy 2f0a0a0893 Replace wfDebug and wfDebugLog with logger
Per standard on
https://www.mediawiki.org/wiki/Manual:Structured_logging. The use inside
AbuseFilterParser is removed in
Ie55746bb7731062ae2d46d84857af2a05d78cf4c.

Change-Id: Ia62287c4ff5f904557cd6d43d47a9f4d9696b94b
2018-08-29 10:57:56 +02:00
Translation updater bot 9270ee5280 Localisation updates from https://translatewiki.net.
Change-Id: Idb1adb013c47d83ee496c8ee9697912f379d8b56
2018-08-28 22:22:00 +02:00
Translation updater bot b0bf8b0e15 Localisation updates from https://translatewiki.net.
Change-Id: I769eb392d4d348858f7e9bd1850a9879f5bb89aa
2018-08-27 22:16:12 +02:00
Daimona Eaytoy 39f42caffc Make searched filters highlighting multibyte safe
Avoid using preg_match's offset since it is MB-unsafe. Also, remove 'UTF-8'
from mb_ functions (it's the default), reduce code duplication, and show
the right snippet for long search patterns.

Bug: T202310
Change-Id: Ieb06bdd80b0f915609afed7c7ad95e6318058ee9
2018-08-27 07:22:22 +00:00
Translation updater bot e4f0270272 Localisation updates from https://translatewiki.net.
Change-Id: I1b62ffef04993b31eccb791bbfd3c595db2440ec
2018-08-26 22:32:03 +02:00
Daimona Eaytoy 934399de45 Remove _age variables from cache keys
As we do for user_age, since these will always change. Also, rework the
method to avoid repetition of unset().

Change-Id: Ie5ceedd89cae3813bacf6680d588bc925362c2c2
2018-08-26 16:02:32 +02:00