Remove PHPCS exclusion and fix it

Again, we're left with only one exclusion that I don't know how to fix.
See phab for a longer explanation.

Bug: T178007
Change-Id: I017097abef755bc65c77a5658ad92320bc42d78b
This commit is contained in:
Daimona Eaytoy 2018-09-03 09:28:45 +02:00
parent 5cdab14eb8
commit 48989ffcda
3 changed files with 0 additions and 3 deletions

View file

@ -2,7 +2,6 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation" />
<exclude name="Squiz.PHP.NonExecutableCode.Unreachable" />
</rule>
<rule ref="Generic.Files.LineLength">
<exclude-pattern>AbuseFilter\.alias\.php</exclude-pattern>

View file

@ -254,7 +254,6 @@ class AbuseFilterPager extends TablePager {
)->parse();
case 'af_group':
return AbuseFilter::nameGroup( $value );
break;
default:
throw new MWException( "Unknown row type $name!" );
}

View file

@ -74,7 +74,6 @@ class GlobalAbuseFilterPager extends AbuseFilterPager {
case 'af_group':
// If this is global, local name probably doesn't exist, but try
return AbuseFilter::nameGroup( $value );
break;
default:
throw new MWException( "Unknown row type $name!" );
}