Commit graph

7712 commits

Author SHA1 Message Date
Bartosz Dziewoński a105ddf99a maintenance: Replace unnecessary uses of LBFactory::waitForReplication()
Change-Id: I7289e76ffa94b4cb0298bddad7423bb855c77e55
2024-02-03 02:52:16 +01:00
James D. Forrester 9f3e647738 build: Upgrade mediawiki/mediawiki-phan-config to 0.13.0
Change-Id: Id7026f2371db564f2341bc70c8a1786beb53bf39
2024-02-02 16:24:51 +00:00
jenkins-bot 34f39ce76e Merge "Don't attempt to steal or create the FilterUser in CheckUserHandler" 2024-02-01 23:26:09 +00:00
Translation updater bot 4668a40617 Localisation updates from https://translatewiki.net.
Change-Id: Ie863a0073d78a862bcff2fd1b8c01e6a4c0dec24
2024-02-01 08:59:49 +01:00
Dreamy Jazz a5b68cf46d Don't attempt to steal or create the FilterUser in CheckUserHandler
Why:
* When CheckUser asks the AbuseFilter extension for modifications
  to rows inserted into the CheckUser tables, the AbuseFilter
  extension attempts to get the Filter user via User::newSystemUser
* User::newSystemUser can deadlock if multiple requests to create
  the system user are being made at once.
* The CheckUserHander does not need to create the abuse filter system
  and instead only needs to know if a given $user is the equal to
  the FilterUser.
* As such the FilterUser service needs to provide a way to check if
  a given $user is equal without creating the FilterUser.

What:
* Add FilterUser::isUserSameAs which returns a boolean value
  indicating whether the Abuse Filter system user is the equal
  to a given UserIdentity in the same way that UserIdentity::equals
  is implemented.
* Refactor ::getUser to get the username for the filter user in
  a separate method, so that the ::isUserSameAs method can also
  use this method. Name this new method ::getFilterUserName.
* Add a test for the FilterUser service to ensure consistent test
  coverage
* Convert the @covers and @coversDefaultClass annotations to be
  a @covers for the class. This is because PHPUnit recommends this in
  https://docs.phpunit.de/en/9.6/annotations.html#appendixes-annotations-covers-tables-annotations

Bug: T356275
Bug: T346967
Change-Id: I8a101781bb47612deabb0f2a06a398ac13e860e6
2024-01-31 19:32:52 +00:00
Translation updater bot 02a1f7cbca Localisation updates from https://translatewiki.net.
Change-Id: Ia9efbd8d4c37e51800118747e0816fe0e9cccd96
2024-01-31 08:28:29 +01:00
Translation updater bot f9c4dec110 Localisation updates from https://translatewiki.net.
Change-Id: I5cbec26c49c22571be23495b8ca028370b49d0b6
2024-01-30 09:38:16 +01:00
Translation updater bot 0c754131b1 Localisation updates from https://translatewiki.net.
Change-Id: I1d1237ada8e1b24f2b05e368c8cbc2383eb1887d
2024-01-28 16:04:35 +01:00
gerritbot 71c181219a Remove indirect calls to IDBAccessObject::READ_* constants
We are getting rid of the schema of implementing this interface and
calling self::READ_* constants, it's confusing, inconsistent, prone to
clashes and isn't really useful for non-ORM systems (which we are not)

Bug: T354194
Change-Id: I5d7a2c91a49311a6bdf6e56053c08610d4d6d110
2024-01-26 09:25:35 -05:00
jenkins-bot 0342668682 Merge "Use ::getLocalUrl instead of ::getFullUrl for HideAbuseLog form" 2024-01-25 12:41:53 +00:00
Translation updater bot eb73b6e6c3 Localisation updates from https://translatewiki.net.
Change-Id: Ief59e01327592f617a5e1d16506a3c125ae12e5d
2024-01-25 10:08:58 +01:00
James D. Forrester 9f8941409a composer: Require wikimedia/equivset 1.6.1, which will ship with MW 1.42+
Bug: T355590
Depends-On: I5c7d1e67e45522669a88a75cb95e61feb116c588
Change-Id: Id9d641627a54bfa00f7ef8fe7198b7c1e8520978
2024-01-24 21:53:03 +00:00
Dreamy Jazz 1c0a5b9c6f Use ::getLocalUrl instead of ::getFullUrl for HideAbuseLog form
Why:
* The AbuseFilter Special:AbuseLog/hide page has a form that allows
  those with sufficent rights to hide abuse filter log entries.
* This form defines a custom action, which uses a URL including the
  wgServer by calling ::getFullUrl.
* When on WMF wikis and using mobile view, the domain name includes
  'm' and as such the wgServer is not the correct URL for the form
  action in this case.
* HTMLForm by default uses ::getLocalUrl for the action and as such
  Special:AbuseLog/hide should also use ::getLocalUrl to prevent
  these issues.

What:
* Change the call to ::getFullUrl in HideAbuseLog::show for the
  action text for the HTMLForm instance to instead be a call to
  ::getLocalUrl.

Bug: T355012
Change-Id: I6c909d5e6724dd620cf656c9a55439ed5d5c2fb4
2024-01-20 11:42:16 +00:00
Translation updater bot ca2ff0790a Localisation updates from https://translatewiki.net.
Change-Id: Ic447e1467ee00ef71ca9ee4bf1a223c40f6777da
2024-01-19 09:15:09 +01:00
Translation updater bot f470568611 Localisation updates from https://translatewiki.net.
Change-Id: I20af08359474abeae45462e45a9606ca2f9a0202
2024-01-18 09:23:14 +01:00
Reedy 4ea577a777 Remove old maintenance scripts
Bug: T353923
Change-Id: I3e599dee3775ca3048205b915d6c341ed2e37b74
2024-01-18 05:50:19 +00:00
Translation updater bot 79fdc1fbe7 Localisation updates from https://translatewiki.net.
Change-Id: Icb139d26bda142b90c77e92cd462bc5cb34c46c5
2024-01-17 08:36:40 +01:00
Translation updater bot 6da576b528 Localisation updates from https://translatewiki.net.
Change-Id: I6ebcadfe1582c65e7567334705b446fd7a46a002
2024-01-16 08:24:49 +01:00
Translation updater bot b840d25cad Localisation updates from https://translatewiki.net.
Change-Id: I6e42fee9fc79e872955b965710cb59d29f9a302d
2024-01-15 08:23:21 +01:00
Novem Linguae 0d33825853 Remove $this->tablesUsed from PHPUnit tests
Deprecated in T342301 in v1.41. This is now tracked
automatically. The variable can be safely deleted.

Change-Id: I7f42f3bfc58508421f4758089482fd1ed68c42c2
2024-01-14 04:45:29 -08:00
James D. Forrester 947e437566 extension.json: Drop RL targets definitions, no longer honoured
Bug: T328497
Change-Id: Ifed1146525a3b4370844144c7dafa2af0a98bd16
2024-01-12 08:38:57 -05:00
Translation updater bot 1a334deb61 Localisation updates from https://translatewiki.net.
Change-Id: I0e9b16be635680aa2ba16ed107eab08152543267
2024-01-12 08:59:20 +01:00
Translation updater bot 50786e86ed Localisation updates from https://translatewiki.net.
Change-Id: I57e92cef5f2b9c93da1ad0890e5e442590226663
2024-01-11 10:01:09 +01:00
Translation updater bot 407b707932 Localisation updates from https://translatewiki.net.
Change-Id: Ifdb3cdcfce8fa8b1b6be9b7ea83901a18cb6c5e0
2024-01-10 08:32:17 +01:00
Translation updater bot 88d514f0f1 Localisation updates from https://translatewiki.net.
Change-Id: Id879a6dda21a87440ce129584569fd6b841e4669
2024-01-09 08:58:34 +01:00
Translation updater bot 39c0dca35c Localisation updates from https://translatewiki.net.
Change-Id: I37fd5754b6c0bebb6c166e4d4afe050be3251261
2024-01-08 09:13:54 +01:00
Translation updater bot 744d05e59e Localisation updates from https://translatewiki.net.
Change-Id: I4a6622a760caca1d2ae405f8f5faa1f2f60e6c0a
2024-01-05 09:11:18 +01:00
Translation updater bot 2ad64b24fb Localisation updates from https://translatewiki.net.
Change-Id: I372ad609d332336523564f877aca98e5b0c26321
2024-01-04 09:54:58 +01:00
Translation updater bot 5c98d3f44e Localisation updates from https://translatewiki.net.
Change-Id: I0f3a19ef6d37c498e541b7e6c10283dc0af7446e
2024-01-03 08:33:51 +01:00
Taavi Väänänen 80a8764c8d
ActionVariablesIntegrationTest: Support JsonContent using tabs
Bug: T326065
Change-Id: I67c87484ea4ec23f703480c8d423b800c74f6518
2024-01-02 23:42:23 +02:00
jenkins-bot 16a4cda124 Merge "Blocked domains: Add support for "added by" field" 2024-01-02 19:38:03 +00:00
Translation updater bot 4ee54bd5a8 Localisation updates from https://translatewiki.net.
Change-Id: Ibcbfde148334d1b39d2d302244e4539d982d37d4
2024-01-02 08:47:20 +01:00
Translation updater bot 621b9e9220 Localisation updates from https://translatewiki.net.
Change-Id: I64c2b5f88e943a451903a3ae655fb59a8348e2f6
2023-12-29 19:20:36 +01:00
Translation updater bot 913d62159e Localisation updates from https://translatewiki.net.
Change-Id: I6579818f1b62bbe1da7fec067668ff90db23b78e
2023-12-28 14:48:48 +01:00
Amir Sarabadani d628a99442 Blocked domains: Add support for "added by" field
This field gets added automatically when using the special page form but
is only shown to admins and other people who have access. It's not private
information (users can find it in history) but this is to avoid making
these admins an easy target for harassment (Talking to PM of moderation
team he agreed this is a good compromise).

Bug: T341626
Change-Id: I8410f39db54b96981b05de8e064fed65df30ef2f
2023-12-27 04:37:42 +01:00
Translation updater bot 0e2f402651 Localisation updates from https://translatewiki.net.
Change-Id: Ibda91ac597e81d48cc7a908ae0f90b9ac9d7fb55
2023-12-26 14:41:57 +01:00
Translation updater bot bc9fa2bb64 Localisation updates from https://translatewiki.net.
Change-Id: I61eb4fa70d7af2bc052f742bf731e63d28cd7d54
2023-12-22 17:44:43 +01:00
jenkins-bot b53b3c652c Merge "Special:AbuseFilter page title should mention filter name" 2023-12-22 15:07:26 +00:00
Novem Linguae 88e9d8d0b6 Special:AbuseFilter page title should mention filter name
- Mentions filter number and name in the title
- Distinguishes between viewing and editing

Bug: T353106
Change-Id: Idda9854a78937033b168603810154b48288c3f4c
2023-12-22 04:55:37 -08:00
Reedy c0a374eab8 Drop some ancient schema changes
MW <= 1.34

Bug: T353923
Change-Id: Id5fd76857019c4882e31b185c8ba48ef5c1025a8
2023-12-22 02:07:48 +00:00
Reedy f7339cdc82 SchemaChangesHandler: Document when some changes were added
Bug: T353921
Change-Id: Ibe7c0780a3d1eebe35d6a6bce451a48fd57b545f
2023-12-22 02:07:13 +00:00
Translation updater bot 42dcf89dad Localisation updates from https://translatewiki.net.
Change-Id: I5333a343a66e8220497074ac2114a2000bc82bf8
2023-12-21 19:44:13 +01:00
Translation updater bot a3e8b2eae9 Localisation updates from https://translatewiki.net.
Change-Id: I07c5bc4d106a5cdb9f45f21ddbf0608db6d1be93
2023-12-20 14:03:59 +01:00
Translation updater bot f42b3978ba Localisation updates from https://translatewiki.net.
Change-Id: I98391bdd9391aa2dfe34257ee96a17098e28d76a
2023-12-18 18:15:03 +01:00
Paladox f1feb6c456 Fix "PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated"
Change-Id: Ic5eff58389a66f56bd2a9585c476dcde5a93f4d1
2023-12-15 23:01:09 +00:00
Translation updater bot 61fd5db1e9 Localisation updates from https://translatewiki.net.
Change-Id: Ieb2390b24fd82c1dbeedc47c35002413819b5cd5
2023-12-14 08:26:42 +01:00
Translation updater bot 9df0825cd1 Localisation updates from https://translatewiki.net.
Change-Id: I95a387307c66d1fcf383f4d8608fc92a449eec7e
2023-12-11 10:42:13 +01:00
Umherirrender bd84a6514c Use namespaced classes
This requires 1.42 for some new names

Changes to the use statements done automatically via script
Addition of missing use statements and changes to docs done manually

Change-Id: Ic1e2c9a0c891382744e4792bba1effece48e53f3
2023-12-10 23:03:12 +01:00
Translation updater bot 26c0920e47 Localisation updates from https://translatewiki.net.
Change-Id: I987b03ca50627970898726cf1ad22651670404c5
2023-12-08 14:44:26 +01:00
Translation updater bot 728c5af899 Localisation updates from https://translatewiki.net.
Change-Id: I6a2a0b87d54e5f1366e1c6d7ebd61fb8f9ad12fe
2023-12-07 10:00:36 +01:00