Commit graph

7025 commits

Author SHA1 Message Date
Matěj Suchánek dc59cad0a5 Replace VariableHolder::$forFilter
Each generator knows in which situation it is executed, and it
can pass this information to the computer. VariableHolder should
just hold the variables.

Change-Id: I0fb2e01e3e9457cd63948afe2a20439a1c800790
2022-12-02 08:10:15 +01:00
Translation updater bot 3bc6a4d3cc Localisation updates from https://translatewiki.net.
Change-Id: Ia319fd7fc2b241bec03a97020dbb7acd31e811c3
2022-12-01 08:14:22 +01:00
Translation updater bot 5455f12a36 Localisation updates from https://translatewiki.net.
Change-Id: Ia70de44bab4f3dbeec96356ea17cc3daae4cb430
2022-11-30 08:52:13 +01:00
Translation updater bot b4c18d6ec1 Localisation updates from https://translatewiki.net.
Change-Id: Ie045eb7efcf98208ad850fa4e83b10dc16d746f0
2022-11-29 08:57:55 +01:00
Translation updater bot e37f636ef7 Localisation updates from https://translatewiki.net.
Change-Id: I87cf70e89210fc3a104cc48712b9c73ad9d11cc6
2022-11-28 08:48:45 +01:00
Matěj Suchánek 702d77e3ce Create real integration test for variables
For fixing bugs like T65632, T105325, or T264104, we will need
to update code in more than one place at once. To prevent
regressions, create an integration test which tests the whole
pipeline, from the request submission to variable evaluation.
Edits are simulated using action=edit API call because the hook
AbuseFilter uses is run from EditPage.

To increase confidence in test coverage, remove some annotations
from AbuseFilterConsequencesTest or make them less greedy.
Ideally, it would only test consequences.

This patch includes refactoring of AbuseFilterCreateAccountTestTrait
which now only inserts the user into the database if it really
should be created.
It also restores test coverage of some other classes.

Change-Id: I661f4e0e2bcac4770e499708fca4e4e153f31fed
2022-11-26 18:51:38 +01:00
Translation updater bot e98e48473d Localisation updates from https://translatewiki.net.
Change-Id: Ibb73f3f5b8923f6c923d16c4ad850a133a969ba2
2022-11-25 08:24:47 +01:00
Translation updater bot ef8e67add0 Localisation updates from https://translatewiki.net.
Change-Id: I441d597991cca996c4c192df90fca851ea3d44c9
2022-11-24 08:16:15 +01:00
Translation updater bot afecfc8605 Localisation updates from https://translatewiki.net.
Change-Id: Ifb40e788d6b43035a197f05993a1be4cbd83fef2
2022-11-23 08:31:18 +01:00
Translation updater bot 1bf5fa23a6 Localisation updates from https://translatewiki.net.
Change-Id: I8b222282897c1cdf70959635a3f0218213112c08
2022-11-22 08:32:50 +01:00
Translation updater bot 049ba9101c Localisation updates from https://translatewiki.net.
Change-Id: I6d72f272a5b67a23f5383d0249c1bda3ced20c95
2022-11-21 08:14:53 +01:00
Translation updater bot 5392d4dcdc Localisation updates from https://translatewiki.net.
Change-Id: I67dd7a2140152ac1e4b6dfefb9930d09861771b7
2022-11-18 08:40:25 +00:00
jenkins-bot 6c34801068 Merge "Register AbuseFilter menu as standard tabs" 2022-11-17 17:45:26 +00:00
Jon Robson 62e96a46a8 Register AbuseFilter menu as standard tabs
Core now supports special pages registering sub menus
natively in skins. The menu is rendered when the skin
supports it, so at current time of writing this will
only work in Vector 2022 and MinervaNeue.

The existing menu that appears under the abuse filter
page title is converted into the new format. For other skins
no difference.

Bug: T315553
Change-Id: Ief51a9c60125c11e3b735fabee2a4544b7955f64
2022-11-17 16:35:34 +00:00
Translation updater bot 1781476fbf Localisation updates from https://translatewiki.net.
Change-Id: I21544640c6dcb035aef38e754e922730234e64ce
2022-11-17 08:26:13 +01:00
Reedy 4f4f01f96d EchoNotifierTest: Use namespaced Event class
Re-enables test

Depends-On: Ib57ea2db947285946f31fa9912b37181044df9d3
Change-Id: I082868f4759a5da14235803ebd8a80e794cfe41c
2022-11-12 06:28:33 +00:00
dreamyjazz 627a73ec5e Ensure IP, XFF and UA are valid for abuse filter user actions in CheckUser
Change the IP to 127.0.0.1 (to indicate an internal IP), and blank
the XFF and UA when the performer of an action being logged by
CheckUser is the abuse filter user. Actions performed by the abuse
filter user can only be initated by the software, and as such should
not use the request's IP, XFF and UA. Also test the newly added
code.

Bug: T44345
Depends-On: I28acaaebd2d0067b700da0930e7b7ba924fa5c1c
Change-Id: Idd77545af94f9f9930d9ff38ab6423a72e680df9
2022-11-11 23:19:22 +00:00
Translation updater bot 4473024899 Localisation updates from https://translatewiki.net.
Change-Id: I48c7fc7fcfeeef3e449544ee99206107b0248f55
2022-11-11 08:38:51 +01:00
libraryupgrader ffa85923c0 build: Updating grunt-stylelint to 0.18.0
Change-Id: I946aff31089712eb82e69012db7e12430a98b844
2022-11-11 00:31:57 +00:00
jenkins-bot 66a563ca09 Merge "EchoNotifierTest: Temporarily skip testNotifyForFilter" 2022-11-10 22:19:11 +00:00
jenkins-bot e26a863ad7 Merge "Fix missing null check for deprecated configuration" 2022-11-08 10:08:00 +00:00
Translation updater bot 6ec0fb8bf2 Localisation updates from https://translatewiki.net.
Change-Id: I5817bd809bf5f05cd9ab3e4fef5d9cee96471dee
2022-11-07 08:32:43 +01:00
thiemowmde 8f50f2a1a6 Fix missing null check for deprecated configuration
$wgAbuseFilterAnonBlockDuration is documented to be deprecated and
fall back to $wgAbuseFilterBlockDuration. This was just missing here.
This makes code fail in PHP 8.x where null is not allowed any more in
functions that expect a string.

Change-Id: I0edb0f14630aed88635aa564a11d6f42e470c29f
2022-11-04 15:36:13 +00:00
Translation updater bot 98edbc2f37 Localisation updates from https://translatewiki.net.
Change-Id: I68a17e87b9786f5c4183382bd5a368dbf3e1f916
2022-11-04 09:01:11 +01:00
Translation updater bot 998e0bd3f9 Localisation updates from https://translatewiki.net.
Change-Id: I114d3b87a30b3ce46656033a3f621f2ecf71f228
2022-11-03 08:23:41 +01:00
Reedy 97e0f30155 EchoNotifierTest: Temporarily skip testNotifyForFilter
Depends-On: Iddb4a5d4057f9c6ed00f754d2e3cd79cd873f212
Change-Id: Id28792658de950b99a8786f881563476def59eba
2022-11-03 00:28:15 +00:00
Translation updater bot 7b9b33c2c9 Localisation updates from https://translatewiki.net.
Change-Id: Ia9bea0baad35df84e0261f15f5c9e545695d906e
2022-11-02 08:37:17 +01:00
libraryupgrader 9d9c94826e build: Updating mediawiki/mediawiki-codesniffer to 40.0.1
Change-Id: I5e530f12d42ed137031aa01dad688df127ae2e56
2022-11-02 00:42:03 +00:00
Translation updater bot 5f1233f5e0 Localisation updates from https://translatewiki.net.
Change-Id: I21208a45bd30ae9e2c7fcfd66695a510fdc6b5fb
2022-11-01 08:49:49 +01:00
Translation updater bot 4934b98a0d Localisation updates from https://translatewiki.net.
Change-Id: I2c84b85c56d0d9865daa7d08e240e67e67625ef9
2022-10-31 09:44:52 +01:00
Translation updater bot aef0bf7260 Localisation updates from https://translatewiki.net.
Change-Id: I710438280a6803a1a3cc2025ee6b9121c05cd005
2022-10-27 08:54:05 +02:00
libraryupgrader 7201002047 build: Updating minimatch to 3.0.8
* https://github.com/advisories/GHSA-f8q6-p94x-37v3

Change-Id: I084310437a8b6c179554304059df5218e03c6158
2022-10-27 00:59:28 +00:00
Translation updater bot 9c0c0db1e8 Localisation updates from https://translatewiki.net.
Change-Id: I04ed12be2c9f863edb0c33dce5a29324afd00c44
2022-10-26 08:18:14 +02:00
libraryupgrader ff68482292 build: Updating npm dependencies
* mocha: 9.2.0 → 9.2.2
  * https://github.com/advisories/GHSA-f8q6-p94x-37v3
* recursive-readdir: 2.2.2 → 2.2.3
  * https://github.com/advisories/GHSA-f8q6-p94x-37v3

Change-Id: I9753da06dc8ba67d3635c65a4d4cc1da10030ca1
2022-10-26 00:32:04 +00:00
Translation updater bot e842170007 Localisation updates from https://translatewiki.net.
Change-Id: I1810c2f5f0c4b2d1f5a6428784b24433baa59b11
2022-10-24 08:21:26 +02:00
samtar e9e45cd225 AbuseFilterPermissionManager: Add sitewide block check
Add sitewide block check to `canViewPrivateFilters`

Bug: T296137
Change-Id: I2e4bceb8e35424d5c0c5ea902ed8f682bd33b6dc
2022-10-21 17:34:01 +00:00
Translation updater bot 297844ca11 Localisation updates from https://translatewiki.net.
Change-Id: I718012bdc08160fe2e97eccc0f9f4363a89761ef
2022-10-20 08:30:27 +02:00
Translation updater bot 66c0e96ce4 Localisation updates from https://translatewiki.net.
Change-Id: I906544626ce15acf4bf20707de3f10ee34a4dc28
2022-10-19 08:18:49 +02:00
Translation updater bot 8344607741 Localisation updates from https://translatewiki.net.
Change-Id: If8f1dbc64fe1dd3c5508975387daaa5cd90404bc
2022-10-17 08:19:44 +02:00
Translation updater bot 81275dc5eb Localisation updates from https://translatewiki.net.
Change-Id: Ib2bbcfaaede87a3677193e397cdf3b053a8e7fb5
2022-10-14 08:39:45 +02:00
Translation updater bot 007e68809a Localisation updates from https://translatewiki.net.
Change-Id: I0da71a01d6a8f0d30f930c39d473ade4e0b6e28a
2022-10-13 08:07:24 +02:00
jenkins-bot 34421d25b7 Merge "Localisation updates from https://translatewiki.net." 2022-10-10 08:23:45 +00:00
Translation updater bot 37a62a57c1 Localisation updates from https://translatewiki.net.
Change-Id: I72e8e529aef3b6f87bd5ed01acc38607bf35f5a2
2022-10-10 10:19:06 +02:00
Translation updater bot 851a588fe3 Localisation updates from https://translatewiki.net.
Change-Id: I399099a7b6d80532335be49c84d85ed91fa7be7d
2022-10-10 08:56:54 +02:00
Daimona Eaytoy 6a48423861 Avoid phan suppression
Document the parameter as non-empty instead.

Change-Id: Ia0f6b231fd05da82c1967e6b4e22bdd258435bba
2022-10-09 13:57:39 +02:00
jenkins-bot 02a733ac17 Merge "build: Updating dependencies" 2022-10-07 18:44:26 +00:00
libraryupgrader 380f7b010a
build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.11.1 → 0.12.0

npm:
* stylelint-config-wikimedia: 0.13.0 → 0.13.1

Change-Id: I424244de96b2da894d781047a1e336514cb7707c
2022-10-07 21:05:41 +03:00
Daimona Eaytoy 9f78933426 tests: Replace assertNotRegExp with assertDoesNotMatchRegularExpression
The method was renamed in PHPUnit 9.

Done automatically with:
  grep -rl assertNotRegExp tests/ | xargs sed -r -i "s/>assertNotRegExp\(/>assertDoesNotMatchRegularExpression\(/"

Bug: T243600
Change-Id: If0a7775cb96b3c4eb90b6dfe52d8647c12194ccc
2022-10-07 19:06:21 +02:00
James D. Forrester 94034ad727 build: Upgrade eslint-config-wikimedia from 0.22.1 to 0.23.0
Manually fixed as there's no fixer (and we're likely to bin this
rule upstream anyway as it has too many false positives).

Change-Id: Ia00113afa56af57c851ee8730760a60d6f858e7c
2022-10-07 11:09:55 -04:00
James D. Forrester 2d958ad093 build: Drop PHP dependency, irrelevant given MediaWiki version
Change-Id: I98f695971390bc0c836e7aac853f399436443dab
2022-10-07 10:44:59 -04:00