Commit graph

6714 commits

Author SHA1 Message Date
Umherirrender 637a88316b tests: Avoid Title::newFromText/title parsing
Using Title::newFromText is parsing the string, which is expensive.
Just use Title::makeTitle when the result is known.
editPage() can take a Title or WikiPage instead of a string, avoid
creation of Title there.
The default ns on editPage() is only needed when giving a string

Change-Id: Ie303b9e6d6b8d6ac80286059f8e86bfc76b779af
2022-06-28 22:46:45 +02:00
Matěj Suchánek b381636974 Extend RCVariableGeneratorTest
Make an edit, retrieve the recent change and test computed variables.

Change-Id: I04beed0b1f7c5adb47e71fd9b03102cb23838e16
2022-06-28 19:50:11 +00:00
jenkins-bot e6c61b94f3 Merge "Replace deprecated HTMLForm methods" 2022-06-28 19:47:11 +00:00
jenkins-bot 5f7e69757c Merge "pager: Fix LinkBatch for user name" 2022-06-28 19:33:19 +00:00
jenkins-bot c8dacb59d9 Merge "Use UserIdentity/Authority in SpecialAbuseLog" 2022-06-28 19:33:10 +00:00
Matěj Suchánek 5dca456535 Replace deprecated HTMLForm methods
Change-Id: Ic9ba981b94541b181acf88c3c40c205ab81962a8
2022-06-28 19:01:54 +00:00
Matěj Suchánek 7ae2060b27 Avoid array to object cast in filterToDatabaseRow
Both callers immediately call get_object_vars
to cast it back to array. Avoid this roundtrip.

Change-Id: I6525d76f8a03a4d28c2b50b580c539affe98064f
2022-06-28 18:46:28 +00:00
Umherirrender 1f8e6f5737 pager: Fix LinkBatch for user name
Adding the user id to the LinkBatch does not preload the correct page

Change-Id: Iacc852fe1f3ee74849af6146218aecaff70363d9
2022-06-28 20:37:41 +02:00
Umherirrender 9abc464e3d Use UserIdentity/Authority in SpecialAbuseLog
Change-Id: I5b3b2b758e17c94298e7217d755dd8c7b08cb1ac
2022-06-28 19:30:37 +02:00
jenkins-bot f9a2d4cf6c Merge "Use UserIdentity in FilterStore::doSaveFilter" 2022-06-27 21:56:57 +00:00
Umherirrender 5f979bcf16 Use UserIdentity in FilterStore::doSaveFilter
Change-Id: I8cbdaff1bd049a893b69f2ce13f0ba30b96f93b4
2022-06-27 22:39:37 +02:00
Umherirrender 30fefb75bf Use UserIdentity in ConsequencesExecutor
Change-Id: I281a30610595ed3e984f43aa747eff37abe72939
2022-06-27 22:05:18 +02:00
Translation updater bot 2d6ff71431 Localisation updates from https://translatewiki.net.
Change-Id: I7377708240ab7ecf160539317cd81c82d18a6b24
2022-06-27 08:17:17 +02:00
Daimona Eaytoy f33bc5868c Set the 'timestamp' var in addGenericVars
This was most definitely my intention when I introduced the concept of
"generic vars", so it's a bit surprising to discover, 3.5 years later,
that the timestamp isn't computed there.

Also make the timestamp always be a string for consistency, since that's
the type documented on mw.org. I've manually checked all filters on
Wikimedia wikis using the timestamp variable, and added explicit int
casts where needed (although I think they'd still work due to implicit
casts).

Change-Id: Ib6e15225dd95c2eead7e48c200d203d6918e0c18
2022-06-26 14:49:40 +02:00
Matěj Suchánek 40c5712311 Pass RecentChange to addGenericVars
Change-Id: Ia843c23b46ecf8e9fe987a538a09e69f845f4488
2022-06-25 13:03:03 +02:00
Umherirrender 3d3c45f348 tests: Mock WikiPage in unit test
Bug: T297688
Change-Id: Ic1655141564f02530b1ae6b625a1d3e261a00304
2022-06-24 22:22:24 +02:00
Translation updater bot 2e73774895 Localisation updates from https://translatewiki.net.
Change-Id: Iabd2131b111d7a40268373f09e31a6d52307884b
2022-06-24 09:29:54 +02:00
jenkins-bot f78a92cb2e Merge "Remove $info argument from ReversibleConsequence::revert" 2022-06-24 02:07:31 +00:00
Translation updater bot fac219ba0c Localisation updates from https://translatewiki.net.
Change-Id: Ie1e2a49b5ff2f2aa4d911e68d2bd03d85ddc21de
2022-06-23 09:01:53 +02:00
Translation updater bot 7a072b942c Localisation updates from https://translatewiki.net.
Change-Id: I65f56eebf85087c669eee2a127b150e19d753463
2022-06-22 08:12:46 +02:00
libraryupgrader 81749eb07f build: Updating got to 11.8.5
* https://github.com/advisories/GHSA-pfrx-2q88-qq97

Change-Id: I07af806a7c19c5dfe0e8fb897ab632da4da80c94
2022-06-22 05:03:44 +00:00
Translation updater bot dde42a85da Localisation updates from https://translatewiki.net.
Change-Id: I5a1d8ac67628772a214c940aa6d7390a98a35b65
2022-06-21 08:29:43 +02:00
Umherirrender d0499bfa13 Revert "Localisation updates from https://translatewiki.net."
This reverts commit fb05e25c82.

Reason for revert: Empty translation in aa.json not supported

Change-Id: I5ac74f4a06d7f86d6d657ea889ed995a7663b480
2022-06-20 16:26:42 +00:00
Translation updater bot fb05e25c82 Localisation updates from https://translatewiki.net.
Change-Id: I91636def75b631a6c2584a026f51b9a331fd96c7
2022-06-20 08:15:49 +02:00
Translation updater bot 325c13f61d Localisation updates from https://translatewiki.net.
Change-Id: I98cbb62d84003aa0860e5ed324acf1b33d7d01e2
2022-06-16 09:23:32 +02:00
Translation updater bot 445a53938b Localisation updates from https://translatewiki.net.
Change-Id: I84db3f06d80921b2a386b72a799b58baa0b21e99
2022-06-15 08:40:32 +02:00
Tim Starling 855347b4a4 Configure FilterProfiler cache separately
Since it seems to be the bulk of the traffic to the mainstash in
production.

Bug: T212129
Change-Id: Id20223ac03ada16b3ad4bd47744dea5e415cf160
2022-06-14 15:30:02 +10:00
Translation updater bot 17603e6e03 Localisation updates from https://translatewiki.net.
Change-Id: If2ab6417dc7a0b81234dbac367f7799655f1856b
2022-06-13 08:27:00 +02:00
Matěj Suchánek 40564ca635 Remove $info argument from ReversibleConsequence::revert
It was a temporary catch-all variable, but we can replace it
(and probably won't need it).

Change-Id: Ie1a64455c47445050bd83c853b3cafd283d5d020
2022-06-08 11:59:18 +02:00
Translation updater bot a44480c9e5 Localisation updates from https://translatewiki.net.
Change-Id: Iaaa9bb55b69fe42db88f65e3f879577149e3e54d
2022-06-08 08:26:14 +02:00
jenkins-bot 6fe7cd9648 Merge "Add class to AF log contribs link" 2022-06-07 08:11:46 +00:00
Translation updater bot 495e759d17 Localisation updates from https://translatewiki.net.
Change-Id: I598762ab38ef5025199f40a43d13e60d676519de
2022-06-07 09:59:55 +02:00
Translation updater bot a2719671a4 Localisation updates from https://translatewiki.net.
Change-Id: If060c98d7e3bd470e6ab1a0e0e152b3be12abcbd
2022-06-06 09:24:45 +02:00
jenkins-bot 1a6985469b Merge "Inline/simplify smaller pieces of duplicate/complex PHP code" 2022-06-03 20:38:22 +00:00
Thiemo Kreuz bbded6231c Inline/simplify smaller pieces of duplicate/complex PHP code
Change-Id: I59d0f17b77c8c3d47bc532bdefd9d8c0883f180b
2022-06-03 21:04:38 +02:00
Translation updater bot 5ffd528cc6 Localisation updates from https://translatewiki.net.
Change-Id: I88a284702b22a84bf5524817b032cd7b9a15322c
2022-06-03 08:56:57 +02:00
TerraCodes 2c0e61a030 Add class to AF log contribs link
Continuation of MW core change 603941

Change-Id: I16ade657179fdce40b8acb7f8be8cde8b9a64949
2022-06-02 09:34:38 +00:00
Translation updater bot 17f5f31487 Localisation updates from https://translatewiki.net.
Change-Id: I68e8b3195333e5660cb2b64c4b6c9571bfcd1e91
2022-06-02 08:13:18 +02:00
Translation updater bot 064a063004 Localisation updates from https://translatewiki.net.
Change-Id: I904ffb02bac108554235d736cbe4ab6d5724ca28
2022-06-01 08:19:50 +02:00
jenkins-bot bb94c0914c Merge "Add support for regex string replacements." 2022-05-31 14:54:33 +00:00
Translation updater bot 27ce7010fa Localisation updates from https://translatewiki.net.
Change-Id: I229df8fe4b714d5e0a130f9f865f1c3ad932bd94
2022-05-31 08:07:23 +02:00
Translation updater bot 69d3dc1cf1 Localisation updates from https://translatewiki.net.
Change-Id: Ibac6607ef207a560194f9a6a8fa293a2f367322a
2022-05-30 09:22:11 +02:00
Translation updater bot d55796129d Localisation updates from https://translatewiki.net.
Change-Id: Ia154931fa5eb59d6f4c1f42356f488f6b330539a
2022-05-26 08:50:44 +02:00
libraryupgrader 9d978abf71 build: Updating grunt to 1.5.3
Change-Id: Id7c6776fd27714d20938647de2ef9bcc36fddc72
2022-05-26 05:33:18 +00:00
Translation updater bot c243d6010e Localisation updates from https://translatewiki.net.
Change-Id: Ibd4bce06d066fcf43064407303b7993cc4f06663
2022-05-25 08:30:53 +02:00
Translation updater bot 4c154bec99 Localisation updates from https://translatewiki.net.
Change-Id: I8bfe29c47902837999d37e1fb14a4fd4ddaaec8c
2022-05-24 08:24:24 +02:00
Translation updater bot 63dc7dde69 Localisation updates from https://translatewiki.net.
Change-Id: I3b043345e6decee9fa792eab4bec119f6384dc0b
2022-05-23 08:15:50 +02:00
jenkins-bot f0ae0ec101 Merge "Optimize loop in 'diff-split' case" 2022-05-21 18:32:31 +00:00
Matěj Suchánek d4b15cb7ee Optimize loop in 'diff-split' case
The "substr( $line, 0, 1 )" expression has already assumed
the prefix has length 1. Therefore, it's pointless
to compute its length later. The assumption does hold,
the only two prefixes the code works with are '+' and '-'.

Not changing the check to use str_starts_with now, because
it was suggested in I113a8d052b6845852c15969a2f0e6fbbe3e9f8d9
that this shouldn't be done for performance-sensitive code
at least until we are on PHP 8.

Change-Id: I00cb2fc50ed534bb2bbef3ee1e5f6f466afeeb27
2022-05-21 18:07:21 +00:00
jenkins-bot 00ad47bab3 Merge "Fix validation for ip_in_ranges" 2022-05-21 15:24:20 +00:00