Commit graph

4308 commits

Author SHA1 Message Date
Guycn2 b40ded69cf Add colon to "Action type" field on Special:AbuseFilter/test
(for consistency with other fields on this page)

Change-Id: I21209cd335e6d6d65378963cbef908f928c84569
2018-06-29 03:41:25 +00:00
jenkins-bot 079f760b47 Merge "Make disabled variables not overridable" 2018-06-29 01:28:36 +00:00
Daimona Eaytoy 3a1ec5d229 Add missing i18n for sanitize function
The function was added with Ic916a6f8976e486d62d65156fa2dab56a55cf22a
but doesn't have messages for the dropdown.

Change-Id: Ibd7567a2b5277f6529e796a38871846abbfb4d54
2018-06-29 00:52:19 +02:00
Daimona Eaytoy ce83417068 Make disabled variables not overridable
Disabled vars can currently be overwritten by assigning them custom
values (e.g. old_text := 'foo'). However, this shouldn't be allowed to
avoid confusion.

Change-Id: I49136bf19371aee1e8068a9ae621310e1ab97c86
2018-06-28 22:40:09 +02:00
Translation updater bot 877d8ea608 Localisation updates from https://translatewiki.net.
Change-Id: I94ab0a54d237a90ea4a06364f8395b9e2719d234
2018-06-28 22:20:47 +02:00
Translation updater bot 74f5327e3f Localisation updates from https://translatewiki.net.
Change-Id: I99fdcdff35b586fed06e14d379c7dbf23d1beb19
2018-06-27 22:17:48 +02:00
jenkins-bot 02ca0be215 Merge "Fix SQLite syntax errors" 2018-06-27 00:33:18 +00:00
jenkins-bot 8b0f289e10 Merge "Stop computing removed variables and show custom error message" 2018-06-27 00:20:38 +00:00
Translation updater bot cfc1724f13 Localisation updates from https://translatewiki.net.
Change-Id: Iff2ac997739610ec49474d9fd08654729ff07087
2018-06-26 22:13:34 +02:00
jenkins-bot 4fb0cff163 Merge "Use content language for the revdel dropdown" 2018-06-26 18:41:13 +00:00
Daimona Eaytoy 79ec4ebf8b Stop computing removed variables and show custom error message
Old_text and old_html were disabled a long time ago. With this patch,
the user will get a custom error message if trying to use them (instead
of the unrecognisedvar one), plus they'll stop appearing in /examine and
/details, unless they were computed for the examined edit (and in that case, their description message is now restored). Lastly, added a precisation to their messages.

Bug: T190698
Change-Id: Ife168522e6b1d8eb94ebbb8a16ae8831ec1dc497
2018-06-26 20:02:31 +02:00
Daimona Eaytoy 61be1e9149 Fix SQLite syntax errors
The sync up made in I026472dec2629a969c46feb046f7fe64d8ab8144 introduced
several syntax errors for SQLite installer. They should now be all fixed.

Change-Id: I5fbe8b3719abef68d2549f119720b02fdd747a06
2018-06-26 14:50:57 +02:00
Daimona Eaytoy c75bc35f7d Rename lists to arrays
Arrays were introduced with the name "lists". While it **may** look
user-friendlier and so on, it actually uses a wrong name: lists are
different from arrays. I ran a grep and I should've replaced
every occurrence, plus everything seems to work, however a double check
wouldn't be bad.

Change-Id: I6a858f02f5dd9250ba7e1abf9c6422fd98758c9e
2018-06-26 14:42:23 +02:00
Daimona Eaytoy 40d9c5b027 Use content language for the revdel dropdown
Instead of the language set in user preferences.

Bug: T198182
Change-Id: I9f105cc3c926c51686ebb65ffbfffbbc161f9868
2018-06-26 14:37:13 +02:00
jenkins-bot 240e264833 Merge "Make /test filterable by action type" 2018-06-26 01:24:16 +00:00
jenkins-bot 1481b40b5d Merge "Make buildTestConditions more flexible" 2018-06-26 01:22:35 +00:00
jenkins-bot 625f1b92cd Merge "Reduce form whitespace on Special:AbuseFilter and compact variables" 2018-06-26 01:18:04 +00:00
Daimona Eaytoy 1394da924f Make /test filterable by action type
Bug: T20288
Depends-On: I2c51b695262b132a5c7cdfab20d56e36f43c7448
Change-Id: I9887c586955c1a1b34dbe641a8f9ad34de7a2e1d
2018-06-26 00:48:09 +00:00
Daimona Eaytoy c5da9cc6df Make buildTestConditions more flexible
This way, we can specify an action and it'll return only conditions for
that specific action. This is especially thought to make results
filterable by action type.

Change-Id: I2c51b695262b132a5c7cdfab20d56e36f43c7448
2018-06-26 00:45:33 +00:00
Translation updater bot e5b0846197 Localisation updates from https://translatewiki.net.
Change-Id: I10e13e33936b8fccfe45600a982960e4b35a4d53
2018-06-25 22:22:00 +02:00
jenkins-bot 40e7f440e6 Merge "Ace: use built-in function indexToPosition" 2018-06-25 10:41:42 +00:00
Translation updater bot d4db0b49d4 Localisation updates from https://translatewiki.net.
Change-Id: I54f6b256343018d4a04b9ccecdd46cc62526195c
2018-06-24 22:25:18 +02:00
Daimona Eaytoy 3c1dae9e14 Allow users with abusefilter-view-private to use testing interface
Now the required need will be abusefilter-modify OR
abusefilter-view-private for /tools, /test and /examine.

Bug: T193903
Change-Id: I3f1a91a2cc1df2272e5d4099cefd7c649a0683d5
2018-06-24 14:10:38 +00:00
jenkins-bot c34eda8936 Merge "Introduce sanitize() function" 2018-06-24 13:53:46 +00:00
Translation updater bot 4d97779c51 Localisation updates from https://translatewiki.net.
Change-Id: I2489b2da7cd75dfdd082e6a343726b266441a0a7
2018-06-21 22:42:20 +02:00
Daimona Eaytoy fcc07db95c Reduce form whitespace on Special:AbuseFilter and compact variables
The conversion to OOUI brought some extra whitespace that creates some
problems while viewing the page, especially with specific skins. This
patch compacts four different form fields in a single one, having the
side benefit of reducing the amount of used variables.

Bug: T189425
Change-Id: I75aa83e36d12db65d8b54c76b3ea14c8c797215e
2018-06-19 12:13:29 +02:00
Translation updater bot 0e4df34261 Localisation updates from https://translatewiki.net.
Change-Id: I43d59b7b098b2fbdf7b11be0b5562dabd38b3329
2018-06-18 22:09:25 +02:00
Translation updater bot 58ed24048d Localisation updates from https://translatewiki.net.
Change-Id: I5d47cdfd497ade70800e0fa33c8256c916b0d6a7
2018-06-17 22:27:46 +02:00
Translation updater bot 9dfbd0d63b Localisation updates from https://translatewiki.net.
Change-Id: Ibdb83009f28a5649021ed053c7a90de0a720f061
2018-06-16 22:25:54 +02:00
Translation updater bot 03158e1272 Localisation updates from https://translatewiki.net.
Change-Id: I75bc6d1a4fb91ea0a32efc0a37ae10b312a12910
2018-06-15 22:35:34 +02:00
Translation updater bot c31f384f5d Localisation updates from https://translatewiki.net.
Change-Id: I5dae60f0f98a523ad3f851d88326a32e9e0e1f20
2018-06-14 22:44:15 +02:00
jenkins-bot 519db0c6fc Merge "Make the "Load filter ID:" field on Special:AbuseFilter/test wider" 2018-06-13 23:03:08 +00:00
Translation updater bot 18b46d71cb Localisation updates from https://translatewiki.net.
Change-Id: I68db4a2ea26ba7fc6a89f79f8cf3badf3791b42e
2018-06-13 22:22:27 +02:00
Bartosz Dziewoński abe72f2937 Make the "Load filter ID:" field on Special:AbuseFilter/test wider
The translation can be a lot longer in languages which have no common
abbreviation like "ID" for the word "identifier". For example, the
label currently wraps over 3 lines in Polish (pl).

Change-Id: I822aafb52bbe840c00d2f0edbaeec37e3748f96f
2018-06-13 02:32:48 +00:00
Daimona Eaytoy 29492513cf Add phan seccheck to composer and remove deprecated module
Seccheck is currently being executed as non-voting, but it always
succeeds because AbuseFilter is not requiring it in composer. Instead,
let's add it: tests will start to fail, but we'll be able to see how
things are going with it. As a bonus, remove the mediawiki.api.parse
module, which is deprecated in 1.32 and replaced by mediawiki.api
(already loaded).

Change-Id: I094a8af4f97c03f8b538ede00420b123de25138a
2018-06-12 15:37:03 +02:00
Translation updater bot e2232714f8 Localisation updates from https://translatewiki.net.
Change-Id: Iaa5e133700405433dae57dfcb9da0c6727ff25b4
2018-06-11 22:33:20 +02:00
jenkins-bot 9eb736d63d Merge "Enable OOUI and add unused button to the output" 2018-06-10 03:13:20 +00:00
jenkins-bot a4a6511972 Merge "Don't allow invalid IP ranges to be entered in ip_in_range()" 2018-06-10 00:33:27 +00:00
jenkins-bot 8fa73341cf Merge "Remove all not needed & from hook handler signatures" 2018-06-09 09:22:29 +00:00
Translation updater bot 2dfc0b62d8 Localisation updates from https://translatewiki.net.
Change-Id: I0ab4a872a8d5094ab084bf9e6f8c0795189da6e6
2018-06-09 10:26:30 +02:00
jenkins-bot 075ccac1a2 Merge "Show throttled filters in Special:AbuseFilter" 2018-06-08 20:21:53 +00:00
Max Semenik 5c8a8da1f2 Fix some Doxygen problems
Change-Id: I04ce5564ec73e45a6d94c51be94bd1423a86780a
2018-06-08 13:02:40 -07:00
Daimona Eaytoy cf4ac34420 Show throttled filters in Special:AbuseFilter
With this patch, filters which are both enabled and throttled have an
"actions automatically disabled" label together with "enabled" and the
row is displayed in red. Plus, some minor changes like removing unused
fields from sortable ones and added a comment to getQueryInfo about used
columns (the idea is that it'll be easy to understand if a given column
is already there, plus if we'll need the missing one we may just replace
it with '*').

Bug: T154206
Change-Id: Iab157d094cbf2d50e9db537535fd48243e74af0b
2018-06-08 21:54:58 +02:00
jenkins-bot 1981c9f8b8 Merge "Add an option to hide private filters on Special:AbuseFilter" 2018-06-08 19:46:53 +00:00
jenkins-bot 5820b21ae3 Merge "Remove all default "return true" from hook handlers" 2018-06-08 19:42:02 +00:00
jenkins-bot 617e045483 Merge "Get rid of call_user_func_array()" 2018-06-08 19:32:31 +00:00
Thiemo Kreuz 9a185042b8 Update \AbuseFilter::checkSyntax documentation
Change-Id: I5c5caefab8d46773a459809d956a91fda7471863
2018-06-08 19:18:39 +00:00
libraryupgrader 25ddc87667 build: Updating mediawiki/mediawiki-phan-config to 0.3.0
Change-Id: I31b5a108f79ca1360338ecf07add2c07efe5b1e5
2018-06-08 06:37:45 +00:00
Max Semenik 4c312a2693 Get rid of call_user_func_array()
Yay PHP7!

Change-Id: I2ec13d1a51981c6922949bed0c7dd2525c48f591
2018-06-07 23:01:27 -07:00
Thiemo Kreuz 7f600d2ebe Remove all not needed & from hook handler signatures
Most of these are accidential, obsolete from a time when PHP4 required
these & to enforce passing by reference. This is the default since PHP5.
The issue with this & is that is (in theory) allows hook handlers to
replace the object with an entirely different one. Luckily this does
not work in all cases I'm aware of. But it is confusing, semantically.

Change-Id: If1e9e2723ef96308f9b4b27377398a5e497bfe70
2018-06-07 13:29:22 +02:00