Jack Phoenix
e2a16fe755
AbuseFilter: big commit - coding style & spacing cleanup; also marked SpecialPages' construct() and execute() functions as public and capitalized some SQL keywords
2009-10-07 13:57:06 +00:00
Andrew Garrett
13ab814753
AbuseFilter: Show permissions errors on new filter and importing a filter when the user does not have permission.
...
Resolves bug 20467
2009-09-18 10:05:20 +00:00
Andrew Garrett
6133a51192
Fix bug 19799, hide public versions of private filters.
2009-08-07 16:13:06 +00:00
Andrew Garrett
c89fb0e608
Fix for bug 19894, now preview and view/edit buttons for warning messages are no longer disabled for unprivileged users.
2009-07-27 10:48:07 +00:00
Andrew Garrett
94a9b2b174
Require tags to be valid page titles. In the message, gives general recommendations that they be short and simple, rather than specifying the exact criteria. I want to encourage simplicity in tags, rather than fixing an immediate problem
2009-07-17 15:37:03 +00:00
Andrew Garrett
4e3f9ab256
Add abusefilter-view-private right for viewing private abuse filters. Patch by Haza-w with stylistic and other minor adjustments
2009-07-03 14:17:05 +00:00
Andrew Garrett
fb9d1978cf
Change disabled to readonly for textboxes on uneditable filters
2009-07-03 13:54:08 +00:00
Andrew Garrett
3c51c81c93
Add condition limit profiling as well as time profiling to the abuse filter (bug 19256)
2009-07-03 13:46:51 +00:00
Andrew Garrett
98fb7d2689
log_action field now expanded to 32 chars, re-activating change logging
2009-07-03 12:48:28 +00:00
Andrew Garrett
695a2aad56
Fixes from bug 19135:
...
* Load abuse filter data from the master for edits, prevents unintended reversion in the case of replication lag.
* Load explicit field list, preventing another issue seen on Wikimedia and described in the comments.
2009-06-17 11:50:26 +00:00
Andrew Garrett
3018de0453
Per comments on code review, use JSON instead of PHP serialization for Abuse Filter data interchange. PHP's unserialize() can expose remote code execution vulnerabilities with some input.
2009-06-02 12:59:05 +00:00
Purodha B Blissenbach
b6b6c154c8
Message 'abusefilter-edit-lastmod-text' - date and time separated as of request by user "Der Umherirrende" at
...
http://translatewiki.net/w/i.php?title=Support&oldid=1243738#split_date_and_time
and user name added for GENDER use.
2009-06-01 23:15:23 +00:00
Andrew Garrett
48bfcc35ee
Various code quality fixes for AbuseFilter suggested by Tim Starling in a private email, including bugfixes, memory safeguards, performance improvements, removal of redundant code, consolidation of similar functionaality.
2009-05-26 13:08:15 +00:00
Tim Starling
268d72f43b
Code formatting and comments.
2009-05-22 06:42:10 +00:00
Andrew Garrett
32aedf1644
(bug 18077) PostgreSQL compatibility issues in AbuseFilter, patch contributed by Brad Jorsch
2009-04-24 03:27:14 +00:00
Andrew Garrett
1a0fc0fea9
Add import/export interface for filters so that filters can be copied across wikis
2009-04-23 04:23:56 +00:00
Andrew Garrett
7c3f048fff
Usability work, making abuse filter forms readonly (rather than just lacking a submit button and rejecting submissions) for users without permission.
2009-04-01 04:34:21 +00:00
Andrew Garrett
14b850f891
Implementation of global filters, including a major i18n change for abusefilter-log-detailedentry message (rename and split). Needs further testing before deployment
2009-03-30 06:12:12 +00:00
Andrew Garrett
9d9c666fea
Remove accidentally-committed code in r48856
2009-03-26 04:44:47 +00:00
Andrew Garrett
920f04d4fa
Fix batch-testing (follow-up to r48855)
2009-03-26 04:41:05 +00:00
Andrew Garrett
f234bcf66d
Add basic filter profiling to AbuseFilter -- display on the edit filter page the average time taken to run the filter. Currently sampling at 1/50
2009-03-19 02:40:48 +00:00
Andrew Garrett
1aa5ea69e8
Disable logging until logging table is fixed up
2009-03-17 23:54:56 +00:00
Raimond Spekking
06a1e8303d
Follow up r47847: Show the timestemp in users preference timezone
2009-03-11 18:58:38 +00:00
Andrew Garrett
fe5141c412
Add a normal log for filter changes, mostly just a pointer back to the real log.
2009-03-11 07:12:42 +00:00
Andrew Garrett
2f4a66e862
Do not display tools if there are not any
2009-02-19 23:52:08 +00:00
Tim Starling
c8b0007232
* Break long lines. If I'm going to review this code, I need to be able to read it.
...
* Write array literals with one item per line. This makes diffs which add or remove items far easier to interpret, and makes merging such changes feasible. And it looks nicer too.
* Use line breaks to show the logical structure of your code. This enhances readability. Bring similar elements in a list into alignment, in order to reveal the differences between those elements at a glance.
* Removed a fun game of spot-the-difference in AbuseFilterHistoryPager::getQueryInfo(). If I want fun games I'll play UFO:AI.
* Moved some oddly placed assignments (in expressions) to their own statements: such assignments reduce readbility.
2009-02-07 09:34:11 +00:00
Andrew Garrett
9e5d11e46b
Add an edit link too.
2009-02-03 22:54:46 +00:00
Andrew Garrett
60cfbf15c7
Add a fancy selector for the warning message in the Abuse Filter edit screen, and allow inline previews of the warning messages.
2009-02-03 22:45:42 +00:00
Andrew Garrett
fc1ecd6caa
Don't show tag filter boxes if no tags are defined. To support this change without bringing down servers, cache the list of valid tags in the object cache.
2009-01-30 23:24:29 +00:00
Andrew Garrett
bfed0d967d
Oops -- you don't need the -revert permission to test a filter! :D
2009-01-30 19:30:51 +00:00
Andrew Garrett
769d0a6ea2
Add a nice convenience link to the testing interface to the filter editing interface.
2009-01-30 19:19:03 +00:00
Andrew Garrett
8bea6e85f8
Hide action parameters if an action isn't selected.
2009-01-28 19:40:15 +00:00
Andrew Garrett
f4ddeab5a4
Require 'abusefilter-revert' right to display the 'revert' button on the edit page.
2009-01-28 19:12:57 +00:00
Andrew Garrett
8a54e6ba00
Branch merge of change-tagging branch with trunk
...
-- Introduce tagging of individual changes (revisions, logs, and on recentchanges). The tags are customisable, and currently settable by the Abuse Filter and by the TorBlock extension. The tags can be styled on the various pages on which they appear.
-- Introduces a schema change, three new tables (valid_tag, change_tag, and tag_summary).
2009-01-28 19:08:18 +00:00
Andrew Garrett
050575a5af
Allow users with the appropriate permission to mass-revert all actions (like blocking, deautoconfirming and degrouping) taken by a filter, with an appropriate summary.
2009-01-28 00:10:35 +00:00
Andrew Garrett
ca47e8c408
Add right- message, and actually make the right do something!
2009-01-27 20:18:36 +00:00
Andrew Garrett
c83f74b448
Mark 'block' and 'degroup' as 'restricted' actions -- actions which, if added to a filter, require the 'abusefiilter-modify-restricted' right to edit.
2009-01-27 19:51:38 +00:00
Andrew Garrett
0f1eb8db78
SCHEMA CHANGE:
...
For MySQL 4.0 compatibility, store a summary of actions in the abuse_filter table.
While I'm there, make the pseudo-internal names for actions localisable and therefore actually make sense to the average user.
2009-01-27 18:32:17 +00:00
Andrew Garrett
83d4b5a91f
Bold and apply a subtle background colour to the changed fields in Abuse Filter history -- will make things much easier to track.
2009-01-26 22:31:02 +00:00
Andrew Garrett
83cb0e5322
Don't save duplicate revisions...
2009-01-26 22:30:42 +00:00
Andrew Garrett
06275af974
E_NOTICE
2009-01-25 04:55:02 +00:00
Andrew Garrett
819986be43
Put filter-builterator on tools page.
2009-01-23 22:49:13 +00:00
Andrew Garrett
8ddd002c14
Remove dependency on change-tagging being branch-merged to trunk for now, and fix a few miscellaneous related bugs that came up in final testing.
2009-01-23 19:23:44 +00:00
Andrew Garrett
53179c675f
Apply changes from change-tagging branch. I will remove all of the stuff actually related to change tagging in a moment, to avoid trunk changes on Wikimedia sites.
2009-01-23 19:23:19 +00:00
