Commit graph

6259 commits

Author SHA1 Message Date
Translation updater bot a6396568b3 Localisation updates from https://translatewiki.net.
Change-Id: I7cab5826842713b624b8442c50576c29136c5cba
2020-02-28 08:21:10 +01:00
jenkins-bot 7e66b01cf3 Merge "Factor out get(Local|Global)Filters methods" 2020-02-27 20:33:56 +00:00
Daimona Eaytoy c9a4146f2c Add fixOldLogEntries to update.php
Already done in WMF production, see T228655.

Bug: T208931
Change-Id: Id477387d1607e263a6bf054060dc6dd440e88467
2020-02-27 18:19:50 +00:00
Translation updater bot 793d7e0a0f Localisation updates from https://translatewiki.net.
Change-Id: I221cc7e40e272b8f5ad2e543d33d2e39c8cf28fb
2020-02-27 08:34:55 +01:00
jenkins-bot 08c0a3f482 Merge "ViewEdit: add af_id to the row" 2020-02-26 16:53:35 +00:00
jenkins-bot b28e9e8c1f Merge "Start using new format for var dumps" 2020-02-26 16:51:02 +00:00
jenkins-bot 22adab7159 Merge "Stop using the Revision class" 2020-02-26 16:47:37 +00:00
Daimona Eaytoy f454e60e83 Start using new format for var dumps
Migrating old log entries is I22cf698c5be77506727cbd227c67e037a5d89b5c.

Bug: T213006
Change-Id: I3242acd5c5163a941f584d6119e3ad3b3cad8c29
2020-02-26 16:03:38 +00:00
jenkins-bot 8de3ecdb89 Merge "Replace usage of deprecated Page in favor of WikiPage/Article" 2020-02-26 15:49:19 +00:00
Daimona Eaytoy 518c176754 Stop using the Revision class
Change-Id: Ie257c9b1ea94dcadce59f4541d5947465262bd75
2020-02-26 15:39:12 +00:00
Daimona Eaytoy fe28aff82a ViewEdit: add af_id to the row
A PHP notice is sporadically emitted in production, e.g. reqId XlVEMgpAMNAAA6zMVhQAAACV

Change-Id: Ie42d00c6520aa31daf127c5df9515a3ab01d986f
2020-02-26 15:27:54 +00:00
Translation updater bot 389b6f3dc8 Localisation updates from https://translatewiki.net.
Change-Id: I11cbd5aa4e166f4fdd6465e49fcbee3c49cccaa7
2020-02-26 08:23:50 +01:00
Daimona Eaytoy b9a1e86245 Remove old number syntax
Bug: T212730
Change-Id: I7573da1683efc83b5002b8948c97dd7f6658a488
2020-02-25 23:38:19 +00:00
Daimona Eaytoy 1bac110205 Remove dependency on $wgRestrictionTypes
This was used to dynamically generate *_restriction_* variables.
However, it had two big problems:
 - We only have i18n for 'create', 'move', 'edit', and 'upload' (the
 default value of the global); other restrictions would show missing
 messages in various pages.
 - We had to access the global state in various points.

This change also makes some code in AbuseFilterVariableHolder simpler,
and also allows us to make AbuseFilterTest a unit test.

Change-Id: I321ad6e07f8243200af67a581b6e485970efd3ce
2020-02-25 23:17:54 +00:00
jenkins-bot e802e6556d Merge "Add string typehint to $summary in onParserOutputStashForEdit" 2020-02-25 22:56:27 +00:00
ArtBaltai 22925c5344 Replace usage of deprecated Page in favor of WikiPage/Article
Complete WikiPage/Article split and deprecate Page interface
Using actual WikiPage/Article contract

Bug: T239975
Change-Id: I343c3ca2e30715656950cab49c6470061c72b9a0
2020-02-26 01:03:49 +03:00
Translation updater bot 58d531861c Localisation updates from https://translatewiki.net.
Change-Id: I44b20b3510053a547d82743bbe358a3bccb5f328
2020-02-25 08:51:36 +01:00
Ammar Abdulhamid 323fe4666c Draw suppression reason from Revdelete-reason-dropdown-suppress
Bug: T245990
Change-Id: Ic5adcf4e6693cb5b4c849156e54d97cf35b70dee
2020-02-24 14:06:43 +01:00
Translation updater bot 544528a297 Localisation updates from https://translatewiki.net.
Change-Id: I9684fdd729db8f275db305ffdcd0274101cf2c69
2020-02-24 09:01:13 +01:00
jenkins-bot 84b3a590a3 Merge "tests: Use ChangeTags::getTags instead of hardcoded queries" 2020-02-23 10:35:39 +00:00
Daimona Eaytoy aa15267c79 Add string typehint to $summary in onParserOutputStashForEdit
Bug: T245928
Depends-On: I8fa287f335e90a59ac18365e7401a5cf703130a3
Change-Id: Ia075e4bdf3a3f011a181c8026ff1cdb8e186f096
2020-02-22 19:27:05 +00:00
Ed Sanders d86b74d3de eslint: Add /mediawiki rules
Change-Id: I1853e273fad3308349c79d188bc30de98fe116c4
2020-02-22 15:59:28 +00:00
Daimona Eaytoy bef72c7dc3 tests: Use ChangeTags::getTags instead of hardcoded queries
This is the "clean alternative" mentioned in the method comment!

Change-Id: Ieb87a1f512c930c2e33e721ba792986bc198e414
2020-02-22 13:54:23 +00:00
Translation updater bot 12c1c424c0 Localisation updates from https://translatewiki.net.
Change-Id: I0b3fdbb8abbb0d1e4c7655bfd610d838ac29d0c9
2020-02-21 09:38:01 +01:00
libraryupgrader b97818867d build: Updating npm dependencies
* grunt-stylelint: 0.13.0 → 0.14.0
* stylelint-config-wikimedia: 0.8.0 → 0.9.0

Change-Id: I3113038f3f57b63d2f7c1cf2e7b41946d1e52bdd
2020-02-20 17:23:00 +00:00
Translation updater bot 6df61ff3a9 Localisation updates from https://translatewiki.net.
Change-Id: I084c8f91a9bb16e1aa1f8b7128fcad55fd493a5f
2020-02-19 08:22:06 +01:00
Translation updater bot 72765c8a3f Localisation updates from https://translatewiki.net.
Change-Id: I91bb7a73642dadc48d4b300850fe7e871d9f711e
2020-02-18 08:24:33 +01:00
Translation updater bot e8344ac9d3 Localisation updates from https://translatewiki.net.
Change-Id: I05eeb3b3424c52271bbf27e23cfa4d5f6268defb
2020-02-17 08:44:34 +01:00
Translation updater bot e61b67b7f6 Localisation updates from https://translatewiki.net.
Change-Id: I0409d29695866c04f4d0bdfbbd69b5390eda9979
2020-02-14 08:24:58 +01:00
Translation updater bot 5889f6f187 Localisation updates from https://translatewiki.net.
Change-Id: I2c65f2a8a8b0ed2c70c767782834d9868b948b75
2020-02-13 08:53:58 +01:00
Translation updater bot 7722bb9c00 Localisation updates from https://translatewiki.net.
Change-Id: Ia35fcb8ce5e5ddacc5a93fdc53c264b495fc4556
2020-02-12 08:21:14 +01:00
Translation updater bot 7cd23c468a Localisation updates from https://translatewiki.net.
Change-Id: I0bfbaf1dd962f8ad723ce24d3333fbe40013bc45
2020-02-11 08:18:36 +01:00
jenkins-bot 76a1be97a4 Merge "Add site name and language variables" 2020-02-10 19:06:01 +00:00
jenkins-bot b6ca1402d0 Merge "Rename addStaticVars and related hook" 2020-02-10 19:03:34 +00:00
jenkins-bot 89e8797ca1 Merge "Validate imported data" 2020-02-10 19:00:48 +00:00
Daimona Eaytoy 0d2cab0deb Validate imported data
At the moment there's no validation for import data, so it's totally
possible to insert rubbish in the field, and the code will produce other
rubbish. For instance, it's not so uncommon to see lots of PHP notices
on logstash for ViewEdit code trying to access members of the imported
data as if it were an object.

Change-Id: If9d783f0f9242d3d1bc297572471e62f51ee0e40
2020-02-10 18:41:36 +00:00
jenkins-bot d89d919f76 Merge "Fix PHPNotice caused by missing row fields" 2020-02-10 18:14:27 +00:00
Daimona Eaytoy 9d8e004972 fixOldLogEntries: don't pass empty lists to Database::makeList
This made the script fail at a later stage, although it didn't cause any
harm.

Bug: T228655
Change-Id: I0c983cb4b5a262e81372fbd23f893ffb176eb9b5
2020-02-10 17:24:18 +01:00
Translation updater bot 83211b7e3a Localisation updates from https://translatewiki.net.
Change-Id: I36e67469f9a5991eb3f3e879feeb7d260e4d4cd3
2020-02-10 08:31:31 +01:00
Daimona Eaytoy 57415d8a31 Fix PHPNotice caused by missing row fields
Follow-up Ie9aae938cca06e38a7a834a3f74f3e8735ab01ee.

Some fields are actually necessary when the filter isn't saved. This
would cause PHP notices when showing the editor again.

Change-Id: I2b9e0f04b3e8ad4eea8e334e16ee422bb40f0eb5
2020-02-09 13:36:36 +00:00
Daimona Eaytoy d9ae71f578 Add site name and language variables
In T43172 it was told that adding the site name could increase the risk of
attracting more spam, but I don't see how this variable could cause that.

Bug: T240948
Bug: T97933
Change-Id: I1d2aeabaf008ac06798b8d7e4af7d61ae1702776
2020-02-09 14:32:02 +01:00
Daimona Eaytoy 661a77f0eb Rename addStaticVars and related hook
This code was introduced with Iba59fe8d190dd338ecc8cfd682205bce33c9738b
and is unused since then. The name should highlight that those variables are not
supposed to be "static", i.e. immutable. Examples are: timestamp, spam
blacklist, site name, site language. These are not immutable, but rather
"generic", and they're known even without an ongoing action.

Also add an RC row param and update docs.

Change-Id: I402f04585e9154059fc413e527e39dcb8e6b3d7c
2020-02-09 14:29:08 +01:00
jenkins-bot 77ab71e3cf Merge "fixOldLogEntries: Add missing pairs of parentheses" 2020-02-08 17:33:48 +00:00
jenkins-bot 391bbee53c Merge "Fix some edge cases in ViewEdit" 2020-02-08 16:36:19 +00:00
jenkins-bot c0b58d7699 Merge "Factor out variables-related methods" 2020-02-08 14:42:13 +00:00
Daimona Eaytoy 0834f37e42 Fix some edge cases in ViewEdit
Follow-up Iabd0ae5b18571f8cad44ef2d86bcf2519e7f95ba.

This patch:
 - Moves some save-related code to a separate method
 - Reduces conditionals nesting
 - Fixes an edge case where the content of the form would be
 wiped in case the token didn't match.
 - Adds another (basic) selenium test
 - Standardizes return types
 - Moves data load outside of buildFilterEditor

Change-Id: I89444b59f04c495c9ab59244151c8ed5d38cf0fe
2020-02-08 15:35:46 +01:00
Daimona Eaytoy d79970ef38 fixOldLogEntries: Add missing pairs of parentheses
Bug: T228655
Change-Id: I3bdb7e9efc8e12b055ba37440f1197fe6ed3b69d
2020-02-08 15:18:52 +01:00
jenkins-bot 430058f2c0 Merge "Avoid keeping superfluous row properties" 2020-02-07 21:26:34 +00:00
jenkins-bot 02cd866f53 Merge "Refactor data load in ViewEdit" 2020-02-07 21:26:32 +00:00
jenkins-bot 44998acf4d Merge "Move variable generators to new classes" 2020-02-07 20:41:25 +00:00