wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-27 23:40:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

ViewEdit: add af_id to the row

Browse source 
A PHP notice is sporadically emitted in production, e.g. reqId XlVEMgpAMNAAA6zMVhQAAACV

Change-Id: Ie42d00c6520aa31daf127c5df9515a3ab01d986f
This commit is contained in:
Daimona Eaytoy 2020-02-25 18:30:37 +00:00
parent 58d531861c
commit fe28aff82a
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/Views/AbuseFilterViewEdit.php
View file

@ -1241,6 +1241,7 @@ class AbuseFilterViewEdit extends AbuseFilterView {
if ( $filter !== 'new' ) {
// These aren't needed when saving the filter, but they are otherwise (e.g. if
// saving fails and we need to show the edit interface again).
$row->af_id = $origRow->af_id;
$row->af_user = $origRow->af_user;
$row->af_user_text = $origRow->af_user_text;
$row->af_timestamp = $origRow->af_timestamp;

2
tests/phpunit/AbuseFilterSaveTest.php
View file

@ -104,7 +104,7 @@ class AbuseFilterSaveTest extends MediaWikiTestCase {
->getMock();
if ( $existing ) {
$origValues = [ (object)self::$defaultFilterRow, [] ];
$origValues = [ (object)( self::$defaultFilterRow + [ 'af_id' => 1 ] ), [] ];
} else {
$origValues = [
(object)[