Andrew Garrett
1c87a7ba69
Fix some silly bugs in reautoconfirmation
2009-02-18 19:34:36 +00:00
Andrew Garrett
d3d4333f42
Fix silly fatal
2009-02-13 18:30:34 +00:00
Andrew Garrett
64154e283d
Correctly deal with emergency disabling, hit counts, etc for filters with 'throttle' and 'warn' actions.
2009-02-13 01:40:57 +00:00
Andrew Garrett
35e61feeb6
Abuse Filter Parser updates
...
* Deprecate parseTokens in favour of a parse-as-you-go approach, faster and uses less memory.
* Display variables in lower_case so they aren't SHOUTING_AT_PEOPLE.
* Tell people if they try to use variables that don't exist, rather than silently returning NULL.
2009-02-11 20:00:33 +00:00
Tim Starling
c8b0007232
* Break long lines. If I'm going to review this code, I need to be able to read it.
...
* Write array literals with one item per line. This makes diffs which add or remove items far easier to interpret, and makes merging such changes feasible. And it looks nicer too.
* Use line breaks to show the logical structure of your code. This enhances readability. Bring similar elements in a list into alignment, in order to reveal the differences between those elements at a glance.
* Removed a fun game of spot-the-difference in AbuseFilterHistoryPager::getQueryInfo(). If I want fun games I'll play UFO:AI.
* Moved some oddly placed assignments (in expressions) to their own statements: such assignments reduce readbility.
2009-02-07 09:34:11 +00:00
Andrew Garrett
53edcafc69
Reduce exception on encountering an unrecognised action to a debug log message.
2009-02-07 02:26:56 +00:00
Andrew Garrett
bcf5381eec
Fix up throttling -- was allowing one extra action.
2009-02-03 23:44:47 +00:00
Andrew Garrett
0918642869
Fix tester for titles which don't seem to work properly.
2009-02-03 18:48:16 +00:00
Andrew Garrett
3d13a2dc92
Fix double-prefixing.
2009-02-03 00:15:12 +00:00
Andrew Garrett
2e41b7d9d7
Fix abuse filter blocking *everything*.
2009-02-02 23:30:48 +00:00
Andrew Garrett
9eca9a7857
E_NOTICE
2009-02-02 17:57:06 +00:00
Andrew Garrett
6f91720eac
Allow af_public_comments to be wikitext.
...
Relatedly, add parseInline function to OutputPage, to avoid duplicating the same awful regex in wfMsgExt.
2009-01-31 01:59:13 +00:00
Andrew Garrett
61ad9a0aca
ADDED_LINKS was completely broken. Seems to have been comparing links in the old text to.... links in the old text!
2009-01-30 23:31:31 +00:00
Andrew Garrett
b68f53bef6
Check syntax before evaluating an expression
2009-01-30 23:23:52 +00:00
Alexandre Emsenhuber
65cec0be93
* Added new lines for source readability
...
* Change null to an empty string, so that Xml::element() doesn't generate a opening element only, which results in a XHTML error
2009-01-30 15:40:59 +00:00
Andrew Garrett
f16a825ab2
Filter out NewPP limit report from NEW_HTML variable. It's just not really necessary, and that stuff could be included as a separate variable in any case.
2009-01-29 23:46:19 +00:00
Andrew Garrett
2d24fcced0
Add a few missing messages, and fix a syntax error from r46557.
2009-01-29 23:36:09 +00:00
Andrew Garrett
783c69c3ba
Clarify rlike v. like in builder menu.
2009-01-29 23:28:59 +00:00
Andrew Garrett
3e90ea3eea
Don't show the 'disallow' action message if we're already showing other messages.
2009-01-29 23:24:24 +00:00
Andrew Garrett
f9c9c07ccf
Abuse Filter changes designed for testing filters against real data:
...
* Add searching and filtering functionality to the existing 'test' interface.
* Add an 'examine' interface designed for testing filters against a previous change, selectable through the search interface in either the 'test' or the 'examine' view.
* Minor enabling change in ChangesList core, to allow subclassing.
2009-01-29 22:44:31 +00:00
Andrew Garrett
cb5eca50fd
Add Special:AbuseFilter/test, which allows (trusted for now, due to DoS potential) users to enter a filter, and have it checked against the last 100 RecentChanges items while-u-wait.
...
Some related cleanup to change tagging in ChangesList.
2009-01-28 23:54:41 +00:00
Andrew Garrett
8a54e6ba00
Branch merge of change-tagging branch with trunk
...
-- Introduce tagging of individual changes (revisions, logs, and on recentchanges). The tags are customisable, and currently settable by the Abuse Filter and by the TorBlock extension. The tags can be styled on the various pages on which they appear.
-- Introduces a schema change, three new tables (valid_tag, change_tag, and tag_summary).
2009-01-28 19:08:18 +00:00
Andrew Garrett
c472ec7ff0
Fix RECENT_CONTRIBUTORS query -- apparently options need to be uppercased.
2009-01-28 06:29:59 +00:00
Andrew Garrett
c04e354053
Add some missing vars in the builder.
2009-01-28 02:56:47 +00:00
Andrew Garrett
36b78662b0
Refactor, pretty up and spread localisation of filter consequences (in logs, history, filter summary, etc)
2009-01-28 01:26:38 +00:00
Andrew Garrett
050575a5af
Allow users with the appropriate permission to mass-revert all actions (like blocking, deautoconfirming and degrouping) taken by a filter, with an appropriate summary.
2009-01-28 00:10:35 +00:00
Andrew Garrett
9775ea2787
Soften emergency disable feature, by making it only block restricted actions, rather than disabling the whole filter.
2009-01-27 20:18:58 +00:00
Raimond Spekking
53887bb338
* Add $wgAbuseFilterStyleVersion to SpecialAbuseLog::execute
...
* Remove one dupe call of addExtensionStyle from SpecialAbuseFilter::execute
* Bump $wgAbuseFilterStyleVersion per CSS changes in r46325
* Add a space between drop down and submit button
2009-01-27 17:32:30 +00:00
Andrew Garrett
6131d42c5d
Don't try to increment the hit counters if no filters were matched, waste of a DB query.
2009-01-27 05:22:24 +00:00
Andrew Garrett
54ee8685d3
Remove stray 'return' which was breaking hit counters.
2009-01-27 05:07:11 +00:00
Andrew Garrett
5861a0fed1
Add OLD_TEXT and NEW_TEXT variables, refactor variable storage, and clean up the AbuseLog interface just a little.
2009-01-27 01:31:42 +00:00
Andrew Garrett
11ab345814
Localise Abuse Filter exceptions.
2009-01-26 23:32:46 +00:00
Andrew Garrett
83d4b5a91f
Bold and apply a subtle background colour to the changed fields in Abuse Filter history -- will make things much easier to track.
2009-01-26 22:31:02 +00:00
Andrew Garrett
4adfc225f1
If no groups are being removed, then don't add a LogPage entry for the 'degroup' action!
2009-01-26 18:52:41 +00:00
Andrew Garrett
9916d54b81
Strict standards.
2009-01-25 05:12:05 +00:00
Andrew Garrett
819986be43
Put filter-builterator on tools page.
2009-01-23 22:49:13 +00:00
Andrew Garrett
8ddd002c14
Remove dependency on change-tagging being branch-merged to trunk for now, and fix a few miscellaneous related bugs that came up in final testing.
2009-01-23 19:23:44 +00:00
Andrew Garrett
53179c675f
Apply changes from change-tagging branch. I will remove all of the stuff actually related to change tagging in a moment, to avoid trunk changes on Wikimedia sites.
2009-01-23 19:23:19 +00:00
Andrew Garrett
83a741ee24
Do initialiseRange into Block::insert.
...
Fix related fatal in Abuse Filter.
2008-12-15 12:10:41 +00:00
Andrew Garrett
4f374b561d
Abuse Filter:
...
* Remove some old debugging code.
2008-11-15 01:19:20 +00:00
Siebrand Mazeland
30b422c330
Consistent casing for wfGetDB(), getDB(), and getDBKey()
2008-11-06 22:38:42 +00:00
Andrew Garrett
fe00c5e019
Minor bugs in abuse filter, plus new ALL_LINKS/ADDED_LINKS/REMOVED_LINKS
2008-10-24 08:58:32 +00:00
Andrew Garrett
0d52f1261a
Abuse Filter:
...
* Consolidate details on the last edit.
* Allow specification of a warning message to display instead of the standard warning (was already implemented in code, but there was no UI for it.
2008-10-21 14:11:03 +00:00
Andrew Garrett
56065d6a59
Re-commit re-autoconfirmation, with fixes for permissions
2008-09-29 13:30:11 +00:00
Andrew Garrett
a374d100ff
Revert r41145. Restoring autoconfirmed should really have access control, eh?
2008-09-22 14:07:04 +00:00
Andrew Garrett
74d4fa198f
Add a hacky tool for restoring autoconfirmed status when it's blocked by a filter. Don't expect it to get much use, so I haven't put much effort in. It gets the job done, though.
2008-09-22 09:16:45 +00:00
Andrew Garrett
8c66e81715
Make some obscure options actually useful, and mark some as obsolete.
2008-09-22 06:28:07 +00:00
Andrew Garrett
432d579ed6
Remove some debugging code
2008-09-21 13:17:11 +00:00
Andrew Garrett
bcca5492af
Don't log throttles, it should only log when the throttle is actually hit, not when it's incremented.
2008-09-21 13:08:10 +00:00
Andrew Garrett
00b46cef8b
Minor fix for last commit, and add DeleteQueue support.
2008-09-18 13:33:39 +00:00