Daimona Eaytoy
103dfa3b66
Remove info leak
...
Oversighted/deleted edits and log actions were entirely accessible to
non-oversighters via AbuseFilter/examine for RC, and via AbuseFilter/test.
Now, we take into account the revision/log visibility and user permissions to
determine what to show.
Other changes in this patch:
*Show the examine link if and only if the user can examine the given row
*If a revision is hidden but the user can see it, don't hide its elements in
ChangesList (only leave them striked/greyed)
*Make APIs better understand revision visibility.
*Make a clear distinction between deleted and suppressed edits/log
entries.
Co-authored with rxy <git@rxy.jp>
Bug: T207085
Change-Id: Icfa48e366a7e5e3abd5d2155ecfddfc09b378088
2018-10-23 10:53:39 +00:00
Translation updater bot
428a73f7e4
Localisation updates from https://translatewiki.net .
...
Change-Id: If6b50d1321158575983b66382d134c4f7ee08a81
2018-10-22 22:15:15 +02:00
Translation updater bot
ee2bebf8e5
Localisation updates from https://translatewiki.net .
...
Change-Id: I63491d7709d6c7d2feaf249e284ba45475daf037
2018-10-21 22:37:32 +02:00
Translation updater bot
304fd90b9c
Localisation updates from https://translatewiki.net .
...
Change-Id: I62091c8d3e0c58b63c3fa05f12ca5a8f5e842c7c
2018-10-20 22:34:35 +02:00
Translation updater bot
0250d2f2e6
Localisation updates from https://translatewiki.net .
...
Change-Id: I40db2105f615f90a07ef33dee2bac085a5ae12fe
2018-10-19 22:19:42 +02:00
jenkins-bot
97602b8a68
Merge "Remove useless array_filter"
2018-10-19 10:14:56 +00:00
Translation updater bot
9bec66ddee
Localisation updates from https://translatewiki.net .
...
Change-Id: I39b9876923fe04c0a4a1d98371ed2f843f4ff382
2018-10-18 22:34:04 +02:00
jenkins-bot
7e151f5edc
Merge "Unbreak short circuit for arrays"
2018-10-18 04:04:31 +00:00
Translation updater bot
ac30976f9c
Localisation updates from https://translatewiki.net .
...
Change-Id: If12802da154144461650f2dc6131293ef22244f3
2018-10-17 23:43:52 +02:00
jenkins-bot
eb1303c8cd
Merge "Revert "Add typehinting for every object-only parameter""
2018-10-17 03:09:55 +00:00
Jforrester
1ed75b4ae0
Revert "Add typehinting for every object-only parameter"
...
This reverts commit 69d7669069
.
Reason for revert: Causing UBN train blocker
Bug: T207220
Change-Id: I3445d9b3065149e2beb149e10fbbf5502b480f57
2018-10-17 01:22:23 +00:00
Translation updater bot
2caea00544
Localisation updates from https://translatewiki.net .
...
Change-Id: I62549d63aff6688d60c60110b61e6f8c9627874d
2018-10-16 22:17:10 +02:00
jenkins-bot
7a8a2fa3e1
Merge "Add typehinting for every object-only parameter"
2018-10-16 02:48:39 +00:00
Translation updater bot
6f6186ed96
Localisation updates from https://translatewiki.net .
...
Change-Id: Iae90d832fda8196d20899961c383d616cb83d881
2018-10-15 22:15:41 +02:00
Daimona Eaytoy
69d7669069
Add typehinting for every object-only parameter
...
This patch covers every object-only parameter, adding a typehint for it
to avoid errors.
Change-Id: Iebf700621b9dbff78c3bd8f3c136ed15ef4b8d4b
2018-10-15 09:56:09 +02:00
Translation updater bot
7752e8ce1e
Localisation updates from https://translatewiki.net .
...
Change-Id: I025f351ecf1311a89c9e8a4bf8eafd1bee1d8e20
2018-10-14 22:24:44 +02:00
jenkins-bot
fea08f45b8
Merge "Avoid useless error message for regexfailure exception"
2018-10-14 13:47:37 +00:00
jenkins-bot
0109477607
Merge "Open the page for editing warning message in a new tab"
2018-10-14 13:38:33 +00:00
Matěj Suchánek
a3cc3dff75
Remove some $wgUser usage
...
Bug: T159299
Change-Id: I1613e2bb0c551cbadc0c57351fc40bd9e21abf52
Depends-On: I35adef06dfc799cddeddfa6c5eed53b8b1bb7282
Depends-On: Id19a6d883ac6e0cc9c26c923486bca0e414ecaa7
2018-10-14 11:24:52 +02:00
jenkins-bot
c2f5540928
Merge "Use fake timestamps for time-related tests"
2018-10-13 22:19:31 +00:00
Translation updater bot
62ba562cf1
Localisation updates from https://translatewiki.net .
...
Change-Id: I1edd45c34bf89e7ae756d6d2c81a06f046adceac
2018-10-13 10:19:01 +02:00
Daimona Eaytoy
cbd57fe7a1
Simplify test parameters
...
Instead of having lots of huge arrays, use a fixed one and only
overwrite the needed parameters.
Change-Id: I3b2e763bd8835207dc5df1db43d3e1881e6961c3
2018-10-12 16:40:44 +02:00
Daimona Eaytoy
f780704d14
Open the page for editing warning message in a new tab
...
Or in a new window, depending on user settings. In any case, not in the
current window without warning before leaving.
Change-Id: Ia64db1f9491d9cc55bee99321f0f14bd78785140
2018-10-12 10:40:05 +02:00
Translation updater bot
c99328a6e6
Localisation updates from https://translatewiki.net .
...
Change-Id: If02c4105f7681166757c9485a87a2cbbd10940db
2018-10-11 22:37:03 +02:00
jenkins-bot
56fd27461a
Merge "Allow selecting custom disallow message"
2018-10-11 18:32:48 +00:00
se4598
9d12e1b353
Allow selecting custom disallow message
...
You can now select a custom message to be displayed for disallowing a edit
the same way as for warn mode. This can be the same or a totally different
message.
This also solves the usecase, when a edit filter is set to warn AND disallow,
to be able to show the user a custom message, but the generic is shown
on the second try (disallow). Now it can be only set to disallow.
Bug: T27086
Change-Id: Ic1de03a6944c43a346fa317ee0a217551f0d284a
2018-10-11 10:35:01 +02:00
Translation updater bot
4cfc75b4a2
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie0bcec0db146a5fe8fe181022c4ff7bc49f23cd5
2018-10-10 22:24:02 +02:00
Daimona Eaytoy
2ad63c95ef
Use fake timestamps for time-related tests
...
With the hope to finally unbreak such tests, making them much more
stable and clean.
Bug: T206501
Change-Id: I275a088b9b21f47892b4e3c4cd11ef8680a9e6d9
2018-10-10 20:26:52 +02:00
jenkins-bot
f9b0856e32
Merge "Simplify user_age test"
2018-10-10 00:18:07 +00:00
Translation updater bot
3ada124f9f
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie38e5acd230cec906e46898953a5d5c63c22233b
2018-10-09 22:12:42 +02:00
Daimona Eaytoy
70b60e5906
Simplify user_age test
...
This simplifies the test for user_age, although I'm not totally sure it
will be fixed. AFAICS, there's nothing wrong in there, but we'll see on
future phpunit executions.
Bug: T206501
Change-Id: Iee1a2a65d08c2cffc7a0d655be1eadb018d8bf37
2018-10-09 12:46:47 +02:00
Translation updater bot
82c4654afd
Localisation updates from https://translatewiki.net .
...
Change-Id: Icec8b4f8cd31958fd1f58d05325d28297edc34ca
2018-10-08 23:19:22 +02:00
Daimona Eaytoy
eafb4f56c7
Avoid useless error message for regexfailure exception
...
Users writing filters probably don't care about preg_match or whatever
happens in PHP. Also, it's not that useful to see "unspecified error".
Change-Id: I014742fa6f678126f55ac5ccff38e44b2c5a7d15
2018-10-08 19:19:01 +02:00
Translation updater bot
8d5c51d918
Localisation updates from https://translatewiki.net .
...
Change-Id: I328cae84216ca1d1e06945bc4dee9f54766978d7
2018-10-06 22:35:05 +02:00
Translation updater bot
80cd32d08a
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie8f3e961dbb80b496a37fd46003a979fbad8da44
2018-10-05 22:59:02 +02:00
Translation updater bot
531357ade3
Localisation updates from https://translatewiki.net .
...
Change-Id: I658819afb47c1ef94a3bda2a99d04a897209c17d
2018-10-04 22:23:56 +02:00
Translation updater bot
b83ed58de4
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifccf466a50faf9b12de5f4949766668b2c6727cd
2018-10-03 18:52:46 +02:00
Daimona Eaytoy
e60dacbbea
Fix code comments
...
Fixed some comments adding explanations, fixing syntax, and parameter types
for docblocks. Also fixed some whitespace mess, and added a missing use
statement.
Change-Id: I3547c90bdaa2cab5443e8bf0c63b217fe6ba663f
2018-10-03 16:45:03 +02:00
Daimona Eaytoy
d9d5af3890
Unbreak short circuit for arrays
...
This problem have been making filters potentially fail silently since
2009. Also add tests for arrays to make sure that no problems arise
when short circuit is used.
Bug: T204841
Change-Id: Ie4e2e06498c1202ba73afcc5d164a72427abbca5
2018-10-03 16:44:10 +02:00
jenkins-bot
3efc69960c
Merge "Fix database schema for PostgreSQL"
2018-10-01 15:43:29 +00:00
Umherirrender
45e6fa932d
Fix caller name in AbuseFilterHooks::fetchAllTags
...
Seeing {closure} in the logs as caller is not helpful
Change-Id: Id3bf5c7fd810d48dc04a167692b336b3ccba2eb4
2018-09-30 14:08:06 +02:00
Umherirrender
4fdd1bbf20
Fix caller name in AFComputedVariable::getLastPageAuthors
...
Seeing {closure} in the logs as caller is not helpful
Change-Id: I23ee52609510f8efefba8c1ee466d491f468f494
2018-09-30 14:06:04 +02:00
Matěj Suchánek
db50bef21e
Fix database schema for PostgreSQL
...
Bug: T62639
Change-Id: I5ddb781a2971677410f4cb96e5fc5964e53c862a
2018-09-29 12:12:52 +02:00
Translation updater bot
237f5170c1
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic6a3879e7fe507e0c29d3c1791e4120271c33014
2018-09-26 13:45:01 +02:00
Daimona Eaytoy
50d5137880
Remove useless array_filter
...
Not only it's useless, but also removes the namespace if it's 0, thus
causing the query to only add a WHERE on rc_title, but the index is on
rc_title AND rc_namespace, so the query has bad performance.
Bug: T204228
Change-Id: I33694cfeddbc4eaf39e3e840b207dba433188834
2018-09-24 14:34:53 +02:00
Translation updater bot
db432e0c02
Localisation updates from https://translatewiki.net .
...
Change-Id: Id2f0238963331438cbcd79302b3a0d9f9f186a07
2018-09-24 09:17:39 +02:00
Translation updater bot
be68b60614
Localisation updates from https://translatewiki.net .
...
Change-Id: I66e0abeaf5018ecfe44d54b7a7c5f95ac4906fbe
2018-09-23 10:26:28 +02:00
Translation updater bot
347d51bf61
Localisation updates from https://translatewiki.net .
...
Change-Id: I08b1770a7be62f4ced1962e4373eafebf0cf65cf
2018-09-22 10:02:58 +02:00
jenkins-bot
70eebbce11
Merge "Move all apihelp translatable messages to separate files"
2018-09-22 00:01:29 +00:00
Translation updater bot
7574a291d1
Localisation updates from https://translatewiki.net .
...
Change-Id: I19f05fab02359140df9e519eef468d265c7bf2de
2018-09-21 10:34:43 +02:00