wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-12-02 17:46:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
6080 commits 11 branches 20 tags 106 MiB
Commit graph

12 commits

Author SHA1 Message Date
Daimona Eaytoy 0a45c0abc8 Don't return the status of doBlockInternal when processing block actions 
This will not be correct if the target already has a partial block
applied (which is very rare BTW). Leaving a TODO because this is low
priority.

Also keep returning the status in tests, because it makes tests easier
to write.

Change-Id: Ifac795125927d584a31d95e1b4c4241eef860fa1
 2021-01-19 22:38:20 +00:00
Daimona Eaytoy 005cc83642 Increase coverage for more classes 
Change-Id: Iae6a24291f821fda77a45d8c1584de010af6a834
 2021-01-17 17:38:58 +00:00
Daimona Eaytoy 8639e0c368 Introduce subclasses of Filter with specific use cases 
In particular, this brings stronger typing for getID(), and we can get
rid of many phan suppressions.

Change-Id: Icbf3a6f7db8105082646ec227f62c09449fb165d
 2021-01-17 00:47:29 +00:00
Daimona Eaytoy ab2ad164ff Improve coverage around consequences 
Add a lot more unit tests, improve code testability, remove duplicated
integration tests.

Change-Id: Id8c9266ae107217047f267296070f26f575889d1
 2021-01-15 00:51:04 +00:00
Daimona Eaytoy 496e5baaa5 Remove deprecated VariableHolder::getVar 
Bug: T261069
Depends-On: I3468fa5339873efbbef1eaa22f4f654b4e9e166d
Change-Id: I46d69b0c43a45549ceddd837f2b37c76fec2e469
 2021-01-03 19:14:13 +00:00
Daimona Eaytoy 6e27a9ddb3 Cleanup variables-related classes 
Change-Id: I20a7fe1a40255043ed0d125dee61ea6052dda69c
 2021-01-02 18:19:38 +01:00
Daimona Eaytoy 762d71c51d Create a dedicated namespace for variables-related classes 
Some cleanup is left for later to keep the diff easier to read.

Change-Id: Ife445b5e47e707ab77ec867ac3b005866aa74ef2
 2021-01-02 18:16:48 +01:00
Daimona Eaytoy d3b330b6d4 Create a VariablesManager service 
This makes VariableHolder a true value object, and introduces a
stateless service, VariableManager, to operate on it.

Note, in theory, this new service is still cyclically coupled with
LazyVariableComputed. However, it's now two stateless service being
coupled, not two smart/god value objects, so we've still earned
something. For now, the dependency is hidden by using a callback. Some
alternatives for that are mentioned in a code comment.

Bug: T261069
Change-Id: I2f2c84c8e91472ba36084a8bbb4a923f6e04354b
 2021-01-02 17:15:31 +00:00
Matěj Suchánek 85a3e230e6 Harmonize HookAborterConsequence::getMessage implementations 
I think either all or none should consider global filters.
Are there any backwards compatibility concerns?

Change-Id: I22b664e9752588edc195dc4e4f5369392f91ad23
 2021-01-02 13:07:57 +01:00
Matěj Suchánek 2793e7f1cf Reversible consequences 
Introduce ReversibleConsequence interface for Consequence classes
whose potentially destructive actions can be reverted using
Special:AbuseFilter/revert. This allows moving reverting logic from
AbuseFilterViewRevert to individual Consequence classes and testing.

Unfortunately, the code is definitely not very clean now.

Change-Id: I558da711f1645ccf64792c6102cf743827171320
 2020-12-31 14:43:32 +01:00
Matěj Suchánek 63b950e5b6 Test some Consequence classes and clean up 
Sadly, these are not unit tests.

Bug: T201193
Change-Id: I4c977ab14b273b02803a63f0a7b152a581a838b2
 2020-12-19 16:31:22 +01:00
Daimona Eaytoy b394956c22 Create a dedicated namespace for all consequences-related classes 
Change-Id: Ibc39593e34da36e57b640af0b5bbf2145f725e92
 2020-12-18 19:27:33 +00:00