wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-13 17:27:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't return the status of doBlockInternal when processing block actions

Browse source 
This will not be correct if the target already has a partial block
applied (which is very rare BTW). Leaving a TODO because this is low
priority.

Also keep returning the status in tests, because it makes tests easier
to write.

Change-Id: Ifac795125927d584a31d95e1b4c4241eef860fa1
This commit is contained in:
Daimona Eaytoy 2021-01-19 15:26:20 +01:00
parent 2e72e3a952
commit 0a45c0abc8
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Consequences/Consequence/Block.php
View file

@ -57,7 +57,9 @@ class Block extends BlockingConsequence implements ReversibleConsequence {
$autoblock = true,
$this->preventsTalkEdit
);
return $status->isOK();
// TODO: Should we reblock in case of partial blocks? At that point we could return
// the status of doBlockInternal
return defined( 'MW_PHPUNIT_TEST' ) ? $status->isOK() : true;
}
/**