wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-12-02 17:46:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
6261 commits 11 branches 20 tags 106 MiB
Commit graph

6261 commits

This branch
This branch
All branches
Author SHA1 Message Date
Translation updater bot c5fa9900f4 Localisation updates from https://translatewiki.net. 
Change-Id: I4371e646c6e103eb75b3b2e2611467ed1a7a5626
 2021-01-25 08:51:59 +01:00
jenkins-bot 726da46c16 Merge "Catch FilterNotFoundException in ApiQueryAbuseLog" 2021-01-22 11:24:11 +00:00
Translation updater bot b2c466feb7 Localisation updates from https://translatewiki.net. 
Change-Id: I1d8bfd3a7be2f5f714ec05361b901251cdb34a23
 2021-01-22 08:29:48 +01:00
Daimona Eaytoy 44dd0f6c96 Catch FilterNotFoundException in ApiQueryAbuseLog 
And report an invalid ID in this case. Also, assume that the filter is
hidden if the global DB is not available, for consistency with the UI.

Bug: T272593
Change-Id: Ic08023161d95be5cadc8837d3aaaf941cacd89bd
 2021-01-22 01:54:40 +00:00
jenkins-bot 4f9676677c Merge "Don't return the status of doBlockInternal when processing block actions" 2021-01-21 10:25:46 +00:00
jenkins-bot 825537c232 Merge "Catch CentralDBNotAvailableException in ViewExamine" 2021-01-21 10:24:01 +00:00
Translation updater bot 4eb0981383 Localisation updates from https://translatewiki.net. 
Change-Id: I547d0530f1f2d6b35515e4301aa4e7ad5616865e
 2021-01-21 08:30:48 +01:00
jenkins-bot 5d6f81981b Merge "Catch ClosestFilterVersionNotFoundException in ViewDiff" 2021-01-20 17:33:24 +00:00
jenkins-bot 5e3d5189d1 Merge "Do not mock User in TextExtractorTest." 2021-01-20 17:06:05 +00:00
Daimona Eaytoy 2c9f2faa9f Catch ClosestFilterVersionNotFoundException in ViewDiff 
Use null if no version can be found, like the previous code.
Follow-up: I747216df65c2f34f7167612e90506890bc61880a

Bug: T272505
Change-Id: Ie574523fb8a779dda495b05ed6d56fd3f4086f1d
 2021-01-20 17:25:47 +01:00
Petr Pchelko 6aa8f6f67b Do not mock User in TextExtractorTest. 
In I63d9807264d7e2295afef51fc9d982447f92fcbd we are
changing how the permission checks are applied for revision,
so it uses passed User instance as Authority. However, when
user is mocked, the tests are breaking since the new user methods
are not mocked. Pass a real user for now to fix the test. Once
Authority reaches maturity and is ok to use in extensions, the
test should be rewritten to use authority directly.

Bug: T271458
Change-Id: Iacab813b253cc6e1439007e573e8ace06645860f
 2021-01-20 09:32:18 -06:00
Translation updater bot eede3a6903 Localisation updates from https://translatewiki.net. 
Change-Id: Ie951f144d7bc213233264e1e094157827d635328
 2021-01-20 08:26:01 +01:00
Daimona Eaytoy 0a45c0abc8 Don't return the status of doBlockInternal when processing block actions 
This will not be correct if the target already has a partial block
applied (which is very rare BTW). Leaving a TODO because this is low
priority.

Also keep returning the status in tests, because it makes tests easier
to write.

Change-Id: Ifac795125927d584a31d95e1b4c4241eef860fa1
 2021-01-19 22:38:20 +00:00
Daimona Eaytoy 7800c3fdcf Catch CentralDBNotAvailableException in ViewExamine 
Bug: T272361
Change-Id: Ic7e5b5a4c55264fe340fec88be4cef1461d4de42
 2021-01-19 14:54:18 +01:00
Translation updater bot 2e72e3a952 Localisation updates from https://translatewiki.net. 
Change-Id: Id621c60cae6da2bd2e4d5d50e797534c1e0932f1
 2021-01-18 08:35:52 +01:00
jenkins-bot daaf9a6bbe Merge "Increase coverage for more classes" 2021-01-18 00:07:28 +00:00
Daimona Eaytoy bebc7b40de Bump cache key version of FilterLookup::getAllActiveFiltersInGroup 
The DB lookup was changed to return ExistingFilter objects, not Filter,
and FilterRunner also requires ExistingFilter's. So update the version
to avoid fatals due to cached data.

Bug: T272248
Change-Id: I1076f65df5b6d030cea40beb2266c9ec54fa675f
 2021-01-17 23:55:11 +01:00
Daimona Eaytoy 005cc83642 Increase coverage for more classes 
Change-Id: Iae6a24291f821fda77a45d8c1584de010af6a834
 2021-01-17 17:38:58 +00:00
jenkins-bot 3306c341fc Merge "Make User::get* calls explicit in LazyVariableComputer" 2021-01-17 02:49:20 +00:00
Daimona Eaytoy bae4d8f20d Use FilterLookup in HistoryPager to retrieve the previous version 
Change-Id: I6d8548b4e5171b4ccbc42dd0d57079c3bda40a03
 2021-01-17 00:47:38 +00:00
Daimona Eaytoy 22b408d9e6 Use Filter objects in ViewDiff 
And cleanup weird spacing, conditionals, etc.

Change-Id: I747216df65c2f34f7167612e90506890bc61880a
 2021-01-17 00:47:33 +00:00
Daimona Eaytoy 8639e0c368 Introduce subclasses of Filter with specific use cases 
In particular, this brings stronger typing for getID(), and we can get
rid of many phan suppressions.

Change-Id: Icbf3a6f7db8105082646ec227f62c09449fb165d
 2021-01-17 00:47:29 +00:00
Daimona Eaytoy ed49f86b74 Make User::get* calls explicit in LazyVariableComputer 
With explicit calls it's easier to see what method is being used,
whether it's deprecated, etc. Some methods here are in fact deprecated
or already have a proper replacement, but this is left for a follow-up.

Change-Id: Iee3154855f86c76aab98e7c14250c14e8b9ee939
 2021-01-17 00:35:40 +00:00
jenkins-bot 64eb1c2688 Merge "Improve coverage for several classes" 2021-01-16 23:40:52 +00:00
Daimona Eaytoy a4d3548d47 Remove dead code 
Change-Id: I4f4065aeaf5b015679c28808be430f8af99d1294
 2021-01-16 16:59:42 +01:00
Daimona Eaytoy 5fcc5ef357 Improve coverage for several classes 
Change-Id: I257524dd22a5617ac47a3565a5b8fe4855aa67c7
 2021-01-16 15:01:40 +00:00
Umherirrender 717abf4300 Improve function and property documentation 
Removed some wrong @param from test function,
the @dataProvider should be a enough here

Change-Id: I82d81d066d916d3326169315aa099548f26d115a
 2021-01-16 00:31:09 +01:00
jenkins-bot 76ae26d51e Merge "Add unit tests for load-first-author method" 2021-01-15 18:02:15 +00:00
jenkins-bot e35ab7c3e7 Merge "Improve coverage of parser-related classes" 2021-01-15 16:45:10 +00:00
Daimona Eaytoy 01b61b5e6a Re-enable AbuseFilterBlockTest::testRevert 
Bug: T272124
Change-Id: Ic8ee8d2ce2b04e5cd0345efdb1e8f9653ef83bf3
 2021-01-15 13:01:19 +01:00
Kosta Harlan 77656948ba tests: Mark testRevert as skipped due to unrelated failure 
Bug: T272124
Change-Id: I99985cbf0a37f0d6c7f30dffa6d34408c0ec72ed
 2021-01-15 09:53:26 +01:00
Translation updater bot ebe626b537 Localisation updates from https://translatewiki.net. 
Change-Id: Ida2768a03bfbd282a258aad1d4fdf1f97bdc8388
 2021-01-15 08:38:11 +01:00
jenkins-bot b12778316a Merge "Improve coverage for hooks" 2021-01-15 03:43:52 +00:00
Daimona Eaytoy a9722868ab Improve coverage of parser-related classes 
Change-Id: I229c528505f0208b34f37d8c969450731e5a08a3
 2021-01-15 03:16:48 +00:00
jenkins-bot 504e807b5f Merge "Misc coverage improvements" 2021-01-15 02:15:42 +00:00
jenkins-bot 7d6d0f9b8a Merge "Improve coverage around consequences" 2021-01-15 02:12:18 +00:00
Daimona Eaytoy 159046fc5a Misc coverage improvements 
Change-Id: I656d9c9eedf4e8b8dfb7a13513d699e5ced22423
 2021-01-15 00:51:16 +00:00
Daimona Eaytoy ab2ad164ff Improve coverage around consequences 
Add a lot more unit tests, improve code testability, remove duplicated
integration tests.

Change-Id: Id8c9266ae107217047f267296070f26f575889d1
 2021-01-15 00:51:04 +00:00
Daimona Eaytoy 66928eda89 Remove deprecated param 
Depends-On: Ie6abd2df5cf1b09c35f0a9e53b0d559e887de09b
Depends-On: Id99b94806095a974a65dd892b2200e59c475802f
Change-Id: I9a33cadb9903461038aa1095be18b68a60dd726d
 2021-01-14 23:43:51 +01:00
Daimona Eaytoy 10c7a11077 Improve coverage for hooks 
- Exclude a couple of classes from coverage reports
- Add tests for all handlers
- Add tests for the runner, copied from core
- Make AbuseFilterRunner a real service

Change-Id: I7a0fe3cd8300faef5ef72d7f986b1734c324d8d1
 2021-01-14 22:49:24 +01:00
jenkins-bot 192fb15e4d Merge "Refactor VariableGenerator and LazyVariableComputer tests" 2021-01-14 21:47:13 +00:00
jenkins-bot 8ff98860d7 Merge "Restore hide link when viewing single AbuseLog entries" 2021-01-14 20:32:10 +00:00
Daimona Eaytoy 8646db7573 Add unit tests for load-first-author method 
This is using core methods, so it can be unit tested. The same isn't
true for load-recent-authors, which performs a custom DB query and whose
test is probably the slowest AbuseFilter test. Simplify it for now,
until the method is moved to MW core.

Change-Id: Ifbdae1a06aabca996eeac151a6d029fd991ad64d
 2021-01-14 17:23:54 +01:00
Translation updater bot 8ac860b851 Localisation updates from https://translatewiki.net. 
Change-Id: Id46230817e4cde558b895ad607a9cc486a3b2a48
 2021-01-14 08:48:59 +01:00
Translation updater bot 9035efc86d Localisation updates from https://translatewiki.net. 
Change-Id: I18f3ed1facef75fa4e00f6f552c7e4efa26a2164
 2021-01-13 08:35:23 +01:00
Daimona Eaytoy bfbdd13c2e Restore hide link when viewing single AbuseLog entries 
Partial revert of I13f476d8126f81b0417e7509784c83d4f21cf348

Bug: T271667
Change-Id: I58f162c7ed72c42b24b214d3857590bfd66e8f82
 2021-01-12 11:56:19 +01:00
Translation updater bot f06f416127 Localisation updates from https://translatewiki.net. 
Change-Id: I063472701a9a1d3b117a327f68b9ae1babd42a74
 2021-01-12 08:36:32 +01:00
Daimona Eaytoy b9efb9ec7d Don't pass protocol-relative URLs to the Ace worker 
Bug: T271487
Change-Id: Ib344e7c021f9224f08c0c844d4e96e5bede356c8
 2021-01-11 13:33:11 +01:00
Translation updater bot a9a8675d81 Localisation updates from https://translatewiki.net. 
Change-Id: I663651e6ddaee98d1955221ddfc7f72ee33abd85
 2021-01-11 08:33:06 +01:00
jenkins-bot bbe2eb6145 Merge "Reorder and cleanup some test files" 2021-01-10 16:13:05 +00:00