Commit graph

6864 commits

Author SHA1 Message Date
jenkins-bot dad1fff238 Merge "Overhaul throttle identifiers" 2022-03-06 13:50:43 +00:00
Daimona Eaytoy a0fd0bae01 Overhaul throttle identifiers
- Use a /64 range for IPv6 instead of /16.
- Fix a curious and serious bug for IPv6, where grouping by range
  would only use the first (!) number of the IP address, due to the
  'v6-' prefix returned by IP::toHex.
- Fail hard if the identifier is unknown -- it's not something that's
  supposed to happen.
- Include the type name in each identifier, instead of prefixing all
  type names to all identifiers. This makes it easier to understand the
  parts of the key.
- Test the whole lot.

Bug: T211101
Change-Id: I54c4209f2f0d5a4c5e7b81bed240ca3e28a2ded7
2022-03-06 13:31:06 +00:00
daniel a512ed31a7 Rename private assertion method
assertStatusMessage is being added to MediaWikiTestCaseTrait, rename
a method of the same name in FilterValidatorTest to avoid conflicts.

Change-Id: I642a3b620ab4d8ad620f7a1253fed98d6796883d
NeededBy: Ic01715b9a55444d3df6b5d4097e78cb8ac082b3e
2022-03-05 21:48:18 +00:00
Daimona Eaytoy 496c2ee370 Add logging when the 'block' action fails
Also avoid using User, use Authority instead.

Bug: T303059
Change-Id: I419ab3726d95ef600e2aa14dca5fa14066d245e3
2022-03-05 19:12:53 +00:00
jenkins-bot a94f71fcac Merge "Change comment for TextExtractor getNativeData to getText" 2022-03-04 09:52:08 +00:00
russ-rogovetz 3505fa63f6 Change comment for TextExtractor getNativeData to getText
Update TextExtractor comment, change Content::getNativeData to TextContent::getText.
Code got already updated.

Bug: T283667
Change-Id: I09e3c537c7e55737d79e69abdd3b7faf693e58cc
2022-03-04 11:01:13 +02:00
Translation updater bot b4df25873a Localisation updates from https://translatewiki.net.
Change-Id: I2ba04d64cd75ad2d08064e8d2c21826ec0c8df3b
2022-03-04 08:28:13 +01:00
Translation updater bot 8b03d1dda7 Localisation updates from https://translatewiki.net.
Change-Id: I42fe536f4323e4c6d3865e98a3240213cb97fdcd
2022-03-03 08:21:46 +01:00
Daimona Eaytoy 900915eeb2 Remove unused messages
Added in [1] which didn't use them.

[1] - https://phabricator.wikimedia.org/rEABFf9c9c07ccf3dcd6fffbb30923411687029259f4d

Change-Id: Iddd777d2dc84fddaee01f9ee9b4002224c386e6e
2022-03-02 16:59:59 +01:00
Translation updater bot bd44a9a87e Localisation updates from https://translatewiki.net.
Change-Id: Iafea9421abe50978696a6ee54821ee7fd0912364
2022-03-01 14:32:04 +01:00
Translation updater bot da8d1f7adf Localisation updates from https://translatewiki.net.
Change-Id: Ifb0cc1559930bc9afa297c518a58fad537316db0
2022-02-28 14:27:40 +01:00
Umherirrender 533e3dc5da Use new namespace for MediaWiki\Revision\RevisionLookup
MediaWiki\Storage is alias since 1.35

Change-Id: I1688cb27847b9154c5133b157ac9c18bd4859a47
2022-02-26 20:39:01 +01:00
jenkins-bot 829009b8d9 Merge "Normalize logged parser error messages" 2022-02-26 16:45:40 +00:00
jenkins-bot b07a7c80fe Merge "Update description of AbuseFilterEmergencyDisableThreshold" 2022-02-26 14:26:15 +00:00
jenkins-bot ac0ed20e4f Merge "Improve debug messages of loading ext. links" 2022-02-26 14:26:13 +00:00
Daimona Eaytoy 2f5a587b1d Normalize logged parser error messages
Change-Id: I31cf73533a46ab5e452c2870fccb8603bb54d3df
2022-02-26 12:57:42 +01:00
Translation updater bot bb3232ca72 Localisation updates from https://translatewiki.net.
Change-Id: I4cfa0feaf5501c4edd1dbfc3a7f2f855a3760676
2022-02-25 09:41:13 +01:00
Translation updater bot a8ff186b08 Localisation updates from https://translatewiki.net.
Change-Id: I3a3442c0d17700de8c3d2fbc878a0373949c824c
2022-02-24 08:47:48 +01:00
Translation updater bot a8352a6624 Localisation updates from https://translatewiki.net.
Change-Id: I4e7ef94ca477b585c1a264438c8fc38acd615c75
2022-02-23 08:18:15 +01:00
Translation updater bot 8994cd0e1f Localisation updates from https://translatewiki.net.
Change-Id: I7b82901e7758a3a6528dbb059a0d500ee2f0d27b
2022-02-22 14:20:03 +01:00
jenkins-bot 203d25f591 Merge "Improve wording for throttled filter warnings" 2022-02-22 11:55:13 +00:00
Daimona Eaytoy b5c22f2b77 Improve wording for throttled filter warnings
List which actions were disabled, or explicitly say that no actions were
disabled if that's the case. Also avoid the word "throttle" in messages
as it may be hard to translate. Also don't suggest optimizations to the
filter conditions -- unoptimized rules have nothing to do with a filter
being throttled.

Bug: T200036
Change-Id: Id989fb185453d068b7685241ee49189a2df67b5f
2022-02-22 11:10:19 +00:00
Translation updater bot 918a19accc Localisation updates from https://translatewiki.net.
Change-Id: Ib9f6f299e149c173c4236232098e59c4102f81d3
2022-02-21 08:14:29 +01:00
Daimona Eaytoy 167f6cb642 Introduce ActionSpecifier
This is a plain value object that represents the action being filtered,
replacing associative arrays that were being used up to this point.

We should now check whether it's possible to make it not require an
accountname (which complicates things), and then use it in related
classes as well, e.g. Parameters.

Change-Id: I9550c14819b600c97c46b632cc1c2d447972d69c
2022-02-18 11:30:56 +00:00
Translation updater bot 422c637091 Localisation updates from https://translatewiki.net.
Change-Id: I683e35b190db76ee065329309cf6b6a7145c5bbc
2022-02-16 08:12:33 +01:00
Translation updater bot 3b0f789103 Localisation updates from https://translatewiki.net.
Change-Id: I1ae00fb5f8ea6a5bc00a0745280820f4bacee8a7
2022-02-15 08:16:40 +01:00
Translation updater bot 3cda62340e Localisation updates from https://translatewiki.net.
Change-Id: I06cfd720c9601b252fa1754943e4da12e5f189fc
2022-02-14 08:13:04 +01:00
Matěj Suchánek 95c0978dc6 Clean up AbuseLogPager
- Make $mConds private and rename it.
- Use the injected permission manager.

Change-Id: Ie92b63da50264226bde5b3b361916bb31fd9448e
2022-02-11 11:21:12 +01:00
jenkins-bot 6b9098eae1 Merge "Replace use of deprecated OutputPage::enableClientCache( false )" 2022-02-10 07:01:54 +00:00
libraryupgrader ae53539a04 build: Updating eslint-config-wikimedia to 0.22.1
Change-Id: I08046d87b818b336fd9c5934c889dcb9f9f9b50c
2022-02-10 03:45:09 +00:00
Translation updater bot bfa72abc91 Localisation updates from https://translatewiki.net.
Change-Id: Idc524246361e11ff5a45757f1bde1d59bc79423a
2022-02-08 08:27:40 +01:00
jenkins-bot 67b740a0cc Merge "Drop non namespaced back compat aliases" 2022-02-08 01:15:17 +00:00
Translation updater bot b7d147eb5b Localisation updates from https://translatewiki.net.
Change-Id: Ie8a468ca01b44a8d0b17e366dc8fe0bc22802bf6
2022-02-07 08:20:54 +01:00
Reedy 62380ccb9a Drop non namespaced back compat aliases
Change-Id: I013959b13e233b6ee577d2b959c2f222687b0c7b
2022-02-06 14:16:10 +00:00
jenkins-bot 59e2bfcaff Merge "Make rmspecials preserve whitespace" 2022-02-06 06:22:38 +00:00
Huji 52827acbab Make rmspecials preserve whitespace
The existing filters on WMF wikis has been changes such that calls
to rmspecials() are now rmspecials(rmwhitespace()) to ensure no change
is made in behaviour. Filter admins can change this back if filter is
not meant to trigger when part of the input is contains spaces.

Bug: T263024
Change-Id: Idde09b50fb8eda357afbedc1199a5483fa8217c1
2022-02-06 06:07:46 +00:00
C. Scott Ananian aecfc7e62e Replace use of deprecated OutputPage::enableClientCache( false )
Replaced with the more readable ::disableClientCache() method, added
in 1.38.  Minimum MW version bumped to match.

Depends-On: I7c89e20528a0d91173f0edcb997dcae631935ee5
Change-Id: I91d0b8e8f69a2d309b6fc61e13bfb5d86dc0218d
2022-02-04 14:29:43 -05:00
Translation updater bot 83e038eace Localisation updates from https://translatewiki.net.
Change-Id: I0cd6ffd6413f5a25a63eea000621297516bfa69a
2022-02-04 08:21:27 +01:00
jenkins-bot 8a4fc79c9d Merge "Declare AbuseFilterView::$mParams as protected" 2022-02-02 13:57:22 +00:00
Matěj Suchánek 238649ebc1 Declare AbuseFilterView::$mParams as protected
It is not supposed to be read or written to by other classes.

Change-Id: I02fe2861a6102ddf1a587cdd7e7423a62d8e0c57
2022-02-02 12:32:09 +01:00
Translation updater bot 4e51cdbe0c Localisation updates from https://translatewiki.net.
Change-Id: Id514da34f78dd93af5081ab1443d9afe8b0997da
2022-02-02 08:19:27 +01:00
libraryupgrader f3de0d1984 build: Updating postcss-less to 3.1.4
* https://github.com/advisories/GHSA-566m-qj78-rww5

Additional changes:
* Set `name` in package.json.

Change-Id: I16a1ffddb8c0460575e7bff9476207c5db0fb213
2022-02-02 04:52:01 +00:00
Translation updater bot a038e19fa6 Localisation updates from https://translatewiki.net.
Change-Id: Icee51d6057198a54de5f916f467da796eb7142ac
2022-02-01 08:26:31 +01:00
libraryupgrader f29cea6791 build: Updating npm dependencies
* wdio-mediawiki: 1.1.1 → 1.2.0
* mocha: 9.1.2 → 9.2.0
  * https://github.com/advisories/GHSA-qrpm-p2h7-hrv2
* nanoid: 3.1.25 → 3.2.0
  * https://github.com/advisories/GHSA-qrpm-p2h7-hrv2
* node-fetch: 2.6.1 → 2.6.7
  * https://github.com/advisories/GHSA-r683-j2x4-v87g
* postcss-less: 3.1.4 → 3.1.4
  * https://github.com/advisories/GHSA-566m-qj78-rww5

Change-Id: Ifce1b2630907e646861b125f85fe2c99ba63d956
2022-02-01 05:08:00 +00:00
Translation updater bot a55c0e51ed Localisation updates from https://translatewiki.net.
Change-Id: I6ee48670f440fd18fbfac05e1782e6c9e761939c
2022-01-28 08:33:09 +01:00
Translation updater bot f8708e8477 Localisation updates from https://translatewiki.net.
Change-Id: I983aab411c9ebfa0ce7a85039a72ae1c8c671d3f
2022-01-27 08:38:05 +01:00
jenkins-bot 68b8092e53 Merge "Don't implode and explode links" 2022-01-27 01:06:45 +00:00
Translation updater bot 2bdedb0fdd Localisation updates from https://translatewiki.net.
Change-Id: I2fcf4d5b624bef712e5892602b905c47cd03939e
2022-01-26 08:24:16 +01:00
Matěj Suchánek 2694751355 Don't implode and explode links
old_links and all_links are an array. Casting
them to string and then splitting by newlines
is a no-op.

Change-Id: I05c69f14e981ac2842032e7db888f4841d6b48b7
2022-01-24 12:58:56 +00:00
Matěj Suchánek 9ed8fa7f3c Update description of AbuseFilterEmergencyDisableThreshold
The emergency disable feature does not depend on profiling
data anymore since b8ac52c.

Change-Id: Ibf3282f13c23e6b3d95cfd156132253d56afb28a
2022-01-24 13:36:24 +01:00