wikimedia/mediawiki-extensions-AbuseFilter
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/AbuseFilter.git synced 2024-11-24 06:03:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix undeclared variable

Browse source 
The variable was declared in the "if" branch but also used in the "else"
one. This caused the rules textarea to not have the readonly attribute
if the user wasn't allowed and CodeEditor wasn't installed.

Change-Id: I2bf69dc0f2d24efac41d1ac6100ed7e286e3afa4
This commit is contained in:
Daimona Eaytoy 2018-04-30 15:55:10 +02:00
parent b18e763c7e
commit 99f32a1408
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Views/AbuseFilterView.php
View file

@ -90,6 +90,7 @@ abstract class AbuseFilterView extends ContextSource {
}
$rules = rtrim( $rules ) . "\n";
$canEdit = $this->canEdit();
if ( ExtensionRegistry::getInstance()->isLoaded( 'CodeEditor' ) ) {
$editorAttrib['name'] = 'wpAceFilterEditor';
@ -115,7 +116,6 @@ abstract class AbuseFilterView extends ContextSource {
}
$rulesContainer .= Xml::textarea( $textName, $rules, 40, 15, $textareaAttribs );
$canEdit = $this->canEdit();
$editorConfig = AbuseFilter::getAceConfig( $canEdit );
// Add Ace configuration variable