idradm
3e586523e4
XW-2278 fix wikitext lists after variables were replaced
2016-11-14 11:24:44 +01:00
Weronika Rudnicka
ee7404ef6b
XW-2234 | added srcset to infobox image, to display better quality images for retina
2016-11-03 14:27:43 +01:00
grunny
8186618eb9
(DAT-4494) Fix galleries and tabber in PortableInfoboxes
2016-06-16 16:59:48 +00:00
Warkot
10f96eaa96
XW-1478 | extendImageData has to be run even for the first PI
2016-05-31 00:20:39 +02:00
Warkot
1fa29ea03b
XW-1478 | don't render the whole hero module including the title on Mercury
2016-05-30 21:30:25 +02:00
Warkot
908327db5d
XW-1478 | don't render hero image in first infobox on Mercury
2016-05-30 18:35:11 +02:00
Igor Rogatty
27e695e569
XW-1225 | remove $wgEnableSeoFriendlyImagesForMobile and clean up
2016-05-18 14:44:36 +02:00
idradm
9ceba1d2d0
DAT-3942 make sure isVideo param is always set, update tests
2016-04-20 10:38:44 +02:00
Bogna Knychala
1dc864dd5a
Merge remote-tracking branch 'origin/dev' into XW-1300
2016-04-08 13:13:17 +02:00
Daniel Grunwell
e8c9a1611a
Merge pull request #10117 from Wikia/CE-3554
...
CE-3554: Improve infobox input fields labels in VE dialog
2016-04-08 17:40:54 +10:00
Igor Rogatty
498aa90f26
Merge branches 'XW-1300' and 'dev' of https://github.com/Wikia/app into XW-1300
2016-04-06 12:30:54 +02:00
Igor Rogatty
455e4b5e75
XW-1300 | support for image collections
2016-04-05 17:42:21 +02:00
Lukasz Konieczny
9f7c54012b
CE-3554: Combine two lines to one
2016-04-05 09:58:19 +00:00
Lukasz Konieczny
d340841e17
CE-3554: Improve code after CR
2016-04-05 07:27:18 +00:00
Igor Rogatty
3bc774edaa
XW-1300 | use global properly
2016-04-04 17:09:08 +02:00
Igor Rogatty
17a045e1aa
XW-1300 | add tests for Mercury experimental markup
2016-04-04 15:50:36 +02:00
Igor Rogatty
065bf53428
XW-1300 | add hero-mobile-wikiamobile to sanitizer builder
2016-04-04 13:49:48 +02:00
Igor Rogatty
55c6cf6c11
XW-1300 | use isMercury helper method
2016-04-04 13:13:52 +02:00
Igor Rogatty
4c150d9885
XW-1300 | support for WikiaMobile
2016-04-01 17:33:29 +02:00
idradm
dc868173b3
DAT-4041 fix regex to much only empty infobox tags
2016-04-01 16:54:04 +02:00
idradm
c15314dd7b
DAT-4041 empty portable infobox will be supported
2016-04-01 16:43:41 +02:00
Lukasz Konieczny
06fad58042
CE-3554: Support more sources
2016-04-01 12:54:43 +00:00
Lukasz Konieczny
4f11b96e48
CE-3554: Changes after CR
2016-04-01 11:07:30 +00:00
Igor Rogatty
52f6c9b389
XW-1300 | remove accidental var_dump
2016-04-01 12:29:36 +02:00
Igor Rogatty
07cdefb0f5
XW-1300 | use mercury-component-attrs name and fix unit tests
2016-04-01 12:06:10 +02:00
Igor Rogatty
d5587fbc25
XW-1300 | use new media components in portable infoboxes
2016-03-31 18:08:57 +02:00
Lukasz Konieczny
a773ee1a49
CE-3554: Extract labels from infobox markup and save them in page props
2016-03-31 09:58:34 +00:00
idradm
508635c08f
DAT-4018 make europa theme solely var dependent
2016-03-29 12:31:03 +02:00
Rafal Leszczynski
677b272351
add pi-europa class to infobox if europa is enabled
2016-03-29 12:12:11 +02:00
idradm
8dd35e8146
DAT-3934 remove comment
2016-03-17 12:13:17 +01:00
idradm
cbc0a10a78
DAT-3934 add tests for custom width
2016-03-17 12:12:36 +01:00
idradm
af041c9196
DAT-3934 provide a way to decide on image size while infobox rendering
2016-03-17 10:37:18 +01:00
idradm
a1e34471c2
DAT-3934 set image width to 100%
2016-03-16 10:09:54 +01:00
idradm
60d87fc123
DAT-3934 make image bigger and adjusted by css
2016-03-16 09:50:01 +01:00
Rafal Leszczynski
604e9da6df
DAT-3937, remove special case for europa thumbnail width
2016-03-14 10:36:08 +01:00
Rafal Leszczynski
5c75f627a2
DAT-3937, set different image width for europa theme only
2016-03-14 08:57:58 +01:00
Rafal Leszczynski
7a12be6310
DAT-3855, round image display dimensions
2016-03-09 10:45:31 +01:00
Rafal Leszczynski
6e8866bf03
DAT-3855, add comment about changing image thumbnail width
2016-03-09 10:23:55 +01:00
Rafal Leszczynski
971a012f8c
DAT-3855, increase default image thumbnail width to match europa default infobox width
2016-03-08 15:27:46 +01:00
Mateusz Rybarski
5637f4d6ed
fetching infobox markup, checking if there is only one infobox
2016-02-16 13:37:48 +01:00
Bogna Knychala
402d4e3c8c
XW-41 add template to experimental image collection
2016-02-15 18:44:02 +01:00
Bogna Knychala
ba822f6176
XW-41 add comment to method and fix the log message format
2016-02-15 15:48:42 +01:00
Bogna Knychala
46683ca8e4
XW-41 fix xpath to media in hero image in infobox
2016-02-12 18:20:14 +01:00
Bogna Knychala
c6aa0fb787
XW-41 handle experimental content
2016-02-12 17:13:48 +01:00
Warkot
3026d6ce41
Merge remote-tracking branch 'origin/dev' into XW-41
2016-02-08 18:39:59 +01:00
Tomasz Napieralski
2e5f90f543
hide changes after flag
2016-02-08 15:57:57 +01:00
Tomasz Napieralski
1b2a5bb417
use SEO friendly images for mobile in infoboxes
2016-02-05 18:02:02 +01:00
Sebastian Marzjan
c5d17f315e
DAT-3624 Rename 'Infobo' to 'Infobox'
2016-02-03 12:06:44 +01:00
Rafal Leszczynski
6a40c864e6
Merge branch 'dev' into DAT-3613
2016-01-12 13:40:32 +01:00
dianafa
6406fb53d5
move helper to an independent place
2016-01-12 10:50:24 +01:00
dianafa
ebfb01d73d
use createDOMDocumentFromText helper
2016-01-12 10:08:37 +01:00
Sebastian Marzjan
168bf09348
DAT-3621 Unified tests for hero image and regular caption
...
* Disable sanitization on Oasis
* Handle previously unsupported case of nested tag ( <b><a></a></b> )
* Unify test formatting
* Change list handling (yes, I am not proud of that)
2016-01-12 09:21:21 +01:00
dianafa
96192e1fc2
silence libxml errro
2016-01-11 18:01:04 +01:00
Sebastian Marzjan
531fc700e6
Provide explicitly encoded XML to loadHTML (libxml issues ;-) )
2016-01-08 08:24:09 +01:00
Sebastian Marzjan
2171b5c02c
Merge pull request #9366 from Wikia/DAT-3331
...
make infoboxes use params same way as mediawiki, enable 0 param
2016-01-05 17:18:33 +01:00
Sebastian Marzjan
72392d0edd
Normalize whitespace when processing infobox contents
2016-01-05 09:05:50 +01:00
idradm
5f42ce9742
make infoboxes use params same way as mediawiki, enable 0 param
2016-01-04 14:34:10 +01:00
marzjan
a5ad283fca
Further code reorg
2016-01-04 12:09:39 +00:00
marzjan
7dfc5a828f
Small code reorganization and cleanup
2016-01-04 11:09:50 +00:00
Sebastian Marzjan
2fdebcdffb
DAT-3465 Change approach to sanitization; use XML parsing
2015-12-30 11:00:10 +01:00
Sebastian Marzjan
a0569a829b
Move the implements statement to base Sanitizer class
2015-12-29 08:13:02 +01:00
Sebastian Marzjan
0ce0b500fe
Use the Builder for Sanitizers.
...
Cover the sanitizer build step in tests too
2015-12-28 12:04:36 +01:00
Sebastian Marzjan
8f437fb1e7
DAT-3465 Update the caption behavior
2015-12-28 10:21:32 +01:00
dianafa
8afcb73d10
move sanitizers to a separate folder
2015-12-23 15:54:03 +01:00
dianafa
ed73d4f525
move sanitizing to PortableInfoboxRenderService
2015-12-23 13:20:55 +01:00
dianafa
0de509246f
add caption sanitization in getImageData
2015-12-23 11:20:39 +01:00
Rafal Leszczynski
432341a974
DAT-3576, fix edge case with broken aspect ratio for tall thin images if portable infobox custom image width is set
2015-12-11 16:05:10 -08:00
Sebastian Marzjan
f1896da8ab
Add tests
2015-12-11 10:01:23 -08:00
dianafa
f8312c6484
add getImageSizesToDisplay description
2015-12-11 12:06:44 +01:00
dianafa
33af8b75e9
rename getAdjustedImageSize to getImageSizesForThumbnailer
2015-12-11 12:02:00 +01:00
dianafa
cc54d4478d
move logic to other place & add tests
2015-12-11 11:56:41 +01:00
Rafal Leszczynski
02a2c62332
DAT-3576, allow for overwrite thumbnail physical dimensions in portable infobox via wikifactory variable
2015-12-10 16:41:07 -08:00
Inez Korczynski
52f7f4e083
VE-2069: By default use "===" comparison in PHP (instead of "==")
2015-12-07 22:37:56 +00:00
Inez Korczynski
53f762bfec
VE-2069: Small code refactoring to avoid multiple nesting inside one method
2015-12-07 22:36:56 +00:00
Inez Korczynski
19fc47e23e
VE-2069: Adjust getImages method to work well with recent changes to ImageNode
...
I'm not very happy with how nested this method is but it seems that it is the convention taken within PortableInfobox project.
I would much better prefer if there was more object oriented way to delegate for instance task of retrieving images list directly to NodeImage but that would be much greater refactoring.
2015-12-07 22:05:45 +00:00
adamkarminski
7ba8f0e658
CE-3014 Remove the deprecated PortableInfoboxClassification class
2015-12-03 10:42:21 +01:00
Inez Korczyński
cb48a06b79
Merge pull request #9145 from Wikia/VE-2049
...
VE-2049: Emergency Broadcast System
2015-11-25 12:08:11 -08:00
dianafa
6e8091ec4d
move ImageFilenameSanitizer logic to FileNamespaceSanitizeHelper
2015-11-25 11:00:39 +01:00
dianafa
23bb4be49d
check file prefix by contentLang
2015-11-24 23:35:23 +01:00
Inez Korczynski
98cdff0851
VE-2064: There is no need to "alias" that variable
2015-11-23 19:55:03 +00:00
Paul Oslund
6e54a6d3a2
VE-2064: Extract method to load non-portable infoxes
2015-11-20 20:10:03 +00:00
Diana
15a00b4d4e
sanitize horizontal group items as well
2015-11-05 17:57:53 +00:00
Diana
49feb54689
change method name to sanitizeInfoboxFields and refactor
2015-11-05 13:21:20 +00:00
dianafa
649895d4cf
change variable names and add missing PHPdocs
2015-11-03 17:19:29 +01:00
dianafa
2214b5c81f
add logging each striping to Kibana
2015-11-03 16:58:25 +01:00
dianafa
653a64942d
change function invocation in RenderService
2015-11-03 16:13:45 +01:00
dianafa
3f2d287e8a
do not strip links
2015-11-03 16:12:44 +01:00
dianafa
2a0c5ef3d0
sanitize labels as well
2015-11-03 14:45:27 +01:00
Inez Korczyński
6b78b8a3ae
Merge pull request #8943 from Wikia/PI-Collapsible-Groups
...
Collapsible Groups for Portable Infoboxes
2015-10-30 10:46:00 -07:00
Nikodem Hynek
ef9c31ccc0
Merge pull request #8899 from Wikia/DAT-3402
...
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-28 10:58:52 +01:00
Inez Korczynski
f901a1642e
VE-2004: Silencing loadHTML warning
...
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.
Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
2015-10-27 20:02:58 +00:00
idradm
c73cfab57b
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-27 14:09:42 +01:00
Inez Korczynski
3d05ec1758
VE-1994: Add appropriately pi-collapse and pi-collapse-[open|closed] CSS classes to PI groups wrappers
2015-10-26 21:59:34 +00:00
Inez Korczynski
2424103f76
VE-2000: Modify regex to match all markers (hexadecimal instead of decimal only)
2015-10-23 21:24:26 +00:00
Inez Korczynski
d280c32dfc
VE-1990: Added support for video in PIMC
2015-10-22 20:56:32 +00:00
Paul Oslund
9c32432469
Merge pull request #8844 from Wikia/VE-1985
...
VE-1985: Added support for video passed to tabber
2015-10-22 12:26:19 -06:00
Inez Korczyński
9733548c0d
Merge pull request #8840 from Wikia/VE-1961
...
VE 1961: Render image collection tabs in infobox
2015-10-22 11:23:43 -07:00
Paul Oslund
f9055fe97c
VE-1961: Handle multiple image collections in infobox
2015-10-21 02:55:23 +00:00
Inez Korczynski
b2e7b644f4
VE-1985: Added support for video passed to tabber
2015-10-21 00:48:37 +00:00
Inez Korczynski
394db2a0ba
Merge branch 'PI-Media-Collections-MVP' into VE-1982
2015-10-21 00:38:23 +00:00
Inez Korczynski
ec856513e8
VE-1982: Removed not needed global
2015-10-21 00:04:29 +00:00
Inez Korczynski
720900abb5
VE-1982: Added missing global
2015-10-21 00:03:06 +00:00
Paul Oslund
d097426242
VE-1960: Template for mobile image collections
2015-10-20 23:09:23 +00:00
Inez Korczynski
8fc355ecea
VE-1982: Basic unit test coverage for backward compatibility added to <image>
2015-10-20 22:42:36 +00:00
Inez Korczynski
c9da5425a7
VE-1979: Added support for <gallery> tag passed to <image>
2015-10-20 01:19:49 +00:00
Inez Korczynski
6c4359a9d4
VE-1975: Added support for mobile (ArticleAsJson) and usage of XML parsing
...
Special handling for mobile is needed because article for mobile is delivered within ArticleAsJson which makes a lot of transformation during the parsing process (instead of for instance postprocessing).
Parsing HTML with XML parser seems to be giving better results than using just regexes and also it gives as ability to handle nested tabbers in a future in a better way.
2015-10-19 23:56:20 +00:00
Inez Korczynski
a692e008b3
VE-1975: Modified NodeImage to return array of images instead of one image
...
Added support for <tabber>
Hero image still works correct
2015-10-16 01:15:52 +00:00
Diana Falkowska
dfe25a33df
remove newline
2015-10-07 15:12:56 +02:00
Diana
00360174b5
add context to proper field
2015-10-07 09:42:38 +00:00
Nikodem
97623fe9a5
Merge pull request #8614 from Wikia/DAT-3294
...
DAT-3294 add infobox-hero-image context handling
2015-09-30 12:45:48 +02:00
dianafa
33414c3dbb
change hook name and move context to PIRenderService
2015-09-30 10:10:31 +02:00
Diana
ff16c2346f
change order
2015-09-28 16:42:27 +00:00
dianafa
4536458992
move hook to render service
2015-09-28 17:46:40 +02:00
idradm
13d398bced
DAT-3199 purge cache after change is done
2015-09-25 17:19:48 +02:00
idradm
d95c9310fc
DAT-3199 remove clear state caching
2015-09-25 17:06:09 +02:00
idradm
12120f3cf1
DAT-3199 change memc key to be more distinguishable, add type hinting
2015-09-24 17:17:47 +02:00
idradm
094cd426ae
DAT-3199 switch to WikiaDataAccess
2015-09-24 16:25:27 +02:00
idradm
88c886bf09
DAT-3199 add tests for template parsing
2015-09-24 13:48:51 +02:00
idradm
bcef561785
DAT-3199 remove debug method
2015-09-23 16:00:07 +02:00
idradm
dbef0b9915
DAT-3199 unit tests fixed
2015-09-23 15:51:41 +02:00
idradm
859a0ee81b
DAT-3199 use page_props directly instead of through parserOutput, add memcache layer for infoboxes data provider service, introduce hook on backlinks purge
2015-09-22 17:48:38 +02:00
Nikodem
ce6aa2431f
Merge pull request #8398 from Wikia/DAT-3073
...
DAT-3073 set max height for infobox images on desktop
2015-09-10 11:42:33 +02:00
Nikodem
9767ef0d50
Merge pull request #8366 from Wikia/DAT-3194
...
Dat 3194 - for videos in infobox use link to file page instead of link to original image
2015-09-09 17:24:39 +02:00
Diana
222a3c00a8
typo
2015-09-09 16:00:59 +02:00
Diana
4a01b3ed1d
fix IDE formatting
2015-09-09 16:00:19 +02:00
dianafa
0c8e2545a9
addd tests
2015-09-09 14:54:26 +02:00
Diana
273b53fafd
remmove newline
2015-09-09 13:49:16 +02:00
Rafal Leszczynski
a027e8a2c9
get title from file
2015-09-09 13:23:34 +02:00
dianafa
e10ab9b7ee
change height only for desktop images
2015-09-09 10:16:00 +02:00
dianafa
34bd1c729e
restore formatting
2015-09-09 10:01:24 +02:00
Sebastian Marzjan
351d0f94e5
DAT-3200 Adding support for urlencoded image names in infoboxes
2015-09-08 14:12:23 -07:00
dianafa
b896faa147
add max height to infobox images
2015-09-08 16:29:41 +02:00
Nikodem
f025c91d2d
Merge pull request #8368 from Wikia/DAT-3102
...
DAT-3102 avoid double HTML escaping and do it only in mustache template
2015-09-08 15:15:16 +02:00
Nikodem
95d6bc152b
Merge pull request #8370 from Wikia/DAT-3127
...
DAT-3127 treat 0 as valid value inside <format> tag
2015-09-08 15:07:24 +02:00
Rafal Leszczynski
bb7421acb7
treat 0 as valid value inside <format> tag
2015-09-08 11:29:49 +02:00
Rafal Leszczynski
6ecfe30e73
avoid double HTML escaping and do it only in mustache template
2015-09-08 10:32:36 +02:00
idradm
97c8de1842
DAT-3207 add mw namespaces aliases to image filename sanitizer
2015-09-08 10:25:10 +02:00
Rafal Leszczynski
d9db65a08f
use filepage url instead of image url for videos inside portable infobox
2015-09-07 17:38:17 +02:00
Nikodem
e0739c6942
Merge pull request #8351 from Wikia/DAT-3210
...
DAT-3210 make caption field show the caption not the alt
2015-09-07 16:07:46 +02:00
Nikodem
5d68ec75c8
Merge pull request #8348 from Wikia/DAT-3197
...
DAT-3197 wrap content tags contents in CDATA before parsing
2015-09-07 14:47:33 +02:00
Diana
625fdf9f7c
make caption field show the caption not the alt
2015-09-07 11:42:47 +00:00
Rafal Leszczynski
280a9aa50b
skip rendering labels if all labels in horizontal group are empty strings
2015-09-07 13:17:03 +02:00
idradm
2aa83e9e57
DAT-3197 wrap content tags contents in CDATA before parsing
2015-09-07 12:22:56 +02:00
Rafal Leszczynski
96129feb6b
add support for horizontal group in mercury
2015-09-04 17:30:54 +02:00
Rafal Leszczynski
3a1eed4a25
Revert "add support for horizontal group on mercury"
...
This reverts commit 720be436cab4d8a7492913f1b5efd8cd481f4fcf.
2015-09-04 17:29:59 +02:00
Rafal Leszczynski
ab579bb0a8
add support for horizontal group on mercury
2015-09-04 17:26:18 +02:00
Sebastian Marzjan
b699619caf
DAT-3105 Fix saving invalid titles to imagelinks table in PortableInfoboxes
...
* Use Title::makeTitleSafe instead of Title::newFromTitle
* Add image only if title is valid
2015-08-31 13:53:06 +02:00
idradm
1dd65e803c
DAT-3147 change formatting
2015-08-27 10:47:43 +02:00
idradm
af0d7821a4
DAT-3147 make render service use getTemplates method
2015-08-27 10:46:38 +02:00
idradm
9b020ee4fb
DAT-3147 assets entry point added
2015-08-27 10:30:25 +02:00