Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-15 11:59:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

DAT-3199 add tests for template parsing

Browse source
This commit is contained in:
idradm 2015-09-24 13:48:51 +02:00
parent 357efeee9c
commit 88c886bf09
2 changed files with 77 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
services/Helpers/PortableInfoboxTemplatesHelper.php
View file

@ -20,8 +20,7 @@ class PortableInfoboxTemplatesHelper {
*/
public function parseInfoboxes( $title ) {
// for templates we need to check for include tags
$article = \Article::newFromTitle( $title, \RequestContext::getMain() );
$templateText = $article->fetchContent();
$templateText = $this->fetchContent( $title );
$includeonlyText = $this->getIncludeonlyText( $templateText );
if ( $includeonlyText ) {
@ -29,7 +28,7 @@ class PortableInfoboxTemplatesHelper {
$parserOptions = new \ParserOptions();
$frame = $parser->getPreprocessor()->newFrame();
$templateTextWithoutIncludeonly = $parser->getPreloadText( $includeonlyText, $article->getTitle(), $parserOptions );
$templateTextWithoutIncludeonly = $parser->getPreloadText( $includeonlyText, $title, $parserOptions );
$infoboxes = $this->getInfoboxes( $templateTextWithoutIncludeonly );
if ( $infoboxes ) {
@ -51,37 +50,19 @@ class PortableInfoboxTemplatesHelper {
}
/**
* @desc From the template without <includeonly> tags, creates an array of
* strings containing only infoboxes. All template content which is not an infobox is removed.
*
* @param $text string Content of template which uses the <includeonly> tags
*
* @return array of striped infoboxes ready to parse
*/
protected function getInfoboxes( $text ) {
preg_match_all( "/<infobox.+<\/infobox>/sU", $text, $result );
return $result[ 0 ];
}
/**
* @desc returns the text from inside of the first <includeonly> tag and
* without the nowiki and pre tags.
*
* @param $text string template text
* @param $title \Title
*
* @return string
*/
protected function getIncludeonlyText( $text ) {
preg_match_all( "/<includeonly>(.+)<\/includeonly>/sU", $text, $result );
if ( !isset( $result[ 1 ][ 0 ] ) ) {
return null;
protected function fetchContent( $title ) {
if ( $title && $title->exists() ) {
$article = \Article::newFromTitle( $title, \RequestContext::getMain() );
if ( $article && $article->exists() ) {
$content = $article->fetchContent();
}
}
$result = $this->removeNowikiPre( $result[ 1 ][ 0 ] );
return $result;
return isset( $content ) && $content ? $content : '';
}
/**
@ -97,4 +78,37 @@ class PortableInfoboxTemplatesHelper {
return $text;
}
/**
* @desc returns the text from inside of the first <includeonly> tag and
* without the nowiki and pre tags.
*
* @param $text string template text
*
* @return string
*/
protected function getIncludeonlyText( $text ) {
$clean = $this->removeNowikiPre( $text );
preg_match_all( "/<includeonly>(.+)<\/includeonly>/sU", $clean, $result );
if ( !isset( $result[ 1 ][ 0 ] ) ) {
return null;
}
return $result[ 1 ][ 0 ];
}
/**
* @desc From the template without <includeonly> tags, creates an array of
* strings containing only infoboxes. All template content which is not an infobox is removed.
*
* @param $text string Content of template which uses the <includeonly> tags
*
* @return array of striped infoboxes ready to parse
*/
protected function getInfoboxes( $text ) {
preg_match_all( "/<infobox.+<\/infobox>/sU", $text, $result );
return $result[ 0 ];
}
}

34
tests/PortableInfoboxTemplatesHelperTest.php Normal file
View file

@ -0,0 +1,34 @@
<?php
class PortableInfoboxTemplatesHelperTest extends WikiaBaseTest {
protected function setUp() {
$this->setupFile = dirname( __FILE__ ) . '/../PortableInfobox.setup.php';
parent::setUp();
}
/**
* @dataProvider testsProvider
*/
public function testInfoboxParsing( $markup, $expected ) {
$helper = $this->getMockBuilder( 'Wikia\PortableInfobox\Helpers\PortableInfoboxTemplatesHelper' )
->setMethods( [ 'fetchContent' ] )->getMock();
$helper->expects( $this->once() )->method( 'fetchContent' )->will( $this->returnValue( $markup ) );
$result = $helper->parseInfoboxes( new Title() );
$this->assertEquals( $expected, $result );
}
public function testsProvider() {
return [
[ 'test', false ],
[ '<includeonly><infobox><data source="test"><label>1</label></data></infobox></includeonly>',
[ [ 'data' => [ ], 'sources' => [ 'test' ] ] ] ],
[ '<includeonly></includeonly><infobox></infobox>', false ],
[ '<includeonly><infobox></infobox></includeonly> ', [ [ 'data' => [ ], 'sources' => [ ] ] ] ],
[ '<nowiki><includeonly><infobox></infobox></includeonly></nowiki>', false ],
[ '<includeonly><nowiki><infobox></infobox></nowiki></includeonly>', false ],
];
}
}