Commit graph

335 commits

Author SHA1 Message Date
dianafa 33af8b75e9 rename getAdjustedImageSize to getImageSizesForThumbnailer 2015-12-11 12:02:00 +01:00
dianafa cc54d4478d move logic to other place & add tests 2015-12-11 11:56:41 +01:00
Rafal Leszczynski 02a2c62332 DAT-3576, allow for overwrite thumbnail physical dimensions in portable infobox via wikifactory variable 2015-12-10 16:41:07 -08:00
Inez Korczynski 52f7f4e083 VE-2069: By default use "===" comparison in PHP (instead of "==") 2015-12-07 22:37:56 +00:00
Inez Korczynski 53f762bfec VE-2069: Small code refactoring to avoid multiple nesting inside one method 2015-12-07 22:36:56 +00:00
Inez Korczynski 19fc47e23e VE-2069: Adjust getImages method to work well with recent changes to ImageNode
I'm not very happy with how nested this method is but it seems that it is the convention taken within PortableInfobox project.
I would much better prefer if there was more object oriented way to delegate for instance task of retrieving images list directly to NodeImage but that would be much greater refactoring.
2015-12-07 22:05:45 +00:00
adamkarminski 7ba8f0e658 CE-3014 Remove the deprecated PortableInfoboxClassification class 2015-12-03 10:42:21 +01:00
Inez Korczyński cb48a06b79 Merge pull request #9145 from Wikia/VE-2049
VE-2049: Emergency Broadcast System
2015-11-25 12:08:11 -08:00
dianafa 6e8091ec4d move ImageFilenameSanitizer logic to FileNamespaceSanitizeHelper 2015-11-25 11:00:39 +01:00
dianafa 23bb4be49d check file prefix by contentLang 2015-11-24 23:35:23 +01:00
Inez Korczynski 98cdff0851 VE-2064: There is no need to "alias" that variable 2015-11-23 19:55:03 +00:00
Paul Oslund 6e54a6d3a2 VE-2064: Extract method to load non-portable infoxes 2015-11-20 20:10:03 +00:00
Diana 15a00b4d4e sanitize horizontal group items as well 2015-11-05 17:57:53 +00:00
Diana 49feb54689 change method name to sanitizeInfoboxFields and refactor 2015-11-05 13:21:20 +00:00
dianafa 649895d4cf change variable names and add missing PHPdocs 2015-11-03 17:19:29 +01:00
dianafa 2214b5c81f add logging each striping to Kibana 2015-11-03 16:58:25 +01:00
dianafa 653a64942d change function invocation in RenderService 2015-11-03 16:13:45 +01:00
dianafa 3f2d287e8a do not strip links 2015-11-03 16:12:44 +01:00
dianafa 2a0c5ef3d0 sanitize labels as well 2015-11-03 14:45:27 +01:00
Inez Korczyński 6b78b8a3ae Merge pull request #8943 from Wikia/PI-Collapsible-Groups
Collapsible Groups for Portable Infoboxes
2015-10-30 10:46:00 -07:00
Nikodem Hynek ef9c31ccc0 Merge pull request #8899 from Wikia/DAT-3402
DAT-3402 move links placeholder replacement after markers are resolved
2015-10-28 10:58:52 +01:00
Inez Korczynski f901a1642e VE-2004: Silencing loadHTML warning
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.

Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
2015-10-27 20:02:58 +00:00
idradm c73cfab57b DAT-3402 move links placeholder replacement after markers are resolved 2015-10-27 14:09:42 +01:00
Inez Korczynski 3d05ec1758 VE-1994: Add appropriately pi-collapse and pi-collapse-[open|closed] CSS classes to PI groups wrappers 2015-10-26 21:59:34 +00:00
Inez Korczynski 2424103f76 VE-2000: Modify regex to match all markers (hexadecimal instead of decimal only) 2015-10-23 21:24:26 +00:00
Inez Korczynski d280c32dfc VE-1990: Added support for video in PIMC 2015-10-22 20:56:32 +00:00
Paul Oslund 9c32432469 Merge pull request #8844 from Wikia/VE-1985
VE-1985: Added support for video passed to tabber
2015-10-22 12:26:19 -06:00
Inez Korczyński 9733548c0d Merge pull request #8840 from Wikia/VE-1961
VE 1961: Render image collection tabs in infobox
2015-10-22 11:23:43 -07:00
Paul Oslund f9055fe97c VE-1961: Handle multiple image collections in infobox 2015-10-21 02:55:23 +00:00
Inez Korczynski b2e7b644f4 VE-1985: Added support for video passed to tabber 2015-10-21 00:48:37 +00:00
Inez Korczynski 394db2a0ba Merge branch 'PI-Media-Collections-MVP' into VE-1982 2015-10-21 00:38:23 +00:00
Inez Korczynski ec856513e8 VE-1982: Removed not needed global 2015-10-21 00:04:29 +00:00
Inez Korczynski 720900abb5 VE-1982: Added missing global 2015-10-21 00:03:06 +00:00
Paul Oslund d097426242 VE-1960: Template for mobile image collections 2015-10-20 23:09:23 +00:00
Inez Korczynski 8fc355ecea VE-1982: Basic unit test coverage for backward compatibility added to <image> 2015-10-20 22:42:36 +00:00
Inez Korczynski c9da5425a7 VE-1979: Added support for <gallery> tag passed to <image> 2015-10-20 01:19:49 +00:00
Inez Korczynski 6c4359a9d4 VE-1975: Added support for mobile (ArticleAsJson) and usage of XML parsing
Special handling for mobile is needed because article for mobile is delivered within ArticleAsJson which makes a lot of transformation during the parsing process (instead of for instance postprocessing).
Parsing HTML with XML parser seems to be giving better results than using just regexes and also it gives as ability to handle nested tabbers in a future in a better way.
2015-10-19 23:56:20 +00:00
Inez Korczynski a692e008b3 VE-1975: Modified NodeImage to return array of images instead of one image
Added support for <tabber>
Hero image still works correct
2015-10-16 01:15:52 +00:00
Diana Falkowska dfe25a33df remove newline 2015-10-07 15:12:56 +02:00
Diana 00360174b5 add context to proper field 2015-10-07 09:42:38 +00:00
Nikodem 97623fe9a5 Merge pull request #8614 from Wikia/DAT-3294
DAT-3294 add infobox-hero-image context handling
2015-09-30 12:45:48 +02:00
dianafa 33414c3dbb change hook name and move context to PIRenderService 2015-09-30 10:10:31 +02:00
Diana ff16c2346f change order 2015-09-28 16:42:27 +00:00
dianafa 4536458992 move hook to render service 2015-09-28 17:46:40 +02:00
idradm 13d398bced DAT-3199 purge cache after change is done 2015-09-25 17:19:48 +02:00
idradm d95c9310fc DAT-3199 remove clear state caching 2015-09-25 17:06:09 +02:00
idradm 12120f3cf1 DAT-3199 change memc key to be more distinguishable, add type hinting 2015-09-24 17:17:47 +02:00
idradm 094cd426ae DAT-3199 switch to WikiaDataAccess 2015-09-24 16:25:27 +02:00
idradm 88c886bf09 DAT-3199 add tests for template parsing 2015-09-24 13:48:51 +02:00
idradm bcef561785 DAT-3199 remove debug method 2015-09-23 16:00:07 +02:00