Commit graph

52 commits

Author SHA1 Message Date
Igor Rogatty e0394adb61 XW-2277 | replace image links in PI on Monobook with File page URLs 2016-11-03 14:44:29 +01:00
grunny c006c42035 (CE-3844) Refactor fix for PI and parser tag fix
A security fix from MW core added quotes to the Parser's strip tag
markers in order to prevent an XSS vulnerability. When this was deployed
PIs and our Wikia tag extensions broke in Mercury because ArticlesAsJson
JSON encodes the parser output in the ParserAfterTidy, but then PI and
the tag extensions were manually replacing the Parser tag strip markers
on the already JSON encoded string within their own ParserAfterTidy methods
(which were always run after the ArticlesAsJson method). This meant that the
strip marker had the quote escaped with a backslash in the encoded string,
so the string replacements failed.

This change follows the previous quick and dirty fix by moving the replacements
in PI and the tag extensions to just before ArticlesAsJson encodes the output.
Which also removes the need from before the fix in #10701 to JSON encode the
parser output of the tags that will be replaced into the text.
2016-06-17 20:57:12 +10:00
Igor Rogatty 81830d7024 XW-1429 | use ArticleAsJsonBeforeEncode hook to move the first infobox marker 2016-05-09 13:56:28 +02:00
grunny a1bcf879a8 (MAIN-6855) Make hasInfobox and filterInfoboxes private 2016-04-06 19:55:36 +10:00
grunny 369a81faa6 (MAIN-6855) Move adding to the querypage cache to the QueryPage class
Fixes fatal error:

    PHP Fatal error: Cannot access private property
    AllinfoboxesQueryPage::$subpagesBlacklist in /extensions/wikia/
    PortableInfobox/PortableInfoboxHooks.class.php on line 166
2016-04-06 19:13:13 +10:00
grunny 7976e3be75 (CE-3571) Insert new infobox into querycache on creation
When a new portable infobox is created, add it to the querycache for the
AllInfoboxes list and purge its cache.
2016-03-31 22:30:02 +10:00
idradm 50c2a4c1ab DAT-3934 hide europa theme behind wiki variable 2016-03-16 11:52:12 +01:00
idradm 20d6a46421 DAT-3707 create infobox builder extension 2016-02-12 11:38:47 +01:00
idradm 5bbad66ec0 DAT-3707 remove unused entry point code 2016-02-12 10:05:16 +01:00
idradm d4953f7680 Merge branch 'dev' into infobox-builder-feature-branch
# Conflicts:
#	extensions/wikia/AdminDashboard/AdminDashboardLogic.class.php
#	extensions/wikia/AssetsManager/config.php
#	extensions/wikia/EditPageLayout/templates/EditPageLayout_EditPage.php
2016-02-09 11:46:56 +01:00
Inez Korczynski f084fd5fba VE-2012: Load PortableInfobox.js for all skins including monobook 2015-12-04 23:56:29 +00:00
Paul Oslund e6c81a3ea2 VE-1961: Render image collection tabs in infobox 2015-10-20 16:40:56 +00:00
dianafa e658aed5ca Merge branch 'dev' into infobox-builder-feature-branch 2015-10-05 18:39:29 +02:00
idradm 0f333e585f DAT-3199 clear props before article edit 2015-09-25 16:53:39 +02:00
idradm a5484d77fd DAT-3199 make type hinting accept more types 2015-09-25 09:23:25 +02:00
idradm 12120f3cf1 DAT-3199 change memc key to be more distinguishable, add type hinting 2015-09-24 17:17:47 +02:00
idradm a240110f44 DAT-3199 docs updated 2015-09-23 15:56:08 +02:00
idradm 859a0ee81b DAT-3199 use page_props directly instead of through parserOutput, add memcache layer for infoboxes data provider service, introduce hook on backlinks purge 2015-09-22 17:48:38 +02:00
Rafal Leszczynski 35fd8d87a4 Merge branch 'DAT-3153' into infobox-builder-feature-branch 2015-09-11 12:48:37 +02:00
Sebastian Marzjan ce6f4e7646 DAT-3192 Invalidate memcache on allinfoboxes query update 2015-09-08 12:05:06 -07:00
idradm b45cb47820 DAT-3153 add check if user can edit before displaying builder option 2015-09-08 14:23:50 +02:00
idradm b8e82efa10 DAT-3153 missing template hook approach changed 2015-09-08 12:48:40 +02:00
Rafal Leszczynski 16f15e7f7e change hook name and add checks for title=null 2015-09-03 15:53:25 +02:00
Rafal Leszczynski a2cfa5d9db add additional check to hook for infobox builder entry point 2015-09-02 17:59:53 +02:00
Rafal Leszczynski c043eb11f2 add additional checks for displaying entry point 2015-09-02 17:41:45 +02:00
Rafal Leszczynski be7681943c refactor infobox builder entry point on new template page 2015-09-02 13:04:50 +02:00
dianafa c97141d6a1 entry point add translations 2015-09-02 10:55:06 +02:00
Rafal Leszczynski 0ce1ab5782 fix special page name 2015-09-02 10:48:16 +02:00
Rafal Leszczynski f262750756 remove changes in edit page layout 2015-09-01 17:14:01 +02:00
dianafa 6067073b3c empty template entry point WIP 2015-09-01 16:43:47 +02:00
Rafal Leszczynski 88cd52bfc2 fix infobox builder setup in edit page 2015-09-01 15:00:34 +02:00
Rafal Leszczynski 2b5ba08159 set infobox builder url to match template name 2015-09-01 14:35:31 +02:00
idradm b49bb7c1da DAT-3154 call to action on template edit added 2015-08-27 14:50:02 +02:00
idradm bc69cfa7f3 DAT-3154 add infoboxbuilder entrypoint in template edit page 2015-08-27 13:41:33 +02:00
idradm 15a04ac566 DAT-3114 add query page for all infoboxes 2015-08-20 15:14:23 +02:00
idradm 29580c1c9d Merge remote-tracking branch 'origin/dev' into DAT-2874
# Conflicts:
#	extensions/wikia/PortableInfobox/PortableInfoboxHooks.class.php
2015-06-23 13:31:56 +02:00
idradm d7f5995e72 DAT-2874 remove constructor calls in favor of newFrom approach 2015-06-23 10:41:15 +02:00
idradm 02a2d0c3c1 DAT-2874 refactor infoboxes data service, push to top infobox item 2015-06-22 17:15:26 +02:00
Sebastian Marzjan aa0b067f96 Merge branch 'DAT-2895' of github.com:Wikia/app into DAT-2895 2015-06-19 16:11:32 +02:00
Sebastian Marzjan 17e82774c9 Address code review remarks 2015-06-19 15:50:25 +02:00
Sebastian Marzjan 5375ae8541 Address code review remarks 2015-06-19 15:36:16 +02:00
Sebastian Marzjan 1c0b69edee DAT-2895 Fetch gallery data if available for image tag in new infoboxes 2015-06-19 15:36:16 +02:00
jacek 51e19100e1 PR fix 2015-06-09 14:33:49 +02:00
jacek 0c7cfe261d PR fix 2015-06-09 14:31:04 +02:00
jacek 395ed5a148 using ImageServingHook is PortableInfobox ext 2015-06-09 12:14:49 +02:00
Rafal Leszczynski dea47524de fix issues with default infobox styles on monobook 2015-05-18 15:56:45 +02:00
Adam Robak 8a080d1a15 Merge branch 'portable_infobox_mvp' into DAT-2738
Conflicts:
	extensions/wikia/PortableInfobox/controllers/PortableInfoboxParserTagController.class.php
2015-05-07 14:58:52 +02:00
Adam Robak 9cd65fa63c remove duplicated test, added TODO comment for resources loading 2015-05-07 13:58:21 +02:00
Adam Robak ff6c367bc7 remove not needed hooks 2015-05-07 09:11:05 +02:00
Rafal Leszczynski db745fd097 remove unused js logic for portable infobox - moved thumbnail generator to php 2015-05-06 16:32:37 +02:00