Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-15 20:09:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review remarks

Browse source
This commit is contained in:
Sebastian Marzjan 2015-06-19 14:16:07 +02:00
parent 1c0b69edee
commit 5375ae8541
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
PortableInfoboxHooks.class.php
View file

@ -1,6 +1,8 @@
<?php
class PortableInfoboxHooks {
const PARSER_TAG_GALLERY = 'gallery';
static public function onBeforePageDisplay( OutputPage $out, Skin $skin ) {
if ( F::app()->checkSkin( 'monobook', $skin ) ) {
Wikia::addAssetsToOutput( 'portable_infobox_monobook_scss' );
@ -34,7 +36,7 @@ class PortableInfoboxHooks {
* @param $frame
*/
static public function onParserTagHooksBeforeInvoke( $name, $marker, $content, $attributes, $parser, $frame ) {
if ( $name === 'gallery' ) {
if ( $name === self::PARSER_TAG_GALLERY ) {
\Wikia\PortableInfobox\Helpers\PortableInfoboxDataBag::getInstance()->setGallery( $marker, $content );
}

9
services/Helpers/PortableInfoboxDataBag.php
View file

@ -27,11 +27,14 @@ class PortableInfoboxDataBag {
$this->galleries[$marker] = $content;
}
/**
* Retrieve source content of a gallery identified by Parser marker id
*/
public function getGallery( $marker ) {
if(isset($this->galleries[$marker])) {
if ( isset( $this->galleries[$marker] ) ) {
return $this->galleries[$marker];
} else {
return null;
}
return null;
}
}