Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-16 04:22:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
602 commits 8 branches 4 tags 31 MiB
Commit graph

602 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sebastian Marzjan 0ce0b500fe Use the Builder for Sanitizers. 
Cover the sanitizer build step in tests too
 2015-12-28 12:04:36 +01:00
Sebastian Marzjan 8f437fb1e7 DAT-3465 Update the caption behavior 2015-12-28 10:21:32 +01:00
dianafa a4e03f9147 add sanitizer tests 2015-12-23 16:08:43 +01:00
dianafa 8afcb73d10 move sanitizers to a separate folder 2015-12-23 15:54:03 +01:00
dianafa ed73d4f525 move sanitizing to PortableInfoboxRenderService 2015-12-23 13:20:55 +01:00
dianafa 0de509246f add caption sanitization in getImageData 2015-12-23 11:20:39 +01:00
Rafal Leszczynski f154200a97 DAT-3576, add test for thin portrait image edge case 2015-12-11 16:34:03 -08:00
Rafal Leszczynski 432341a974 DAT-3576, fix edge case with broken aspect ratio for tall thin images if portable infobox custom image width is set 2015-12-11 16:05:10 -08:00
marzjan 46fbb2b9c3 Make test cases make sense :) 2015-12-11 10:40:40 -08:00
Sebastian Marzjan f1896da8ab Add tests 2015-12-11 10:01:23 -08:00
dianafa f8312c6484 add getImageSizesToDisplay description 2015-12-11 12:06:44 +01:00
dianafa 33af8b75e9 rename getAdjustedImageSize to getImageSizesForThumbnailer 2015-12-11 12:02:00 +01:00
dianafa cc54d4478d move logic to other place & add tests 2015-12-11 11:56:41 +01:00
Rafal Leszczynski 02a2c62332 DAT-3576, allow for overwrite thumbnail physical dimensions in portable infobox via wikifactory variable 2015-12-10 16:41:07 -08:00
Inez Korczynski 3647cb2f37 VE-1965: Caption comes from Parser as a safe HTML so there is no need and it shouldn't be escaped 2015-12-09 00:47:05 +00:00
Inez Korczynski 52f7f4e083 VE-2069: By default use "===" comparison in PHP (instead of "==") 2015-12-07 22:37:56 +00:00
Inez Korczynski 53f762bfec VE-2069: Small code refactoring to avoid multiple nesting inside one method 2015-12-07 22:36:56 +00:00
Inez Korczynski b1efc457c3 VE-2069: Adjust tests to data that ImageNode is returning 2015-12-07 22:11:19 +00:00
Inez Korczynski 19fc47e23e VE-2069: Adjust getImages method to work well with recent changes to ImageNode 
I'm not very happy with how nested this method is but it seems that it is the convention taken within PortableInfobox project.
I would much better prefer if there was more object oriented way to delegate for instance task of retrieving images list directly to NodeImage but that would be much greater refactoring.
 2015-12-07 22:05:45 +00:00
Inez Korczynski f084fd5fba VE-2012: Load PortableInfobox.js for all skins including monobook 2015-12-04 23:56:29 +00:00
Inez Korczynski 553f4521a0 VE-2013: Fix problem with PI JS not being executed in preview by using wikipage.content hook 
JavaScript for PortableInfoboxes MediaCollections and CollapislbeGroups initialization was executed once while loading the file - so it was working propery for most common case which is displaying article (the view page). However sometimes content is loaded dynamically, after JavaScript already loaded and executed, and for such cases intialization was not happening. In particular such case is loading article preview from within the Classic Editor. Problem is solved by using solid and common MW approach of MediaWiki JavaScript hooks - specifically one named 'wikipage.content' which is meant to be fired whenever wikipage (in any context) is being displayed.
 2015-12-04 20:38:10 +00:00
adamkarminski 7ba8f0e658 CE-3014 Remove the deprecated PortableInfoboxClassification class 2015-12-03 10:42:21 +01:00
Inez Korczyński cb48a06b79 Merge pull request #9145 from Wikia/VE-2049 
VE-2049: Emergency Broadcast System
 2015-11-25 12:08:11 -08:00
dianafa 6e8091ec4d move ImageFilenameSanitizer logic to FileNamespaceSanitizeHelper 2015-11-25 11:00:39 +01:00
dianafa 23bb4be49d check file prefix by contentLang 2015-11-24 23:35:23 +01:00
Inez Korczynski 98cdff0851 VE-2064: There is no need to "alias" that variable 2015-11-23 19:55:03 +00:00
Paul Oslund 6e54a6d3a2 VE-2064: Extract method to load non-portable infoxes 2015-11-20 20:10:03 +00:00
Inez Korczynski 7d1f542f6c MAIN-5838: Check if $arguments is an array before handling it in array way ;) 2015-11-14 00:05:41 +00:00
Inez Korczynski 8a2ddb554b VE-2041: Added comment regarding commented out code 2015-11-12 21:23:38 +00:00
Inez Korczynski 025b4e387b VE-2041: Fix infobox API to actually return proper response. 
This is still work in progress - weighing pros and cons of two different approaches to this problem.
 2015-11-12 02:16:01 +00:00
Diana 15a00b4d4e sanitize horizontal group items as well 2015-11-05 17:57:53 +00:00
Diana 91804e99c3 add test for sole image in label 2015-11-05 13:29:42 +00:00
Diana 49feb54689 change method name to sanitizeInfoboxFields and refactor 2015-11-05 13:21:20 +00:00
Diana 7e9836085a adjust hero image template 2015-11-03 16:31:31 +00:00
dianafa 649895d4cf change variable names and add missing PHPdocs 2015-11-03 17:19:29 +01:00
dianafa 2214b5c81f add logging each striping to Kibana 2015-11-03 16:58:25 +01:00
dianafa 79a0bf14fa DAT-3329 add more tests and clean identation 2015-11-03 16:36:52 +01:00
dianafa 653a64942d change function invocation in RenderService 2015-11-03 16:13:45 +01:00
dianafa 3f2d287e8a do not strip links 2015-11-03 16:12:44 +01:00
dianafa 569ef4ae4c add tests 2015-11-03 16:11:08 +01:00
dianafa 2a0c5ef3d0 sanitize labels as well 2015-11-03 14:45:27 +01:00
Inez Korczyński 6b78b8a3ae Merge pull request #8943 from Wikia/PI-Collapsible-Groups 
Collapsible Groups for Portable Infoboxes
 2015-10-30 10:46:00 -07:00
Inez Korczynski 70d18e11ea VE-2003: Remove unncecessary empty lines 2015-10-28 17:57:00 +00:00
Inez Korczynski d46955d8ee VE-2003: Created unit tests to "collapse" attribute of PI groups 2015-10-28 17:55:03 +00:00
Nikodem Hynek ef9c31ccc0 Merge pull request #8899 from Wikia/DAT-3402 
DAT-3402 move links placeholder replacement after markers are resolved
 2015-10-28 10:58:52 +01:00
Inez Korczynski ad224dab1e VE-2006: Change order of CSS so overwrites for collapsable groups happens after stack layout 2015-10-28 06:56:50 +00:00
Inez Korczyński 9f09c5df1a Merge pull request #8904 from Wikia/VE-1996 
VE-1996: Create JS to toggle pi-collapse-closed class
 2015-10-27 23:44:59 -07:00
Paul Oslund 8f020f6bd5 VE-1997: Use mixin for chevron rotation 2015-10-27 23:16:24 +00:00
Paul Oslund cae6efafca VE-1997: Add chevron to pi-collapse header 2015-10-27 22:16:27 +00:00
Inez Korczynski f901a1642e VE-2004: Silencing loadHTML warning 
I carefully researched the topic and it seems that there is no way to instruct DOMDocument to accept "lower" quality HTML. Specifically in HTML <div> or <figure> (block elements) are not allowed inside <p> (which accepts only inline elements) - hence it's complaining about.

Based on comments from stackoverflow it seems that such practice (silencing it) is commong practice in this situation.
 2015-10-27 20:02:58 +00:00