Universal-Omega/PortableInfobox
1
0
Fork 0
mirror of https://github.com/Universal-Omega/PortableInfobox.git synced 2024-11-15 11:59:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

add todo comment about generating thumbnail

Browse source
This commit is contained in:
Rafal Leszczynski 2015-05-21 13:20:57 +02:00
parent f9c31ad797
commit 8cb897bb00
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/PortableInfoboxRenderService.class.php
View file

@ -4,8 +4,11 @@ class PortableInfoboxRenderService extends WikiaService {
const LOGGER_LABEL = 'portable-infobox-render-not-supported-type';
const DESKTOP_THUMBNAIL_WIDTH = 270;
const MOBILE_THUMBNAIL_WIDTH = 360;
// we need this value cause it it impossible to get vignette thumbnail only specifying width and the height need
// to be big enough so each image width will reach our thumbnail width based on its aspect ratio
// TODO: https://wikia-inc.atlassian.net/browse/MAIN-4601 - request for the missing vignette feature which will
// allow us to remove THUMBNAIL_HEIGHT from the code. Currently we need this value cause it it impossible to get
// vignette thumbnail without upsampling only specifying width. The height need to be big enough so each image width
// will reach our thumbnail width based on its aspect ratio
const THUMBNAIL_HEIGHT = 1000;
const MOBILE_TEMPLATE_POSTFIX = '-mobile';