From 8cb897bb003b386b6e06abc9c5e5d71322999acc Mon Sep 17 00:00:00 2001 From: Rafal Leszczynski Date: Thu, 21 May 2015 13:20:57 +0200 Subject: [PATCH] add todo comment about generating thumbnail --- services/PortableInfoboxRenderService.class.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/services/PortableInfoboxRenderService.class.php b/services/PortableInfoboxRenderService.class.php index 68c3c74..d18af4f 100644 --- a/services/PortableInfoboxRenderService.class.php +++ b/services/PortableInfoboxRenderService.class.php @@ -4,8 +4,11 @@ class PortableInfoboxRenderService extends WikiaService { const LOGGER_LABEL = 'portable-infobox-render-not-supported-type'; const DESKTOP_THUMBNAIL_WIDTH = 270; const MOBILE_THUMBNAIL_WIDTH = 360; - // we need this value cause it it impossible to get vignette thumbnail only specifying width and the height need - // to be big enough so each image width will reach our thumbnail width based on its aspect ratio + // TODO: https://wikia-inc.atlassian.net/browse/MAIN-4601 - request for the missing vignette feature which will + // allow us to remove THUMBNAIL_HEIGHT from the code. Currently we need this value cause it it impossible to get + // vignette thumbnail without upsampling only specifying width. The height need to be big enough so each image width + // will reach our thumbnail width based on its aspect ratio + const THUMBNAIL_HEIGHT = 1000; const MOBILE_TEMPLATE_POSTFIX = '-mobile';