Commit graph

1809 commits

Author SHA1 Message Date
alistair3149 cc0820c204
feat(wikitable): use more accurate selectors to apply border and border radius 2024-07-20 19:53:26 -04:00
alistair3149 2fe94438ee
feat(core): add reset styles for border-width and border-color
This will affect existing wikis that uses the invalid border attribute like in #902.
Border attribute is not valid HTML in HTML5 and it has been causing a lot of headache
in other styles
2024-07-20 19:35:14 -04:00
alistair3149 764f7593c3
fix(overflow): 🐛 fix undefined wrapper 2024-07-20 19:32:22 -04:00
alistair3149 08a7a51566
fix(wikitable): 🐛 incorrect selector for tfoot 2024-07-20 17:49:36 -04:00
github-actions 0242d9bc6e ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-20 21:46:51 +00:00
alistair3149 15ebea1c80
fix(wikitable): 🐛 incorrect border radius when both thead and tbody are present 2024-07-20 17:46:18 -04:00
alistair3149 4d803f841d
feat(fonts): bump Roboto Flex to 3.200 2024-07-19 22:49:35 -04:00
alistair3149 b9cd27043d
feat(core): tweak changelist and toc border width 2024-07-19 18:31:22 -04:00
alistair3149 a1ad423f2f
feat(stickyHeader): implement sticky header variables into other sticky styles 2024-07-19 17:29:17 -04:00
alistair3149 8c204767c6
refactor(stickyHeader): ♻️ use box-shadow instead of border for bottom border
So that it won't affect the height of the element
2024-07-19 17:10:06 -04:00
alistair3149 c9d98e477a
feat(stickyHeader): add CSS var --height-sticky-header to offset sticky elements
--height-sticky-header will always return the current height of sticky header.
It can be used to offset sticky elements so that it adjusts to the sticky header.
2024-07-19 17:08:03 -04:00
alistair3149 f3042f5b80
fix(toc): 🐛 ToC should have the same padding as other menu cards 2024-07-19 16:27:19 -04:00
alistair3149 e38b44edb2
refactor(search): ♻️ simplify URL generation by using mw.util.getUrl
getUrl will handle both the short URL and santization
2024-07-17 14:16:55 -04:00
alistair3149 a9fb03fc8e
fix(print): 🐛 only color variables require important declaration 2024-07-15 02:09:05 -04:00
alistair3149 1fefddd41a
feat(core): implement Codex border-width tokens 2024-07-15 02:07:25 -04:00
alistair3149 5296aef9de
feat(print): add wikitable styles and hide contentSub 2024-07-15 02:03:28 -04:00
alistair3149 aeb083e74d
fix(print): 🐛 add important declaration to hidden print elements 2024-07-14 19:41:41 -04:00
alistair3149 8641becb2a
feat(print): allow font size settings affect print styles 2024-07-14 18:09:53 -04:00
alistair3149 1da57e5902
feat(print): hide page footer in print styles 2024-07-14 18:05:03 -04:00
github-actions 79ac340667 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-14 21:44:10 +00:00
alistair3149 543400d9d5
feat(print): rework print styles 2024-07-14 17:43:34 -04:00
alistair3149 c3855ff8b9
fix(stickyHeader): use cached value for placeholder height if possible
Related: #854
2024-07-12 03:47:25 -04:00
alistair3149 f0d1176f2a
feat(pref): add clientpref to disable auto-hide navigation
Closes #841
2024-07-10 13:59:03 -04:00
alistair3149 2794a3269c
fix(core): 🐛 explictly set z-index for body container
That should avoid position relative elements from going over the sticky header.

Closes: #577
2024-07-09 18:28:31 -04:00
alistair3149 c555dfe1bf
fix(ToC): 🐛 increase z-index of ToC backdrop 2024-07-09 16:51:25 -04:00
alistair3149 b5180bfbda
feat(core): use Codex tokens for z-index 2024-07-09 16:44:15 -04:00
alistair3149 f66348bdbb
feat(stickyHeader): reduce page title size 2024-07-08 23:40:08 -04:00
alistair3149 6dfc62b15d
fix(core): 🐛 add webkit prefix to backdrop filter rules
Safari needs the -webkit- prefix
2024-07-08 19:07:25 -04:00
alistair3149 a4593d7dd3
fix(dropdown): 🐛 use both touchstart and mousedown event listener for click outside event
On iOS devices, click event listeners don't work when the target does not have cursor: pointer.
This should resolve the issue for iOS browsers.

Related: #895
2024-07-08 15:54:15 -04:00
alistair3149 aaa677f2d6
fix(toc): 🐛 fix transparent ToC button 2024-07-08 15:35:01 -04:00
alistair3149 20e4f7ec6e
feat(dropdown): add fade-in animation to dropdown menu 2024-07-08 15:33:02 -04:00
alistair3149 8eef0aae42
feat(stickyHeader): add background transition 2024-07-08 14:29:33 -04:00
alistair3149 7f9f975b9e
fix(stickyHeader): 🐛 only add sticky class on resize when it is applicable 2024-07-08 14:01:13 -04:00
github-actions 49663c9199 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-08 06:24:11 +00:00
alistair3149 ecc4cca043
fix(search): 🐛 check if article path has question mark before adding search params
Fixes: #903
2024-07-08 02:23:43 -04:00
github-actions a883f9dda0 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-07 22:18:34 +00:00
alistair3149 a7a763b57f
fix(stickyHeader): 🐛 use more accurate calculation for placeholder 2024-07-07 18:17:50 -04:00
github-actions 1214750eab ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-07 21:58:50 +00:00
alistair3149 e5336c4610
fix(stickyHeader): 🐛 add a placeholder element to page header to avoid layout shift when stickied
Closes: #854
2024-07-07 17:58:02 -04:00
alistair3149 e9fd488cee
fix(share): 🐛 incorrect debounce parameter assignment 2024-07-07 17:40:37 -04:00
alistair3149 55b310d26d
fix(search): 🐛 fix incorrect parameter for debounce function 2024-07-07 17:33:41 -04:00
alistair3149 28968179ce
feat(codex): backport Codex v1.8.0 variables to mediawiki.skin.variables 2024-07-07 15:57:33 -04:00
github-actions c7dfa58393 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-07 10:26:24 +00:00
alistair3149 72edb817be
fix(toc): 🐛 keep ToC button at the same position 2024-07-07 06:25:38 -04:00
github-actions f19bfe11e7 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-07 07:07:33 +00:00
alistair3149 91619884ab
fix(core): 🐛 incorrect box-shadow values
It seems that stylelint somehow wiped out the previous value.
2024-07-07 03:06:42 -04:00
alistair3149 3d7311dbbe
fix(skinning): 🐛 only apply top margin to figcaption when it is not empty 2024-07-07 02:45:50 -04:00
alistair3149 232fd0cc4b
feat(core): clean up th styles
- th should not use the same styles as label
- Restore font weight and color to th
- Sync different th styles in extensions
2024-07-07 02:14:36 -04:00
alistair3149 fccc024978
feat(wikitable): avoid double border when border attribute is active 2024-07-07 01:56:01 -04:00
github-actions 6a79df2fd5 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-07 05:53:18 +00:00
alistair3149 442c272cab
feat(wikitable): use box-shadow instead of border hacks to build table border 2024-07-07 01:51:22 -04:00
alistair3149 c2523b141c
fix(dropdown): 🐛 dropdown button should be above the backdrop 2024-07-06 22:42:15 -04:00
alistair3149 ba62b92e29
feat(core): theme and unify text selection color using progressive colors 2024-07-06 17:53:56 -04:00
github-actions 729bfc57e8 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-06 03:59:04 +00:00
alistair3149 d3ef4afecc
fix(core): 🐛 fix incorrect screen reader text reset styles 2024-07-05 23:58:17 -04:00
alistair3149 fdc6eaee20
feat(Echo): upgrade Echo buttons for consistency
This is similiar to how it is handled in Vector.
We are forcing the Echo button to render in the same way as it was initially.
This took me so many hours sigh.
2024-07-05 20:37:52 -04:00
alistair3149 9ace83a9bc
fix(search): 🐛 incorrect article not found icon size 2024-07-05 16:28:33 -04:00
alistair3149 90cb44d445
refactor(search): ♻️ remove unused argument from getPageTitle 2024-07-05 16:27:32 -04:00
alistair3149 c5c47aeb5f
feat(search): use Short URL in search suggestion
This should avoid a bunch of 302 redirects using the old Special:Search links.
2024-07-05 16:21:10 -04:00
alistair3149 9c77c7f3f2
feat(search): unify url generation in search typeahead
- Convert searchAction to use urlGenerator
- Repurpose urlGenerator to be more generic

Fixes: #898
2024-07-05 15:32:26 -04:00
alistair3149 3392eb796c
fix(core): 🐛 remove git merge artifacts 2024-07-05 13:41:43 -04:00
alistair3149 b53381ed12
feat(pref): extend font-size adjustments to all text
- Move font size calucation from LESS to CSS variables
- Move font size variables to tokens.less
2024-07-05 13:40:39 -04:00
github-actions 07090c800d ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-05 17:24:29 +00:00
alistair3149 00b2495c1a
feat(core): use px for border-radius
- Move border radius calculation to CSS variable instead of LESS
- Rename CSS variable according to Codex, soft-deprecating the existing border radius
2024-07-05 13:24:31 -04:00
alistair3149 317296e7b0
fix(dropdown): 🐛 merge conflicting dismiss event handlers
Focus loss and click outside are basically using the same function.
Merging them should avoid them conflicting with each other.

Related: #895
2024-07-04 16:00:46 -04:00
alistair3149 a68626f56a
fix(toc): 🐛 elements behind collasped ToC should be interactable
Fixes: #896
2024-07-04 15:48:01 -04:00
alistair3149 add781a4a1
feat(core): use text-wrap pretty for blockquote elements
Note that this is still in editor draft and only works for Chromium browser
2024-07-04 15:17:09 -04:00
alistair3149 f2ff92e1ac
feat(toc): drop checkbox hack usage in ToC in favor of dropdown (#894)
Now that ToC is also using the new dropdown system, we can remove all references to the old checkbox hack now.

Fixes: #855
2024-07-03 17:44:52 -04:00
alistair3149 516ef3a1cb
feat(dropdown): revamp dropdown menu handling
Putting the dropdown content in the details elemenet have been inconsistent.
Transition are not working correctly and different browsers are not handling it well.
Furthermore, the previous implementation does not allow an always visible state of dropdown content.

Fixes: #882
2024-07-03 16:07:19 -04:00
alistair3149 111607ec96
fix(core): 🐛 avoid sr-only text clipping during transform 2024-07-03 15:40:21 -04:00
github-actions 3bbe2f4c16 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-03 18:41:07 +00:00
alistair3149 5b0bb4c209
refactor(core): ♻️ use new sr-only rules instead of relying on core
Core mixins are very conservative in comparsion and mixins are changed from time to time.
It is more maintainable to maintain our own sr-only styles.
2024-07-03 14:41:14 -04:00
alistair3149 23f2667b24
fix(core): 🐛 fix invalid background-color properties 2024-07-03 14:20:20 -04:00
alistair3149 1bce8921d0
fix(core): 🐛 remove smooth scrolling for body
Often on long pages, smooth scrolling is causing unexpected behaviors and performance issues. For example, it refuses to scroll to the target, or triggers lazyloaded content when not needed. 

Fixes: #883
2024-07-03 03:03:20 -04:00
github-actions 23e145d275 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-03 05:31:24 +00:00
alistair3149 23b3c3326a
feat(menu): add blur to menu backdrop 2024-07-03 01:30:42 -04:00
alistair3149 931e94da43
chore(dev): 🔧 disable plugin/no-unsupported-browser-features in Stylelint
It is very conservative and it is negatively affecting the performance of Stylelint.
Disabling it for now.
2024-07-02 19:29:37 -04:00
alistair3149 2f7ae8fc1d
fix(stickyHeader): 🐛 use margin and padding instead of grid gap for body spacing
That should address the flickering issue caused by the sticky header
2024-07-02 19:26:50 -04:00
alistair3149 7ec0ae5b8e
refactor(stickyHeader): ♻️ create sticky sentinel in JS instead
It is only used for sticky header which requires JS, we should just create it in JS
2024-07-02 19:20:17 -04:00
alistair3149 d71ee758f4
refactor(core): ♻️ remove unused styles 2024-07-02 19:19:40 -04:00
alistair3149 ae4131f51f
fix(pageActions): 🐛 language badge should use the same color as its background 2024-07-01 13:44:28 -04:00
alistair3149 fbd030afeb
fix(skinning): 🐛 fix incorrect mw-halign-left left margin 2024-07-01 13:42:28 -04:00
alistair3149 568dfc7de3
fix(core): 🐛 fix max-width breakpoint calculation in LESS
Related: T367103
2024-07-01 13:38:12 -04:00
alistair3149 5715a29dae
feat(stickyHeader): reduce direction observer throttle 2024-07-01 13:19:59 -04:00
alistair3149 aaee215cf6
refactor(stickyHeader): ♻️ move sticky header script into a separate module 2024-07-01 13:19:31 -04:00
alistair3149 7c9eadb662
feat(core): convert some CSS variables into Codex equivalent part 3 2024-07-01 00:16:15 -04:00
github-actions 852fd86013 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-07-01 04:06:43 +00:00
alistair3149 ff0a6ed710
feat(core): clean up state colors 2024-07-01 00:04:36 -04:00
alistair3149 c21a908c12
feat(core): set new link color to color-destructive 2024-06-30 20:49:50 -04:00
alistair3149 66e7282acc
fix(preferences): 🐛 incorrect active button color 2024-06-30 20:49:15 -04:00
alistair3149 0fdc7c4ad7
feat(core): convert some CSS variables into Codex equivalent part 2
Also fix various inconsistencies with quiet buttons
2024-06-30 20:41:31 -04:00
alistair3149 0a1ac14677
feat(pageActions): blend language badge into the background 2024-06-30 01:11:35 -04:00
alistair3149 5d3ecd9edd
feat(core): convert some CSS variables into Codex equivalent
This is an on-going work to adapt Codex into Citizen.
Some of the CSS variables are soft depreciated, see tokens.less for updated info.
2024-06-30 01:04:30 -04:00
alistair3149 fce1f775c4
feat(pageActions): use neutral color for language badge 2024-06-29 20:53:21 -04:00
alistair3149 1edc40e70c
feat(share): only share URL
The text handling across OS is inconsistent, and it is more desirable to just share the link and get the description through the embed.
2024-06-28 19:25:57 -04:00
alistair3149 327aca0b2c
feat(pageActions): add share button to page actions for article pages 2024-06-28 18:42:04 -04:00
alistair3149 c34868d04e
fix(overflow): 🐛 remove unused mask rules 2024-06-27 18:54:48 -04:00
alistair3149 eb58bd6e99
fix(menu): 🐛 show view button specifically on revision and diff pages
The previous attempts didn't catch all the cases. This should be enough.

Related: #845
2024-06-27 18:21:28 -04:00
alistair3149 f0de4f4c5b
feat(overflow): use CSS variable for overflow gradient size
This will allow the gradient to be adjustable through CSS
2024-06-27 18:15:32 -04:00
alistair3149 e4697c48f1
fix(skinning): 🐛 incorrect text alignement for mw-halign-center 2024-06-25 15:19:10 -04:00
alistair3149 dd53576941
fix(menu): 🐛 prevent page from scrolling when dropdown menu is open in small viewport 2024-06-25 12:47:07 -04:00
alistair3149 7133648fe0
fix(wordmark): 🐛 wordmark should resize responsively 2024-06-24 17:12:57 -04:00
alistair3149 7fb35f90f5
fix(overflow): 🐛 prevent overflow button from triggering form action button
When the overflow button is within a `<form>` element, it can sometimes
trigger the form action (e.g. In the realtime preview of WikiEditor).
2024-06-24 14:39:33 -04:00
alistair3149 c47531a28b
feat(wordmark): implement wordmark in drawer
Also simplify existing styles for wordmark
2024-06-24 14:05:21 -04:00
alistair3149 e0507d489d
fix(footer): 🐛 incorrect invert rule for footer wordmark 2024-06-24 13:42:30 -04:00
alistair3149 08e63e3caf
feat(skinning): remove top and bottom margin from nested lists
Related: #886
2024-06-18 19:48:54 -04:00
alistair3149 fae9dad9b0
fix(skinning): 🐛 incorrect margin for right float thumbnails 2024-06-16 20:57:14 -04:00
alistair3149 2639b0f70d
fix(overflow): 🐛 overflow content should fill parent container 2024-06-15 17:38:47 -04:00
alistair3149 00dba9540b
fix(menu): 🐛 fix invisible user menu on desktop Safari 2024-06-14 16:23:53 -04:00
alistair3149 d079cc9b29
fix(core): 🐛 incorrect side margin for ul and ol 2024-06-14 16:02:13 -04:00
alistair3149 5bc18b5f4a
feat(core): hide the text from the help indicator 2024-06-14 13:12:30 -04:00
alistair3149 9bd18ea054
fix(overflow): 🐛 wrapper should respect float elements
Fixes: #878
2024-06-14 12:59:14 -04:00
alistair3149 e064de2402
refactor(cssVar): ♻️ replace all filter rules with CSS variables 2024-06-14 12:24:02 -04:00
alistair3149 a7c74e3f10
fix(menu): 🐛 fix invisible user menu 2024-06-13 23:01:26 -04:00
alistair3149 3b3bb3030d
fix(menu): 🐛 incorrect Safari details marker selector 2024-06-13 03:39:03 -04:00
alistair3149 c52dc49d6d
fix(menu): 🐛 hide Safari details marker 2024-06-13 03:24:13 -04:00
alistair3149 089a329da9
fix(toc): 🐛 ToC should have a higher z-index than page actions in smaller viewport
In order to avoid collision between the bottom page action bar and the ToC dropdown
2024-06-12 13:01:43 -04:00
alistair3149 feae1e6ad3
fix(pagetools): 🐛 attach menu to the page actions bar instead of the button 2024-06-12 13:00:13 -04:00
alistair3149 dd89daba39
fix(overflow): 🐛 allow to click through the nav element 2024-06-12 12:51:50 -04:00
alistair3149 7830faa8fe
fix(overflow): 🐛 mark oveflow button as not accessible for screen reader 2024-06-11 19:15:57 -04:00
github-actions 6c39537a51 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-06-11 23:10:13 +00:00
alistair3149 4b457dfa08
fix(overflow): 🐛 align scroll buttons with content margin 2024-06-11 19:07:38 -04:00
alistair3149 cbf60030f1
fix(overflow): 🐛 use more accurate rounding method for overflow detection 2024-06-11 18:56:54 -04:00
alistair3149 55d413eeda
feat(overflow): add overflow scroll button when using a pointer device 2024-06-11 18:00:45 -04:00
alistair3149 8541b7ee88
fix(core): 🐛 incorrect opacity and color of icons in button 2024-06-11 15:48:02 -04:00
alistair3149 86ef5ef06d
feat(cssVar): add --color-inverted-primary for text color above primary color 2024-06-10 19:47:49 -04:00
alistair3149 0a8c49a573
fix(skinning): 🐛 incorrect margin value for floating thumbnail 2024-06-10 16:18:06 -04:00
alistair3149 ababe58186
fix(core): 🐛 do not debounce scroll direction script 2024-06-09 22:58:17 -04:00
github-actions 26076514c1 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-06-07 19:01:54 +00:00
alistair3149 d0e684236e
fix(search): 🐛 remove unused param from getRedirectMessage() 2024-06-07 15:01:37 -04:00
alistair3149 3d146b2374
refactor(cssVar): ♻️ introduce color-inverted 2024-06-05 18:54:54 -04:00
alistair3149 e9d7cc270a
perf(core): ️ do not use will-change (part 2) 2024-06-01 15:55:27 -04:00
alistair3149 d8b3cad225
perf(core): ️ do not use will-change 2024-06-01 15:36:48 -04:00
github-actions 5fbf8bf938 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2024-06-01 19:35:16 +00:00
alistair3149 151e51da2f
fix(search): 🐛 opening search card should not play animation on mobile 2024-06-01 15:34:14 -04:00
alistair3149 6108fccc31
refactor(menu): ♻️ remove unused checkbox hack styles 2024-06-01 15:29:12 -04:00
alistair3149 502b462c06
style(dropdown): 🎨 clean up code styles 2024-06-01 15:28:49 -04:00
alistair3149 32d10f893b
fix(dropdown): 🐛 toggle should dismiss the dropdown properly 2024-06-01 15:13:38 -04:00
alistair3149 87513459c4
fix(core): 🐛 hide Safari details marker 2024-05-31 03:28:52 -04:00
alistair3149 d0691a06d0
feat(core): add dismiss affordnance to dropdown menus 2024-05-30 16:20:03 -04:00
alistair3149 a2d3159def
feat(core): replace checkbox hack with details and summary
Note that ToC is still using the old checkbox hack, it will be replaced in a later time.
Related: T333394
2024-05-30 02:20:13 -04:00
alistair3149 a8daa82354
fix(core): 🐛 avoid using core mw.util.addPortlet for now
Seems to break in 1.41, will look into it later
2024-05-29 20:21:55 -04:00
alistair3149 83ab221408
feat(core): only handle wikitable instead of all tables
Wikis use tables in creative ways and it is probably just safer to only apply it to wikitables.
Might revisit if there are any news from T330527.
2024-05-29 17:47:13 -04:00
alistair3149 87f15ddd6d
fix(core): 🐛 incorrect selector to disable search card animation on mobile 2024-05-29 14:06:58 -04:00
alistair3149 2bbb1d9408
perf(core): ️ check for nowrap classes before constructing class 2024-05-29 14:02:57 -04:00
alistair3149 c40c7c7b84
feat(core): destructure surface colors into hsl variables 2024-05-28 13:59:07 -04:00
alistair3149 621adff9fc
fix(core): 🐛 incorrect classes and styles for page action cards 2024-05-28 02:12:50 -04:00
alistair3149 87a8bf256e
refactor(core): ♻️ various cleanup 2024-05-27 23:18:13 -04:00
alistair3149 f74e3d2f6a
perf(core): ️ tweak menu animation timing 2024-05-27 23:17:48 -04:00
alistair3149 2d10199b27
refactor(core): ♻️ remove redundant selector 2024-05-27 23:00:28 -04:00