StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-24 06:24:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

style(dropdown): 🎨 clean up code styles

Browse source
This commit is contained in:
alistair3149 2024-06-01 15:28:49 -04:00
parent 32d10f893b
commit 502b462c06
No known key found for this signature in database
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
resources/skins.citizen.scripts/dropdown.js
View file

@ -51,10 +51,9 @@ class Dropdown {
* @param {Event} event
*/
dismissOnEscape( event ) {
if ( event.key !== 'Escape' ) {
return;
if ( event.key === 'Escape' ) {
this.dismiss();
}
this.dismiss();
}
/**
@ -80,6 +79,9 @@ class Dropdown {
}
}
/**
* Unbind event listeners for the dropdown menu.
*/
unbind() {
this.target.removeEventListener( 'click', this.dismissOnLinkClick );
window.removeEventListener( 'click', this.dismissOnClickOutside );
@ -87,6 +89,9 @@ class Dropdown {
window.removeEventListener( 'keyup', this.dismissOnEscape );
}
/**
* Bind event listeners for the dropdown menu.
*/
bind() {
this.target.addEventListener( 'click', this.dismissOnLinkClick );
window.addEventListener( 'click', this.dismissOnClickOutside );
@ -106,7 +111,7 @@ class Dropdown {
this.details.addEventListener( 'toggle', this.onDetailsToggle );
// T295085: Close all dropdown menus when page is unloaded to prevent them
// from being open when navigating back to a page.
window.addEventListener( 'beforeunload', this.dismiss.bind( this ) );
window.addEventListener( 'beforeunload', () => this.dismiss );
}
}