Commit graph

200 commits

Author SHA1 Message Date
alistair3149 0c23e50d62
feat(core): convert tagline to langauage variant when appliable 2023-02-16 12:23:17 -05:00
alistair3149 c8d5a6e5f4
fix(core): 🐛 reset array index after removing toolbox from sidebar
This should fix the issue where SidebarBeforeOutput is not working in some scenario.

Fix: #580
2023-02-15 15:40:13 -05:00
alistair3149 081a176edc
fix(core): 🐛 handle null exception for user group 2023-02-10 10:06:06 -05:00
github-actions 7a0f3a1294 ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2023-01-31 19:55:38 +00:00
alistair3149 d14ddd99e6
refactor(core): ♻️ simplify page title implementation 2023-01-31 14:54:20 -05:00
CosmicAlpha 8aca2e8b68
refactor(core): ensure that shouldShowPageTools() returns a bool (#573) 2023-01-21 18:11:41 -05:00
alistair3149 e3bf5813c8
fix(core): 🐛 disable ULS-enhanced language button for now
Somehow the ULS popup does not appear after clicking the button.
Disabling it for now until it is fixed
2023-01-15 02:26:34 -05:00
github-actions aacf10b20c ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2023-01-04 00:28:23 +00:00
alistair3149 8c4bd54d32
feat(core): only add upload link when it is enabled
Citizen should not add upload link to drawer when $wgEnableUploads is
false.
2023-01-03 19:26:43 -05:00
alistair3149 ad714dcfed
feat(core): allow collapsible sections with DiscussionTools wrappers on headings
Bug: T314714
2022-11-24 21:36:06 -05:00
alistair3149 81eadf9c8d
perf(core): ️ replace getElementsByTagName() with DOMCompat::querySelectorAll()
Should help with performance quite a bit
Bug: T317070
2022-11-24 21:26:55 -05:00
alistair3149 997c152a2a
feat(core): migrate collapse icon to RL icon module 2022-11-21 17:43:19 -05:00
github-actions ce25c752b6
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:42:58 -05:00
alistair3149 7eae7c6b14
feat(core): migrate sitestats to use RL icon module 2022-11-21 17:42:57 -05:00
alistair3149 9232c91352
feat(core): deprecate preconnect
Deprecating due to low usage. It was originally used for external assets
like analytics, but that should really be done through the extension instead
of the skin.
2022-11-21 17:42:16 -05:00
alistair3149 7bd34caad5
style(core): 🎨 rename personal menu to user menu 2022-11-21 17:41:30 -05:00
github-actions f12218c0dc
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:41:25 -05:00
alistair3149 e9677d6b87
refactor(core): ♻️ clean up user menu header 2022-11-21 17:41:23 -05:00
alistair3149 a31babc297
refactor(core): ♻️ drop polyfill related to user menu 2022-11-21 17:41:20 -05:00
alistair3149 7b311db1a6
refactor(core): ♻️ use user-menu template data instead 2022-11-21 17:41:13 -05:00
github-actions be18ec8f0d
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:41:11 -05:00
alistair3149 d78ffeadb4
refactor(core): ♻️ use core data for search box 2022-11-21 17:41:10 -05:00
alistair3149 dfbaa67995
refactor(core): ♻️ drop responsive meta tag fallback 2022-11-21 17:41:08 -05:00
alistair3149 a93f373269
refactor(core): ♻️ use core sidebar data 2022-11-21 17:41:06 -05:00
github-actions 7b3e696f7b
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:41:00 -05:00
alistair3149 ac12ff0444
refactor(core): ♻️ use MW footer data and add onto it 2022-11-21 17:40:58 -05:00
alistair3149 4c9aa17bb2
refactor(core): ♻️ drop footer mustache fallback 2022-11-21 17:40:56 -05:00
alistair3149 2bc022aba2
feat(core): rename $wgCitizenSiteToolsPorlet to $wgCitizenGlobalToolsPorlet 2022-11-21 17:40:54 -05:00
alistair3149 fb9b17108d
style(core): 🎨 rename site tools to global tools
So that it aligns with the naming scheme from Desktop Improvements
2022-11-21 17:40:53 -05:00
alistair3149 4f74f0b4ad
refactor(core): ♻️ drop getFooterIcons 2022-11-21 17:40:49 -05:00
github-actions 7c50ed320d
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:40:46 -05:00
alistair3149 0ddd1ebf80
refactor(core): ♻️ clean up page tools implementation 2022-11-21 17:40:44 -05:00
alistair3149 05e3c6762d
refactor(core): ♻️ drop getPortletData usage in notifications 2022-11-21 17:40:43 -05:00
alistair3149 bd07799a67
refactor(core): ♻️ drop getPorletData usage in drawer 2022-11-21 17:40:41 -05:00
alistair3149 de362b6f24
refactor(core): ♻️ drop logos fallback 2022-11-21 17:40:36 -05:00
github-actions cf653a32a0
ci: 👷 lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-11-21 17:40:34 -05:00
alistair3149 2acb154164
refactor(core): ♻️ drop Action API fallback 2022-11-21 17:40:30 -05:00
alistair3149 81f3810a7e
refactor: ♻️ drop runOnSkinTemplateNavigationHooks fallback 2022-11-21 17:40:29 -05:00
alistair3149 bf66c60f3d
feat(core): tweak body footer styles 2022-10-01 19:36:09 -04:00
alistair3149 aaad2bb92a
feat(core): move footer info into body footer
They are related to the article/page instead of the whole site
2022-10-01 17:25:20 -04:00
CosmicAlpha 6384d02b74
feat: use loose comparison for checking if CitizenShowPageTools is true (#497) 2022-08-02 19:08:00 -04:00
alistair3149 00e1f57bad
feat(core): add config to use numberformatter without disabling sitestats
Add the ability to disable numberformatter independently from sitestats
Due to an upstream issue, numberforrmatter can throw an exception in some
instances (#474). This will help to mitigate the issue.
2022-06-14 15:56:03 -04:00
alistair3149 681f4fd9fa
refactor(core): only get user-related stats when user is registered 2022-06-02 10:46:14 -04:00
alistair3149 756e398242
fix(core): check if user is registered before getting edit count
getEditCount() throws an exception if the user is not registered before 1.37
2022-06-02 10:37:31 -04:00
alistair3149 0a68a178cc
refactor(core): use array_merge to get sidebar for toolbox
Spread syntax is not supported before PHP 7.4
2022-05-28 14:26:32 -04:00
alistair3149 53ef5f0543
refactor(core): use core responsive mode for MW 1.36+
Use core responsive mode for MW 1.36+, and polyfill for MW 1.35
2022-05-26 18:12:08 -04:00
alistair3149 11c50a5669
refactor(core): remove redundant message keys 2022-05-26 17:57:57 -04:00
alistair3149 58d85ff426 refactor(core): normalize PHP namespaces used in Citizen
Related: T303102
2022-05-26 16:58:14 -04:00
alistair3149 320b28c6d9
fix(core): call to member function null in user tagline 2022-05-24 18:18:23 -04:00
alistair3149 21633dcd3c
feat(core): separate header from personal menu list 2022-05-23 16:10:14 -04:00
alistair3149 eaad65fc3c
feat(core): decorate personal menu for anon users 2022-05-23 15:26:04 -04:00
github-actions c2bde2e6ed ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-22 19:13:26 +00:00
alistair3149 97282a30ba
docs: address various phpcs warnings and errors 2022-05-22 15:12:05 -04:00
github-actions 0256103668 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-22 19:08:18 +00:00
alistair3149 cb6795de0a
refactor(core): clean up inconsistent use of partial variables 2022-05-22 15:06:49 -04:00
github-actions f13bb2ebef ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-21 20:27:46 +00:00
alistair3149 1df970eb41
feat(core): intergrate firstHeading changes from MW 1.39
* It is a temporary backport until we move to minimum 1.39
* Add support for blanking title introduced from 1.38
2022-05-21 16:24:35 -04:00
github-actions 8c0819c276 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-19 18:50:30 +00:00
alistair3149 c0cae44d41
feat(core): improve handling of number formatter for site stats
* The lack of PECL intl would not trigger an excpetion anymore,
instead it will default back to the regular PHP number format
* NumberFormatter will be based on user locale now instead of en_US
2022-05-19 14:46:35 -04:00
alistair3149 851356f3d9
feat(core): rename $wgCitizenPortalAttach to $wgCitizenSiteToolsPortlet
The previous name was not self-explanatory.
2022-05-18 19:54:08 -04:00
alistair3149 148f2eeefd
docs: add missing param doc 2022-05-18 19:47:52 -04:00
github-actions 0fbac154a7 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-18 23:45:19 +00:00
alistair3149 082b70f7e5
refactor(core): clean up drawer code
* Make it a bit more readable
* Define function return type
* Change default of CitizenPortalAttach to an empty string
* Site tools now attach to the first portlet when CitizenPortalAttach is empty
2022-05-18 19:43:50 -04:00
alistair3149 d4c7131c9f
fix(core): call to undefined method RequestContext::getAction()
Bug: #459
2022-05-18 19:15:51 -04:00
alistair3149 1df223abfa
feat(core): update menu to be more inlined with MW core
* Use label instead of h3 for menu headings
* Rename portals to portlets according to core
* Replace label-class with heading-class
* Use has-label to hide labels instead of adding screen reader class
2022-05-18 17:14:24 -04:00
github-actions 5411a9e81a ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-18 18:23:24 +00:00
alistair3149 bbf7fa8b34
fix(core): don't use getActionName < MW 1.38
getActionName does not exist before MW 1.38, use getAction instead

Bug: #459
2022-05-18 14:20:51 -04:00
alistair3149 176adba1fb
fix(core): decoratePersonalMenu should only return array 2022-05-18 02:56:15 -04:00
alistair3149 2ec20bae5d
fix(core): header function can return null (#459) 2022-05-18 02:54:16 -04:00
alistair3149 4710d1e59a
refactor(core): remove MW version check for ULS
The selector is present in MLEB builds that supports 1.35. So we don't need
to exclude 1.35 anymore.
2022-05-17 09:54:31 -04:00
alistair3149 73c61e9b37
feat(core): use ULS for interwiki language menu if possible 2022-05-17 09:42:34 -04:00
github-actions 9ef2aab8b4 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-17 02:53:14 +00:00
alistair3149 93087a4fbe
refactor(core): clean up personal menu implementation 2022-05-16 22:52:04 -04:00
github-actions 29cd22fd7c ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-16 23:32:53 +00:00
alistair3149 9926140281
feat(core): add language count badge
Now the language button will have a badge indicating avaliable languages for the page
2022-05-16 19:31:11 -04:00
github-actions b8976790e5 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-16 04:53:33 +00:00
alistair3149 442f241641
feat(core): add language menu to page tools
In other language menu and language variant menu are merged into a singular menu
with a toggle in page tools. This is the first step towards having better language
handling in the skin.
2022-05-16 00:50:00 -04:00
alistair3149 7756c3447f
refactor(core): clean up SkinMustache polyfill for 1.35 2022-05-15 21:37:39 -04:00
alistair3149 5ccfbcfdeb refactor(core): clean up drawer implementation
This is a part of the site header refactor
* Use relative units
* Add title to toggle button
* Remove unnessecary CSS
* Rewrite HTML classes
* Temporary remove drawer subsearch, it will be re-explored in a later patch
2022-05-10 10:52:36 -04:00
alistair3149 44f9bc0a7c
feat(core): style parenthesis text in FirstHeading differently
Parenthesis text in FirstHeading are commonly used for disambiguation purposes
Therefore it does not have to be as prominent as the title
2022-05-07 00:45:51 -04:00
alistair3149 76a84d9e00 feat(core): add ARIA support to collaspible sections
* Also renamed toggle to indicator since it is misleading. The whole heading is the toggle itself.
2022-04-30 14:48:09 -04:00
Lens0021 2787d49a96
fix: find toolbox explicitly (#448)
The last item in the sidebar is not always the toolbox in some wikis, as result, a wrong portlet is displayed.
2022-04-30 02:54:13 -04:00
alistair3149 8eaaecf957
feat: do not format body content if MobileFrontend is active (#409)
MobileFrontend formats body content to enable features such as collasible headers.
Citizen should not attempt to format it as it will break features in MF.
2022-04-27 15:58:16 -04:00
alistair3149 7dbbc6b777
fix: add null check for user tagline
$editCount can return as null sometimes and throw an error
2022-04-25 02:03:13 -04:00
alistair3149 f05295195a feat: move discussion to the top of the more menu
Also clean up some related-styles
2022-04-24 01:53:47 -04:00
github-actions 2cd9efa4d9 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-04-24 00:27:06 +00:00
alistair3149 3c729928d2
feat: sitestats should show exact number when it is <10000 2022-04-23 20:26:05 -04:00
github-actions 673445c718 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-04-23 05:32:12 +00:00
alistair3149 a8485ac76a
fix: remove unused debug code 2022-04-23 01:31:22 -04:00
alistair3149 6efff7f5da feat: revamp drawer header
* wgLogo is always visible in the drawer
* Increase the size of wiki name
* Sitestats will now format large numbers into human readable formats (e.g. 12.2K, 3M, etc.)
* Sitestats now use icons instead of text as labels
* Remove wordmark for now, will revisit later
2022-04-23 01:30:02 -04:00
alistair3149 f770e250df
refactor: remove unused method 2022-04-19 18:20:06 -04:00
alistair3149 7ecf3a81eb
feat: depreciate theme preferences in MW user preferences
Just local storage is good enough
2022-04-19 17:31:23 -04:00
Lens0021 cebc35fd4b
feat: show footer desc and tagline in the content language (#444) 2022-04-17 12:23:43 -04:00
Lens0021 449278f0be
feat: use template data for page tools if available (#440)
* Use template data for page tools if available

* ci: lint code to MediaWiki standards

Check commit and GitHub actions for more details

* emptyPortlet class is added by the core

* ci: lint code to MediaWiki standards

Check commit and GitHub actions for more details

* Update PageTools.php

* Set toolbox to always valid data

Co-authored-by: github-actions <github-actions@users.noreply.github.com>
2022-04-14 00:30:33 -04:00
alistair3149 42df59f2b4
refactor!: drop security header support 2021-08-31 13:20:51 -04:00
github-actions 446faaf7f4 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2021-07-30 02:49:04 +00:00
alistair3149 d6968e9383
fix: undefined userPage variable 2021-06-22 11:23:42 -04:00
github-actions c0ce609cd4 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2021-06-20 06:04:43 +00:00
alistair3149 bc59fb82aa
refactor: clean up footer functions 2021-06-20 02:03:43 -04:00
alistair3149 82d48ac4e8 refactor: depreciate User->isLoggedIn (T270450) 2021-06-09 13:48:16 -04:00