refactor(core): ♻️ drop footer mustache fallback

includes/Partials/Footer.php

@@ -39,13 +39,6 @@ final class Footer extends Partial {
 
 		$data = [];
 		$footerLinks = $skin->getFooterLinksPublic();
-		$msg = [ 'desc', 'tagline' ];
-
-		// Get site footer messages
-		foreach ( $msg as $key ) {
-			$data["msg-citizen-footer-$key"] = $skin->msg( "citizen-footer-$key" )
-				->inContentLanguage()->parse();
-		}
 
 		// Based on SkinMustache
 		// Backported because of 1.35 support

includes/SkinCitizen.php

@@ -105,6 +105,10 @@ class SkinCitizen extends SkinMustache {
 			'html-citizen-jumptotop' => $this->msg( 'citizen-jumptotop' )->text() . ' [home]',
 			'html-body-content--formatted' => $bodycontent->buildBodyContent(),
 			'html-tagline' => $tagline->getTagline(),
+			// Messages
+			// Needed to be parsed here as it should be wikitext
+			'msg-citizen-footer-desc' => $this->msg( "citizen-footer-desc" )->inContentLanguage()->parse(),
+			'msg-citizen-footer-tagline' => $this->msg( "citizen-footer-tagline" )->inContentLanguage()->parse(),
 		];
 
 		$data += $tools->getPageToolsData( $parentData );

templates/Footer.mustache

@@ -23,11 +23,11 @@
 				<div id="footer-sitetitle" class="mw-wiki-title">{{>Wordmark}}</div>
 				<p id="footer-desc">{{{msg-citizen-footer-desc}}}</p>
 			</div>
-			{{#data-citizen-places}}{{>Footer__row}}{{/data-citizen-places}}
+			{{#data-places}}{{>Footer__row}}{{/data-places}}
 		</section>
 		<section class="citizen-footer__bottom">
 			<div id="footer-tagline">{{{msg-citizen-footer-tagline}}}</div>
-			{{#data-footer.data-icons}}{{>Footer__row}}{{/data-footer.data-icons}}
+			{{#data-icons}}{{>Footer__row}}{{/data-icons}}
 		</section>
 	</div>
 </footer>

templates/skin.mustache

@@ -23,4 +23,4 @@
 	{{>ContentFooter}}
 </main>
 {{{html-after-content}}}
-{{#data-citizen-footer}}{{>Footer}}{{/data-citizen-footer}}
+{{#data-footer}}{{>Footer}}{{/data-footer}}