mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-24 23:55:53 +00:00
709772fa12
de76ab5 added the config,
`$wgVectorDefaultSkinVersionForExistingAccounts`. Its usage in
`Hooks::onUserGetDefaultOptions()` was invoked not only for existing
accounts but anonymous users _as well._ This is a bug, due to my own
misconceptions about the hook, that went against both the config's name
and its documentation.
Unfortunately, user sessions are unavailable in
`Hooks::onUserGetDefaultOptions()` so it does not seem to be possible to
determine whether the active user is an anonymous or existing account.
This patch drops the hook and centralizes all version determination
logic in SkinVersionLookup::getVersion(). SkinVersionLookup requires a
the active User object and can make the anonymous / existing account
determination by checking login state.
The issued was identified while responding to review feedback given by
@polishdeveloper / @pmiazga in
I52d80942b4270c008d4e45050589ed9220255a50.
Bug: T251415
Change-Id: I7982b4c34283ba81d0232ee6f501c44cf0a74b98
140 lines
4.8 KiB
JSON
140 lines
4.8 KiB
JSON
{
|
|
"name": "Vector",
|
|
"author": [
|
|
"Trevor Parscal",
|
|
"Roan Kattouw",
|
|
"..."
|
|
],
|
|
"url": "https://www.mediawiki.org/wiki/Skin:Vector",
|
|
"descriptionmsg": "vector-skin-desc",
|
|
"namemsg": "skinname-vector",
|
|
"license-name": "GPL-2.0-or-later",
|
|
"type": "skin",
|
|
"requires": {
|
|
"MediaWiki": ">= 1.35.0"
|
|
},
|
|
"ValidSkinNames": {
|
|
"vector": "Vector"
|
|
},
|
|
"MessagesDirs": {
|
|
"Vector": [
|
|
"i18n"
|
|
]
|
|
},
|
|
"AutoloadClasses": {
|
|
"SkinVector": "includes/SkinVector.php",
|
|
"VectorTemplate": "includes/VectorTemplate.php"
|
|
},
|
|
"AutoloadNamespaces": {
|
|
"Vector\\": "includes/"
|
|
},
|
|
"ConfigRegistry": {
|
|
"vector": "GlobalVarConfig::newInstance"
|
|
},
|
|
"Hooks": {
|
|
"BeforePageDisplayMobile": "Vector\\Hooks::onBeforePageDisplayMobile",
|
|
"GetPreferences": "Vector\\Hooks::onGetPreferences",
|
|
"PreferencesFormPreSave": "Vector\\Hooks::onPreferencesFormPreSave",
|
|
"LocalUserCreated": "Vector\\Hooks::onLocalUserCreated"
|
|
},
|
|
"@note": "When modifying skins.vector.styles definition, make sure the installer still works",
|
|
"ResourceModules": {
|
|
"skins.vector.styles.legacy": {
|
|
"class": "ResourceLoaderSkinModule",
|
|
"features": [ "elements", "content", "interface", "logo", "legacy" ],
|
|
"targets": [
|
|
"desktop",
|
|
"mobile"
|
|
],
|
|
"styles": [ "resources/skins.vector.styles/legacy.less" ]
|
|
},
|
|
"skins.vector.styles": {
|
|
"class": "ResourceLoaderSkinModule",
|
|
"features": [ "elements", "content", "interface", "logo", "legacy" ],
|
|
"targets": [
|
|
"desktop",
|
|
"mobile"
|
|
],
|
|
"styles": [ "resources/skins.vector.styles/index.less" ]
|
|
},
|
|
"skins.vector.styles.responsive": {
|
|
"targets": [
|
|
"desktop",
|
|
"mobile"
|
|
],
|
|
"styles": [ "resources/skins.vector.styles.responsive.less" ]
|
|
},
|
|
"skins.vector.js": {
|
|
"packageFiles": [
|
|
"resources/skins.vector.js/index.js",
|
|
"resources/skins.vector.js/collapsibleTabs.js",
|
|
"resources/skins.vector.js/vector.js"
|
|
],
|
|
"dependencies": [
|
|
"mediawiki.util"
|
|
]
|
|
}
|
|
},
|
|
"ResourceFileModulePaths": {
|
|
"localBasePath": "",
|
|
"remoteSkinPath": "Vector"
|
|
},
|
|
"ResourceModuleSkinStyles": {
|
|
"vector": {
|
|
"jquery.tipsy": "skinStyles/jquery.tipsy.less",
|
|
"jquery.ui": [
|
|
"skinStyles/jquery.ui/jquery.ui.core.css",
|
|
"skinStyles/jquery.ui/jquery.ui.theme.css",
|
|
"skinStyles/jquery.ui/jquery.ui.accordion.css",
|
|
"skinStyles/jquery.ui/jquery.ui.autocomplete.css",
|
|
"skinStyles/jquery.ui/jquery.ui.button.css",
|
|
"skinStyles/jquery.ui/jquery.ui.datepicker.css",
|
|
"skinStyles/jquery.ui/jquery.ui.dialog.css",
|
|
"skinStyles/jquery.ui/jquery.ui.menu.css",
|
|
"skinStyles/jquery.ui/jquery.ui.progressbar.css",
|
|
"skinStyles/jquery.ui/jquery.ui.resizable.css",
|
|
"skinStyles/jquery.ui/jquery.ui.selectable.css",
|
|
"skinStyles/jquery.ui/jquery.ui.slider.css",
|
|
"skinStyles/jquery.ui/jquery.ui.tabs.css",
|
|
"skinStyles/jquery.ui/jquery.ui.tooltip.css"
|
|
],
|
|
"+mediawiki.action.view.redirectPage": "skinStyles/mediawiki.action.view.redirectPage.less",
|
|
"+mediawiki.notification": "skinStyles/mediawiki.notification.less",
|
|
"+oojs-ui-core.styles": "skinStyles/ooui.less",
|
|
"mediawiki.special": "skinStyles/mediawiki.special.less",
|
|
"+ext.relatedArticles.readMore": "skinStyles/ext.relatedArticles.readMore.less"
|
|
}
|
|
},
|
|
"config": {
|
|
"VectorUseSimpleSearch": {
|
|
"value": true
|
|
},
|
|
"VectorUseIconWatch": {
|
|
"value": true
|
|
},
|
|
"VectorResponsive": {
|
|
"value": false
|
|
},
|
|
"VectorShowSkinPreferences": {
|
|
"value": true,
|
|
"description": "@var boolean Show skin-specific user preferences on the Special:Preferences appearance tab when true and hide them otherwise."
|
|
},
|
|
"VectorDefaultSkinVersion": {
|
|
"value": "2",
|
|
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to use for anonymous users and as a fallback. The value is _not_ persisted."
|
|
},
|
|
"VectorDefaultSkinVersionForExistingAccounts": {
|
|
"value": "2",
|
|
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to use when an existing user has not specified a preference. This configuration is not used for new accounts (see VectorDefaultSkinVersionForNewAccounts) and is impermanent. In the future, this field may contains versions such as \"beta\" which when specified and the BetaFeatures extension is installed, and the user is enrolled, the latest version is used otherwise legacy. The value is _not_ persisted."
|
|
},
|
|
"VectorDefaultSkinVersionForNewAccounts": {
|
|
"value": "2",
|
|
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to **set** for newly created user accounts. **The value is persisted as a user preference.** This configuration is not used for preexisting accounts (see VectorDefaultSkinVersion) and only ever executed once at new account creation time."
|
|
}
|
|
},
|
|
"ServiceWiringFiles": [
|
|
"includes/ServiceWiring.php"
|
|
],
|
|
"manifest_version": 2
|
|
}
|