e718f53d97
Since Wikibase change I01afb269d6 (commit ee4c555878), Wikibase has a copy of the “is wikidatawiki” condition to temporarily continue supporting the old search on Vector 2022. As suggested by Michael there, we can change the condition here to avoid having the same check in two places, and instead detect whether Wikibase loaded the legacy search ResourceLoader module (which means we shouldn’t install the new search) or not (in which case Wikibase Repo is either not installed at all, or it’s providing a custom wgVectorSearchClient to support the new search). With this change in place, once Wikibase is ready to support the new search everywhere (including on Wikidata proper), we only need to change the condition in one place (in Wikibase), and can then clean up the code here at any later time. Bug: T316093 Change-Id: I0aa0e432181b14cdb7b92e2550b78f2d7d48094d |
||
|---|---|---|
| .phan | ||
| .storybook | ||
| dev-scripts | ||
| i18n | ||
| includes | ||
| resources | ||
| screenshots | ||
| skinStyles | ||
| stories | ||
| tests | ||
| .eslintignore | ||
| .eslintrc.json | ||
| .eslintrcEs6.json | ||
| .gitignore | ||
| .gitreview | ||
| .nvmrc | ||
| .phpcs.xml | ||
| .stylelintignore | ||
| .stylelintrc.json | ||
| .svgo.config.js | ||
| bundlesize.config.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Doxyfile | ||
| jest.config.js | ||
| jest.setup.js | ||
| jsdoc.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| skin.json | ||
| tsconfig.json | ||
Vector Skin
Installation
See https://www.mediawiki.org/wiki/Skin:Vector.
Configuration options
See skin.json.
Development
Node version
It is recommended to use nvm to use the version of node defined
in .nvmrc during local development. This ensures consistency amongst development environments.
Coding conventions
We strive for compliance with MediaWiki conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions
Additions and deviations from those conventions that are more tailored to this project are noted at:
https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions
Pre-commit tests
A pre-commit hook is installed when executing npm install. By default, it runs
npm test which is useful for automatically validating everything that can be
in a reasonable amount of time. If you wish to defer these tests to be executed
by continuous integration only, set the PRE_COMMIT environment variable to 0:
$ export PRE_COMMIT=0
$ git commit
Or more succinctly:
$ PRE_COMMIT=0 git commit
Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.
Hooks
See hooks.txt.