mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-15 11:50:57 +00:00
d56792addb
Regression from 74b9803d9a, caused by a bug in LightNCandy which
caused {{foo}} to render "0", and {{#foo}} to pass as true with "0", but then
in {{#foo}}<b>{{foo}}</b>{{/foo} render as empty string producing "<b></b>".
In other words, the conditional is passing and the inner block is executed,
but the placeholder is mistakenly converting "0" => null => "" (empty string),
causing the <h1> to render but without any text in it.
Work around this bug by simply removing the conditional. Several other skins
already don't have this conditional and it's unclear why or in what
situation MediaWiki would send OutputPage to SkinTemplate without a title.
I think it would make sense in such rare case to still have a consistent
layout for extensions and gadgets to interact with and not omit the H1
element, but render it with the value that OutputPage gave it, even if it
is the empty string.
Bug: T219864
Change-Id: I6e04b512d2fe2e949ff5385cb38ceebe392fb255
37 lines
1.5 KiB
Plaintext
37 lines
1.5 KiB
Plaintext
{{{html-headelement}}}
|
|
<div id="mw-page-base" class="noprint"></div>
|
|
<div id="mw-head-base" class="noprint"></div>
|
|
<div id="content" class="mw-body" role="main">
|
|
<a id="top"></a>
|
|
{{#html-sitenotice}}<div id="siteNotice" class="mw-body-content">{{{html-sitenotice}}}</div>{{/html-sitenotice}}
|
|
{{{html-indicators}}}
|
|
<h1 id="firstHeading" class="firstHeading" lang="{{page-langcode}}">{{{html-title}}}</h1>
|
|
{{{html-prebodyhtml}}}
|
|
<div id="bodyContent" class="mw-body-content">
|
|
{{#page-isarticle}}<div id="siteSub" class="noprint">{{msg-tagline}}</div>{{/page-isarticle}}
|
|
<div id="contentSub"{{{html-userlangattributes}}}>{{{html-subtitle}}}</div>
|
|
{{#html-undelete}}<div id="contentSub2">{{{html-undelete}}}</div>{{/html-undelete}}
|
|
{{#html-newtalk}}<div class="usermessage">{{{html-newtalk}}}</div>{{/html-newtalk}}
|
|
{{!
|
|
Keep this empty `div` for compatibility with gadgets and user scripts
|
|
using this place to insert extra elements before.
|
|
}}
|
|
<div id="jump-to-nav"></div>
|
|
<a class="mw-jump-link" href="#mw-head">{{msg-jumptonavigation}}</a>
|
|
<a class="mw-jump-link" href="#p-search">{{msg-jumptosearch}}</a>
|
|
{{{html-bodycontent}}}
|
|
{{#html-printfooter}}
|
|
<div class="printfooter">{{{html-printfooter}}}</div>
|
|
{{/html-printfooter}}
|
|
{{{html-catlinks}}}
|
|
{{{html-dataAfterContent}}}
|
|
<div class="visualClear"></div>
|
|
{{{html-debuglog}}}
|
|
</div>
|
|
</div>
|
|
{{! html-unported outputs <div id="mw-navigation"> and <div id="footer"> }}
|
|
{{{html-unported}}}
|
|
{{{html-printtail}}}
|
|
</body>
|
|
</html>
|