acaaa89c5e
There are two issues with context in this test case: 1. The $vectorTemplate object was not given the $context object. Calling setContext() is the same as MediaWiki would normally do after calling SkinFactory, e.g. as in RequestContext::getSkin. 2. The "main" glboal state was leaking into the test by mutating the result of getMain() instead of creating your own for use in the test. Change-Id: I09eb8c3a38c0d4e2c85461b61e6f14ab00995016 |
||
|---|---|---|
| .phan | ||
| .storybook | ||
| dev-scripts | ||
| i18n | ||
| includes | ||
| resources | ||
| screenshots | ||
| skinStyles | ||
| stories | ||
| tests | ||
| .eslintignore | ||
| .eslintrc.json | ||
| .eslintrcEs6.json | ||
| .gitignore | ||
| .gitreview | ||
| .nvmrc | ||
| .phpcs.xml | ||
| .stylelintignore | ||
| .stylelintrc.json | ||
| .svgo.config.js | ||
| bundlesize.config.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Doxyfile | ||
| jest.config.js | ||
| jest.setup.js | ||
| jsdoc.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| skin.json | ||
| tsconfig.json | ||
Vector Skin
Installation
See https://www.mediawiki.org/wiki/Skin:Vector.
Configuration options
See skin.json.
Development
Node version
It is recommended to use nvm to use the version of node defined
in .nvmrc during local development. This ensures consistency amongst development environments.
Coding conventions
We strive for compliance with MediaWiki conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions
Additions and deviations from those conventions that are more tailored to this project are noted at:
https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions
Pre-commit tests
A pre-commit hook is installed when executing npm install. By default, it runs
npm test which is useful for automatically validating everything that can be
in a reasonable amount of time. If you wish to defer these tests to be executed
by continuous integration only, set the PRE_COMMIT environment variable to 0:
$ export PRE_COMMIT=0
$ git commit
Or more succinctly:
$ PRE_COMMIT=0 git commit
Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.
Hooks
See hooks.txt.