mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-29 01:45:00 +00:00
709772fa12
de76ab5 added the config,
`$wgVectorDefaultSkinVersionForExistingAccounts`. Its usage in
`Hooks::onUserGetDefaultOptions()` was invoked not only for existing
accounts but anonymous users _as well._ This is a bug, due to my own
misconceptions about the hook, that went against both the config's name
and its documentation.
Unfortunately, user sessions are unavailable in
`Hooks::onUserGetDefaultOptions()` so it does not seem to be possible to
determine whether the active user is an anonymous or existing account.
This patch drops the hook and centralizes all version determination
logic in SkinVersionLookup::getVersion(). SkinVersionLookup requires a
the active User object and can make the anonymous / existing account
determination by checking login state.
The issued was identified while responding to review feedback given by
@polishdeveloper / @pmiazga in
I52d80942b4270c008d4e45050589ed9220255a50.
Bug: T251415
Change-Id: I7982b4c34283ba81d0232ee6f501c44cf0a74b98
57 lines
1.8 KiB
PHP
57 lines
1.8 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @since 1.35
|
|
*/
|
|
|
|
use Vector\FeatureManagement\Requirements\LatestSkinVersionRequirement;
|
|
use Vector\SkinVersionLookup;
|
|
|
|
/**
|
|
* @group Vector
|
|
* @coversDefaultClass \Vector\FeatureManagement\Requirements\LatestSkinVersionRequirement
|
|
*/
|
|
class LatestSkinVersionRequirementTest extends \MediaWikiTestCase {
|
|
|
|
/**
|
|
* @covers ::isMet
|
|
*/
|
|
public function testUnmet() {
|
|
$config = new HashConfig( [ 'VectorDefaultSkinVersionForExistingAccounts' => '1' ] );
|
|
|
|
$requirement = new LatestSkinVersionRequirement(
|
|
new SkinVersionLookup( new WebRequest(), $this->getTestUser()->getUser(), $config )
|
|
);
|
|
|
|
$this->assertFalse( $requirement->isMet(), '"1" isn\'t considered latest.' );
|
|
}
|
|
|
|
/**
|
|
* @covers ::isMet
|
|
*/
|
|
public function testMet() {
|
|
$config = new HashConfig( [ 'VectorDefaultSkinVersionForExistingAccounts' => '2' ] );
|
|
|
|
$requirement = new LatestSkinVersionRequirement(
|
|
new SkinVersionLookup( new WebRequest(), $this->getTestUser()->getUser(), $config )
|
|
);
|
|
|
|
$this->assertTrue( $requirement->isMet(), '"2" is considered latest.' );
|
|
}
|
|
}
|