mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-12-27 07:02:52 +00:00
158269333d
Fixes 9 warnings generated by https://validator.w3.org/nu/ - The navigation role is unnecessary for element nav. - The main role is unnecessary for element main. - The contentinfo role is unnecessary for element footer. Bug: T365938 Change-Id: Ibdbe70900f9a85d904252ad8ac26e4bb6e813a1c
80 lines
3 KiB
JavaScript
80 lines
3 KiB
JavaScript
const portlets = require( '../../../resources/skins.vector.legacy.js/portlets.js' );
|
|
const mustache = require( 'mustache' );
|
|
const fs = require( 'fs' );
|
|
const menuTemplate = fs.readFileSync( 'includes/templates/LegacyMenu.mustache', 'utf8' );
|
|
const menuContentsTemplate = fs.readFileSync( 'includes/templates/MenuContents.mustache', 'utf8' );
|
|
|
|
describe( 'portlets', () => {
|
|
test( 'portlets that go through the hook method should match the menu template HTML (non-dropdown version)', () => {
|
|
const id = 'foo';
|
|
const label = 'label text';
|
|
const portletHTML = mustache.render( menuTemplate, {
|
|
id, class: '', label
|
|
}, {
|
|
MenuContents: menuContentsTemplate
|
|
} );
|
|
|
|
const element = document.createElement( 'div' );
|
|
element.id = id;
|
|
if ( label ) {
|
|
const labelElement = document.createElement( 'label' );
|
|
labelElement.textContent = label;
|
|
element.appendChild( labelElement );
|
|
}
|
|
element.appendChild( document.createElement( 'ul' ) );
|
|
|
|
const actual = portlets.addPortletHandler( element ).outerHTML.replace( /[\s\n]/gi, '' )
|
|
// Known Difference 1: `div` elements need `role="navigation"`.
|
|
// `nav` elements do not.
|
|
.replace( /role="navigation"/g, '' );
|
|
const expected = portletHTML.replace( /[\s\n]/gi, '' )
|
|
// Known Difference 2: Portlets created via JS are `div` elements not `nav`
|
|
.replace( /<nav/g, '<div' )
|
|
.replace( /nav>/g, 'div>' )
|
|
// Known Difference 3: Portlets created via JS have `div` elements
|
|
// rather than `h3 > span`
|
|
.replace( /<spanclass="vector-menu-heading-label">/g, '' )
|
|
.replace( /<h3/g, '<div' )
|
|
.replace( /<\/span><\/h3>/g, '</div>' );
|
|
expect( actual ).toBe( expected );
|
|
} );
|
|
|
|
test( 'portlet dropdowns that go through the hook method should match the menu template HTML (dropdown version)', () => {
|
|
const id = 'foo';
|
|
const label = 'label text';
|
|
const portletHTML = mustache.render( menuTemplate, {
|
|
id, class: 'vector-menu-dropdown', label,
|
|
'is-dropdown': true
|
|
}, {
|
|
MenuContents: menuContentsTemplate
|
|
} );
|
|
|
|
const rNav = document.createElement( 'div' );
|
|
rNav.id = 'right-navigation';
|
|
const element = document.createElement( 'div' );
|
|
element.id = id;
|
|
if ( label ) {
|
|
const labelElement = document.createElement( 'label' );
|
|
labelElement.textContent = label;
|
|
element.appendChild( labelElement );
|
|
}
|
|
element.appendChild( document.createElement( 'ul' ) );
|
|
rNav.appendChild( element );
|
|
|
|
const actual = portlets.addPortletHandler( element ).outerHTML.replace( /[\s\n]/gi, '' )
|
|
// Known Difference 1: `div` elements need `role="navigation"`.
|
|
// `nav` elements do not.
|
|
.replace( /role="navigation"/g, '' );
|
|
const expected = portletHTML.replace( /[\s\n]/gi, '' )
|
|
// Known Difference 2: Portlets created via JS are `div` elements not `nav`
|
|
.replace( /<nav/g, '<div' )
|
|
.replace( /nav>/g, 'div>' )
|
|
// Known Difference 3: Portlets created via JS
|
|
// have `div` elements rather than `label`
|
|
.replace( /<spanclass="vector-menu-heading-label">/g, '' )
|
|
.replace( /<label/g, '<div' )
|
|
.replace( /<\/span><\/label>/g, '</div>' );
|
|
expect( actual ).toBe( expected );
|
|
} );
|
|
} );
|