mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-12-03 03:37:24 +00:00
e1d1de809f
- The collapsible ToC absolute positioning solution has been preserved to be used on no-js mobile resolutions - The collapsible ToC grid based positioning solution has been removed - ToC styles have been refactored and organzied This patch involves HTML changes. In order to avoid additional complexity, this patch disables the collapsible ToC feature for users above the mobile viewport with cached HTML. The ToC continues to be automatically collapsed on mobile viewports for cached HTML users. This patch results in 9 expected visual changes. In order to see them you need to take the following steps: 1. Run `./pixel.js reference` 2. Checkout the following PR in pixel https://github.com/wikimedia/pixel/pull/149 3. Run ./pixel.js test -c 859143 It should look like this: https://jmp.sh/ZVQqDZw7 Bug: T318013 Change-Id: Iea0d73005b91589c58ae38a3a640fa90c18a860d
50 lines
1.8 KiB
Plaintext
50 lines
1.8 KiB
Plaintext
{{!
|
|
Sticky header is hidden from screen readers because it contains duplicated content
|
|
that is already accessible to assistive tech via landmark roles, element type, and other navigation methods.
|
|
The interactive elements in the sticky header should have the `tabindex="-1"` attribute set to ensure
|
|
the header is also not tab accessible.
|
|
|
|
See https://dequeuniversity.com/rules/axe/4.1/aria-hidden-focus and https://phabricator.wikimedia.org/T290201
|
|
for more context.
|
|
}}
|
|
<header id="vector-sticky-header" aria-hidden="true"
|
|
class="vector-sticky-header">
|
|
<div class="vector-sticky-header-start">
|
|
<div class="vector-sticky-header-icon-start mw-ui-icon-flush-left mw-ui-icon-flush-right">
|
|
{{#data-button-start}}
|
|
{{>Button}}
|
|
{{/data-button-start}}
|
|
</div>
|
|
{{#data-search}}
|
|
{{>SearchBox}}
|
|
{{/data-search}}
|
|
<div class="vector-sticky-header-context-bar">
|
|
<div class="vector-sticky-header-toc-container mw-ui-icon-flush-left">
|
|
{{! TOC is moved into this dropdown from the sidebar in stickyHeader.js. }}
|
|
{{#data-sticky-header-toc}}
|
|
{{>Dropdown/Open}}
|
|
{{>UnpinnedContainer/Open}}
|
|
{{>UnpinnedContainer/Close}}
|
|
{{>Dropdown/Close}}
|
|
{{/data-sticky-header-toc}}
|
|
</div>
|
|
<div class="vector-sticky-header-context-bar-primary" {{{html-user-language-attributes}}}>{{{html-title}}}</div>
|
|
</div>
|
|
</div>
|
|
<div class="vector-sticky-header-end mw-ui-icon-flush-right">
|
|
<div class="vector-sticky-header-icons">
|
|
{{#data-buttons}}
|
|
{{>Button}}
|
|
{{/data-buttons}}
|
|
</div>
|
|
{{#data-primary-action}}
|
|
{{>Button}}
|
|
{{/data-primary-action}}
|
|
<div class="vector-sticky-header-icon-end">
|
|
<div class="vector-user-links">
|
|
{{! User menu items with unique ids are cloned here from the fixed header in stickyHeader.js. }}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</header>
|