wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-28 17:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/skins/Vector
2963 commits 14 branches 21 tags 95 MiB
PHP 39.7%
JavaScript 36.6%
Less 18.4%
Mustache 4.3%
Vue 1%
Go to file
Nicholas Ray 718bcef6f9 Fix empty space on left when bucketed in the control/unsampled group 
When the AB test is enabled both the old and new TOC's are in the page's
html but only one is visible. The `.vector-toc-visible` class is also
present and will try to apply a left margin even if the page has been
bucketed into the control or unsampled group.

This patch takes the simplest approach to fix this problem with CSS only
especially given the transient nature of this code (will be removed when
AB test is finished):

* When the page bucketed in the control or unsampled group, prevent
  .vector-toc-visible from applying a left-margin through the use of
  `:not` selectors.

Additionally:

* Remove unnecessary `margin-left` rule that used to apply to the
  mw-workspace-container. Due to the work done in
  I2f95d5938674bb8263b6203c5f6a469762bf0cc2, the workspace container
  will now always have a computed left margin of zero because it is the
  same width as the page container.

Bug: T306366
Change-Id: Icd9572353bb5e29cfda91b095ceb8c2e652864e7
2022-04-19 14:35:49 -06:00
.phan Upgrade to newer phan 2019-03-20 19:37:59 -07:00
.storybook Update Vector menu CSS to use vector-menu-heading instead of h3 2022-03-02 20:05:36 +05:30
dev-scripts [Storybook] Add Header component 2021-09-14 18:33:10 +00:00
i18n Localisation updates from https://translatewiki.net. 2022-04-19 10:18:10 +02:00
includes Merge "Restore persistent sidebar" 2022-04-18 21:47:34 +00:00
resources Fix empty space on left when bucketed in the control/unsampled group 2022-04-19 14:35:49 -06:00
screenshots
skinStyles Ensure sticky header ULS menu appears in default location right underneath the button 2022-01-19 19:37:25 +00:00
stories Move Vector menu class logic into Menu mustache template 2022-04-18 15:18:53 -05:00
tests Move Vector menu class logic into Menu mustache template 2022-04-18 15:18:53 -05:00
.eslintignore Update a11y tests to output files in log/ 2022-04-15 19:43:53 +00:00
.eslintrc.json [eslint] Disable mediawiki/class-doc 2022-02-11 16:31:33 +00:00
.eslintrcEs6.json [eslint] Disable mediawiki/class-doc 2022-02-11 16:31:33 +00:00
.gitignore Update a11y tests to output files in log/ 2022-04-15 19:43:53 +00:00
.gitreview
.nvmrc Update Node version 2022-03-15 14:26:04 -07:00
.phpcs.xml build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 2020-11-17 23:33:50 +01:00
.stylelintignore Setup jest unit tests and add basic test cases for AB.js and App.vue 2022-01-31 20:50:33 +00:00
.stylelintrc.json build: Updating stylelint-config-wikimedia to 0.11.1 2021-09-04 17:38:00 +00:00
.svgo.config.js build: Update 'svgo' to latest v2.8.0 & re-crush images 2022-02-28 00:00:05 +00:00
bundlesize.config.json Add sectionObserver and tableOfContents component JS to respond to intersection changes 2022-01-26 14:11:43 -07:00
CODE_OF_CONDUCT.md build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 2018-09-04 01:45:34 +00:00
composer.json Add composer test:size as shortcut bundle size test 2021-12-10 19:59:19 +00:00
COPYING
Doxyfile docs: Generate documentation with Doxygen 2020-02-24 16:49:38 +00:00
jest.config.js Sticky header dropdown should not contain gadgets in personal menu 2022-02-18 21:30:29 +00:00
jest.setup.js Move REST search client out of WVUI into Vector 2022-02-10 10:17:10 -06:00
jsdoc.json Move REST search client out of WVUI into Vector 2022-02-10 10:17:10 -06:00
package-lock.json Update sticky header to use ARIA attributes for section collapsing and add accessible label to toggle buttons 2022-04-06 17:24:34 -05:00
package.json Update a11y tests to output files in log/ 2022-04-15 19:43:53 +00:00
README.md End migration mode 2022-03-23 16:46:42 +00:00
skin.json Restore persistent sidebar 2022-04-18 19:44:11 +00:00
tsconfig.json Setup jest unit tests and add basic test cases for AB.js and App.vue 2022-01-31 20:50:33 +00:00

README.md

Vector Skin

Installation

See https://www.mediawiki.org/wiki/Skin:Vector.

Configuration options

See skin.json.

Development

Node version

It is recommended to use nvm to use the version of node defined in .nvmrc during local development. This ensures consistency amongst development environments.

Coding conventions

We strive for compliance with MediaWiki conventions:

https://www.mediawiki.org/wiki/Manual:Coding_conventions

Additions and deviations from those conventions that are more tailored to this project are noted at:

https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions

Pre-commit tests

A pre-commit hook is installed when executing npm install. By default, it runs npm test which is useful for automatically validating everything that can be in a reasonable amount of time. If you wish to defer these tests to be executed by continuous integration only, set the PRE_COMMIT environment variable to 0:

$ export PRE_COMMIT=0
$ git commit

Or more succinctly:

$ PRE_COMMIT=0 git commit

Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.

Hooks

See hooks.txt.