Go to file
Stephen Niedzielski 713d0ac2fd [dev] Favor LESS media queries to ResourceLoader
Prior to this patch, Vector used a mixture of LESS media queries and
ResourceLoader (RL) media queries[0]. So far as I can tell[1], the
latter only instructs RL to wrap the contents of a LESS file within a
query (there are no conditionals placed on style loading). Further,
according to a coauthor of RL (Roan), RL media query support was most
likely a replacement for `@media foo { @import foo.css }` to inline
print styles from a separate style sheet which Vector itself does not
use. The LESS solution is much more intuitive since it's not MediaWiki-
specific and only the LESS code needs to be considered instead of LESS
_and_ the RL configuration in skin.json.

This patch moves both screen media queries to screen.less for the
aforementioned consistency and to avoid nesting queries. It is hoped
that these changes will help make future work easier, such as those to
margin likely to take place in making the sidebar collapsible.

[0]: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#Media_queries
[1]: http://localhost:8181/w/load.php?debug=true&lang=en&modules=skins.vector.styles&only=styles&skin=vector

Bug: T246419
Change-Id: Ic0adfa254f3e81dfa87a26899f3aa585645956f1
2020-03-10 13:13:42 -06:00
.phan Upgrade to newer phan 2019-03-20 19:37:59 -07:00
.storybook Add storybook to Vector 2020-01-31 16:59:15 +08:00
dev-scripts Add storybook to Vector 2020-01-31 16:59:15 +08:00
i18n Localisation updates from https://translatewiki.net. 2020-03-06 07:55:41 +01:00
includes featureManager: Add Requirement interface 2020-03-09 11:06:26 +00:00
resources [dev] Favor LESS media queries to ResourceLoader 2020-03-10 13:13:42 -06:00
screenshots Add skin screenshot for the installer 2017-08-11 15:37:34 -04:00
skinStyles hygiene: Make LESS imports non-ambigious 2019-10-25 20:54:49 +00:00
stories Move watchstar import out of VectorTabs.less and into screen.less 2020-03-10 10:04:46 -06:00
tests/phpunit featureManager: Add Requirement interface 2020-03-09 11:06:26 +00:00
.eslintignore Replace Grunt tasks with npm scripts in package.json 2020-02-27 16:32:12 +01:00
.eslintrc.json build: Update linters 2019-10-31 21:43:20 +00:00
.gitignore Add storybook to Vector 2020-01-31 16:59:15 +08:00
.gitreview
.phpcs.xml Add method scope visibility 2018-11-01 21:01:32 +01:00
.stylelintignore Replace Grunt tasks with npm scripts in package.json 2020-02-27 16:32:12 +01:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-26 10:29:23 -08:00
.svgo.yml build: Add 'svgo', SVG minifier script and unify SVGO rules 2020-03-07 19:47:58 -08:00
CODE_OF_CONDUCT.md build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 2018-09-04 01:45:34 +00:00
composer.json build: Updating composer dependencies 2020-01-30 20:11:34 +00:00
COPYING
Doxyfile docs: Generate documentation with Doxygen 2020-02-24 16:49:38 +00:00
hooks.txt Remove 'SkinVectorStyleModules' hook 2018-01-26 10:33:47 -08:00
jsdoc.json Add 'jsdoc-wmf-theme' to jsdoc 2020-02-14 10:43:46 -07:00
package-lock.json build: Updating acorn to 6.4.1 2020-03-09 21:48:09 +00:00
package.json build: Updating acorn to 7.1.1 2020-03-08 19:06:33 +00:00
README.md [Special:Preferences] [PHP] Add skin version user preference and configs 2020-02-26 12:56:10 -07:00
skin.json [dev] Favor LESS media queries to ResourceLoader 2020-03-10 13:13:42 -06:00
variables.less hygiene: Make LESS imports non-ambigious 2019-10-25 20:54:49 +00:00

Vector Skin

Installation

See https://www.mediawiki.org/wiki/Skin:Vector.

Configuration options

See skin.json.

Development

Coding conventions

We strive for compliance with MediaWiki conventions:

https://www.mediawiki.org/wiki/Manual:Coding_conventions

Additions and deviations from those conventions that are more tailored to this project are noted at:

https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions

URL query parameters

  • useskinversion: Like useskin but for overriding the Vector skin version user preference and configuration.

Skin preferences

Vector defines skin-specific user preferences. These are exposed on Special:Preferences when the VectorShowSkinPreferences configuration is enabled. The user's preference state for skin preferences is used for skin previews and any other operation unless specified otherwise.

Version

Vector defines a "version" preference to enable users who prefer the December 2019 version of Vector to continue to do so without any visible changes. This version is called "Legacy Vector." The related preference defaults are configurable via the configurations prefixed with VectorDefaultSkinVersion. Version preference and configuration may be overridden by the useskinversion URL query parameter.