mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-25 08:05:51 +00:00
090500276d
Not all implementations will need this (e.g. the Wikibase search is based on the Action API, not the REST API), so simplify App and move this bit of complexity into the default search client instead. As far as I can tell from MediaWiki code search [1] and Global Search [2], nothing apart from Wikibase uses wgVectorSearchClient yet, so we should be able to make this breaking change now. [1]: https://codesearch.wmcloud.org/search/?q=wgVectorSearchClient [2]: https://global-search.toolforge.org/?q=wgVectorSearchClient&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.js%29 Change-Id: I0d52e407c12b3fbf80cd36ed66c67da4cba9acbd
131 lines
3.5 KiB
JavaScript
131 lines
3.5 KiB
JavaScript
/* global fetchMock */
|
|
const restSearchClient = require( '../../resources/skins.vector.search/restSearchClient.js' );
|
|
const jestFetchMock = require( 'jest-fetch-mock' );
|
|
|
|
const mockedRequests = !process.env.TEST_LIVE_REQUESTS;
|
|
const configMock = {
|
|
get: jest.fn().mockImplementation( ( key, fallback = null ) => {
|
|
if ( key === 'wgScriptPath' ) {
|
|
return '/w';
|
|
}
|
|
if ( key === 'wgScript' ) {
|
|
return '/w/index.php';
|
|
}
|
|
if ( key === 'wgVectorSearchApiUrl' ) {
|
|
return 'https://en.wikipedia.org/w/rest.php';
|
|
}
|
|
return fallback;
|
|
} ),
|
|
set: jest.fn()
|
|
};
|
|
|
|
describe( 'restApiSearchClient', () => {
|
|
beforeAll( () => {
|
|
jestFetchMock.enableFetchMocks();
|
|
} );
|
|
|
|
afterAll( () => {
|
|
jestFetchMock.disableFetchMocks();
|
|
} );
|
|
|
|
beforeEach( () => {
|
|
fetchMock.resetMocks();
|
|
if ( !mockedRequests ) {
|
|
fetchMock.disableMocks();
|
|
}
|
|
} );
|
|
|
|
test( '2 results', async () => {
|
|
const thumbUrl = '//upload.wikimedia.org/wikipedia/commons/0/01/MediaWiki-smaller-logo.png';
|
|
const restResponse = {
|
|
pages: [
|
|
{
|
|
id: 37298,
|
|
key: 'Media',
|
|
label: 'Media',
|
|
title: 'Media',
|
|
description: 'Wikimedia disambiguation page',
|
|
thumbnail: null,
|
|
url: '/w/index.php?title=Special%3ASearch&search=Media',
|
|
value: 37298
|
|
},
|
|
{
|
|
id: 323710,
|
|
key: 'MediaWiki',
|
|
label: 'MediaWiki',
|
|
title: 'MediaWiki',
|
|
description: 'wiki software',
|
|
thumbnail: {
|
|
width: 200,
|
|
height: 189,
|
|
url: thumbUrl
|
|
},
|
|
url: '/w/index.php?title=Special%3ASearch&search=MediaWiki',
|
|
value: 323710
|
|
}
|
|
]
|
|
};
|
|
fetchMock.mockOnce( JSON.stringify( restResponse ) );
|
|
|
|
const searchResult = await restSearchClient( configMock ).fetchByTitle(
|
|
'media',
|
|
2
|
|
).fetch;
|
|
|
|
/* eslint-disable-next-line compat/compat */
|
|
const controller = new AbortController();
|
|
|
|
expect( searchResult.query ).toStrictEqual( 'media' );
|
|
expect( searchResult.results ).toBeTruthy();
|
|
expect( searchResult.results.length ).toBe( 2 );
|
|
|
|
expect( searchResult.results[ 0 ] ).toStrictEqual(
|
|
Object.assign( {}, restResponse.pages[ 0 ], {
|
|
// thumbnail: null -> thumbnail: undefined
|
|
thumbnail: undefined
|
|
} ) );
|
|
expect( searchResult.results[ 1 ] ).toStrictEqual( restResponse.pages[ 1 ] );
|
|
|
|
if ( mockedRequests ) {
|
|
expect( fetchMock ).toHaveBeenCalledTimes( 1 );
|
|
expect( fetchMock ).toHaveBeenCalledWith(
|
|
'https://en.wikipedia.org/w/rest.php/v1/search/title?q=media&limit=2',
|
|
{ headers: { accept: 'application/json' }, signal: controller.signal }
|
|
);
|
|
}
|
|
} );
|
|
|
|
test( '0 results', async () => {
|
|
const restResponse = { pages: [] };
|
|
fetchMock.mockOnce( JSON.stringify( restResponse ) );
|
|
|
|
const searchResult = await restSearchClient( configMock ).fetchByTitle(
|
|
'thereIsNothingLikeThis'
|
|
).fetch;
|
|
|
|
/* eslint-disable-next-line compat/compat */
|
|
const controller = new AbortController();
|
|
expect( searchResult.query ).toStrictEqual( 'thereIsNothingLikeThis' );
|
|
expect( searchResult.results ).toBeTruthy();
|
|
expect( searchResult.results.length ).toBe( 0 );
|
|
|
|
if ( mockedRequests ) {
|
|
expect( fetchMock ).toHaveBeenCalledTimes( 1 );
|
|
expect( fetchMock ).toHaveBeenCalledWith(
|
|
'https://en.wikipedia.org/w/rest.php/v1/search/title?q=thereIsNothingLikeThis&limit=10',
|
|
{ headers: { accept: 'application/json' }, signal: controller.signal }
|
|
);
|
|
}
|
|
} );
|
|
|
|
if ( mockedRequests ) {
|
|
test( 'network error', async () => {
|
|
fetchMock.mockRejectOnce( new Error( 'failed' ) );
|
|
|
|
await expect( restSearchClient( configMock ).fetchByTitle(
|
|
'anything'
|
|
).fetch ).rejects.toThrow( 'failed' );
|
|
} );
|
|
}
|
|
} );
|