MusikAnimal 5207a15b91 HTMLLegacySkinVersionField: accept string 'default' value ... After I628435a4a, we were asserting a boolean was given because we're extending HTMLFormField which requires a boolean value. This was safe because GlobalPrefs would provide a boolean, but that changed with I594f6297. We could rework GlobalPrefs once again to ensure only a boolean is passed in, but since HTMLLegacySkinVersionField already has special handling around the data types, it seems to make sense to contain the type transformation in this class. Simply removing the Assertion is enough to prevent T296068, however depending on when the global preference was saved (such as since MW 1.38.0-wmf.9 but before wmf.10), it's possible either a bool or a string was saved, hence we check for both to ensure correct display. Bug: T296068 Change-Id: If10b948617d2bb8346475f207fe425fb768cb987		2021-11-23 00:57:25 -05:00
..
HTMLLegacySkinVersionFieldTest.php	HTMLLegacySkinVersionField: accept string 'default' value	2021-11-23 00:57:25 -05:00