mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-24 23:55:53 +00:00
e6e2120099
Register a temporary requirement that is configured the same as the "LanguageInHeader" requirement. Pass that requirement a custom configuration, in which the language treatment A/B test is always enabled. Increment the bucket corresponding to whether the requirement is met. Supporting changes: * Add a version to the base bucket name and set it to 2 Bug: T286932 Change-Id: Ic639687237074a13e7feb3c9084a35db0e5cb902
206 lines
5.9 KiB
PHP
206 lines
5.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Service Wirings for Vector skin
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @since 1.35
|
|
*/
|
|
|
|
use MediaWiki\MediaWikiServices;
|
|
use Vector\Constants;
|
|
use Vector\FeatureManagement\FeatureManager;
|
|
use Vector\FeatureManagement\Requirements\DynamicConfigRequirement;
|
|
use Vector\FeatureManagement\Requirements\LatestSkinVersionRequirement;
|
|
use Vector\FeatureManagement\Requirements\OverridableConfigRequirement;
|
|
use Vector\FeatureManagement\Requirements\WvuiSearchTreatmentRequirement;
|
|
use Vector\SkinVersionLookup;
|
|
|
|
return [
|
|
Constants::SERVICE_CONFIG => static function ( MediaWikiServices $services ) {
|
|
return $services->getService( 'ConfigFactory' )->makeConfig( Constants::SKIN_NAME );
|
|
},
|
|
Constants::SERVICE_FEATURE_MANAGER => static function ( MediaWikiServices $services ) {
|
|
$featureManager = new FeatureManager();
|
|
|
|
$featureManager->registerRequirement(
|
|
new DynamicConfigRequirement(
|
|
$services->getMainConfig(),
|
|
Constants::CONFIG_KEY_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_FULLY_INITIALISED
|
|
)
|
|
);
|
|
|
|
// Feature: Latest skin
|
|
// ====================
|
|
$context = RequestContext::getMain();
|
|
|
|
$featureManager->registerRequirement(
|
|
new LatestSkinVersionRequirement(
|
|
new SkinVersionLookup(
|
|
$context->getRequest(),
|
|
$context->getUser(),
|
|
$services->getService( Constants::SERVICE_CONFIG )
|
|
)
|
|
)
|
|
);
|
|
|
|
$featureManager->registerFeature(
|
|
Constants::FEATURE_LATEST_SKIN,
|
|
[
|
|
Constants::REQUIREMENT_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_LATEST_SKIN_VERSION,
|
|
]
|
|
);
|
|
|
|
// Feature: Languages in sidebar
|
|
// ================================
|
|
$featureManager->registerRequirement(
|
|
new OverridableConfigRequirement(
|
|
$services->getMainConfig(),
|
|
$context->getUser(),
|
|
$context->getRequest(),
|
|
CentralIdLookup::factoryNonLocal(),
|
|
Constants::CONFIG_KEY_LANGUAGE_IN_HEADER,
|
|
Constants::REQUIREMENT_LANGUAGE_IN_HEADER,
|
|
Constants::QUERY_PARAM_LANGUAGE_IN_HEADER,
|
|
Constants::CONFIG_LANGUAGE_IN_HEADER_TREATMENT_AB_TEST
|
|
)
|
|
);
|
|
|
|
// ---
|
|
|
|
// Temporary T286932 - remove after languages A/B test is finished.
|
|
$requirementName = 'T286932';
|
|
|
|
// MultiConfig checks each config in turn, allowing us to override the main config for specific keys. In this
|
|
// case, override the "VectorLanguageInHeaderABTest" configuration value so that the following requirement
|
|
// always buckets the user as if the language treatment A/B test were running.
|
|
$config = new MultiConfig( [
|
|
new HashConfig( [
|
|
Constants::CONFIG_LANGUAGE_IN_HEADER_TREATMENT_AB_TEST => true,
|
|
] ),
|
|
$services->getMainConfig(),
|
|
] );
|
|
|
|
$featureManager->registerRequirement(
|
|
new OverridableConfigRequirement(
|
|
$config,
|
|
$context->getUser(),
|
|
$context->getRequest(),
|
|
CentralIdLookup::factoryNonLocal(),
|
|
Constants::CONFIG_KEY_LANGUAGE_IN_HEADER,
|
|
$requirementName,
|
|
/* $overrideName = */ '',
|
|
Constants::CONFIG_LANGUAGE_IN_HEADER_TREATMENT_AB_TEST
|
|
)
|
|
);
|
|
|
|
if (
|
|
$context->getUser()->isRegistered() &&
|
|
$featureManager->isRequirementMet( Constants::REQUIREMENT_LATEST_SKIN_VERSION )
|
|
) {
|
|
$bucket = 'vector.language_test_2_' . (
|
|
$featureManager->isRequirementMet( $requirementName )
|
|
? 'a'
|
|
: 'b'
|
|
);
|
|
$services->getStatsdDataFactory()->increment( $bucket );
|
|
}
|
|
|
|
// ---
|
|
|
|
$featureManager->registerFeature(
|
|
Constants::FEATURE_LANGUAGE_IN_HEADER,
|
|
[
|
|
Constants::REQUIREMENT_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_LATEST_SKIN_VERSION,
|
|
Constants::REQUIREMENT_LANGUAGE_IN_HEADER,
|
|
]
|
|
);
|
|
|
|
// Feature: Use Wvui Search
|
|
// ================================
|
|
$featureManager->registerRequirement(
|
|
new WvuiSearchTreatmentRequirement(
|
|
$services->getMainConfig(),
|
|
$context->getUser()
|
|
)
|
|
);
|
|
|
|
$featureManager->registerFeature(
|
|
Constants::FEATURE_USE_WVUI_SEARCH,
|
|
[
|
|
Constants::REQUIREMENT_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_LATEST_SKIN_VERSION,
|
|
Constants::REQUIREMENT_USE_WVUI_SEARCH
|
|
]
|
|
);
|
|
|
|
// Feature: Consolidate personal menu links
|
|
// ================================
|
|
$featureManager->registerRequirement(
|
|
new OverridableConfigRequirement(
|
|
$services->getMainConfig(),
|
|
$context->getUser(),
|
|
$context->getRequest(),
|
|
null,
|
|
Constants::CONFIG_CONSOLIDATE_USER_LINKS,
|
|
Constants::REQUIREMENT_CONSOLIDATE_USER_LINKS,
|
|
Constants::QUERY_PARAM_CONSOLIDATE_USER_LINKS,
|
|
null
|
|
)
|
|
);
|
|
|
|
$featureManager->registerFeature(
|
|
Constants::FEATURE_CONSOLIDATE_USER_LINKS,
|
|
[
|
|
Constants::REQUIREMENT_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_LATEST_SKIN_VERSION,
|
|
Constants::REQUIREMENT_CONSOLIDATE_USER_LINKS
|
|
]
|
|
);
|
|
|
|
// Feature: Sticky header
|
|
// ================================
|
|
$featureManager->registerRequirement(
|
|
new OverridableConfigRequirement(
|
|
$services->getMainConfig(),
|
|
$context->getUser(),
|
|
$context->getRequest(),
|
|
null,
|
|
Constants::CONFIG_STICKY_HEADER,
|
|
Constants::REQUIREMENT_STICKY_HEADER,
|
|
Constants::QUERY_PARAM_STICKY_HEADER,
|
|
null
|
|
)
|
|
);
|
|
|
|
$featureManager->registerFeature(
|
|
Constants::FEATURE_STICKY_HEADER,
|
|
[
|
|
Constants::REQUIREMENT_FULLY_INITIALISED,
|
|
Constants::REQUIREMENT_LATEST_SKIN_VERSION,
|
|
Constants::REQUIREMENT_STICKY_HEADER
|
|
]
|
|
);
|
|
|
|
return $featureManager;
|
|
}
|
|
];
|