mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-12-04 03:59:53 +00:00
348e6f6cc8
This commit introduces several changes to improve the structure and readability of the FeatureManagement code in the Vector skin. Key changes include: - In ABRequirementTest.php, improved test method names for clarity. - In ABRequirement.php, simplified property declarations and cleaned up code structure. - In DynamicConfigRequirement.php, cleaned up property declarations. - In LimitedWidthContentRequirement.php, cleaned up property declarations and added type hints. - In LoggedInRequirement.php, cleaned up property declarations. - In OverridableConfigRequirement.php, cleaned up property declarations. - In OverrideableRequirementHelper.php, cleaned up property declarations. - In SimpleRequirement.php, cleaned up property declarations. - In UserPreferenceRequirement.php, cleaned up property declarations. Each change aims to enhance the codebase's maintainability and understandability. No functional changes were introduced. Change-Id: I23283c5a6799b1f03a6a9b5832c34c7dbbcca527
112 lines
2.8 KiB
PHP
112 lines
2.8 KiB
PHP
<?php
|
|
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @since 1.42
|
|
*/
|
|
|
|
namespace MediaWiki\Skins\Vector\Tests\Unit\FeatureManagement\Requirements;
|
|
|
|
use MediaWiki\Config\HashConfig;
|
|
use MediaWiki\Skins\Vector\FeatureManagement\Requirements\ABRequirement;
|
|
use MediaWiki\User\User;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
/**
|
|
* @group Vector
|
|
* @group FeatureManagement
|
|
* @coversDefaultClass \MediaWiki\Skins\Vector\FeatureManagement\Requirements\ABRequirement
|
|
*/
|
|
class ABRequirementTest extends TestCase {
|
|
|
|
private function createUserMock( $userId ) {
|
|
$userMock = $this->createMock( User::class );
|
|
$userMock->method( 'getId' )->willReturn( $userId );
|
|
return $userMock;
|
|
}
|
|
|
|
/**
|
|
* Provides different scenarios for AB test enrollment.
|
|
*/
|
|
public function enrollmentProvider(): array {
|
|
return [
|
|
'Experiment Disabled' => [
|
|
[ 'enabled' => false, 'name' => 'mockExperiment' ],
|
|
// User ID
|
|
1,
|
|
// Expected result
|
|
true
|
|
],
|
|
'Experiment Enabled, Wrong Name' => [
|
|
[ 'enabled' => true, 'name' => 'mockWrongExperiment' ],
|
|
1,
|
|
true
|
|
],
|
|
'Experiment Enabled, Correct Name, User in Control Group' => [
|
|
[ 'enabled' => true, 'name' => 'mockExperiment' ],
|
|
2,
|
|
false
|
|
],
|
|
'Experiment Enabled, Correct Name, User in Test Group' => [
|
|
[ 'enabled' => true, 'name' => 'mockExperiment' ],
|
|
1,
|
|
true
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider enrollmentProvider
|
|
* @covers ::isMet
|
|
*/
|
|
public function testABRequirement( $experimentConfig, $userId, $expectedResult ) {
|
|
$config = new HashConfig( [
|
|
'VectorWebABTestEnrollment' => $experimentConfig
|
|
] );
|
|
|
|
$user = $this->createUserMock( $userId );
|
|
|
|
$abRequirement = new ABRequirement(
|
|
$config,
|
|
$user,
|
|
'mockExperiment',
|
|
);
|
|
|
|
$this->assertEquals( $expectedResult, $abRequirement->isMet() );
|
|
}
|
|
|
|
/**
|
|
* @covers ::getName
|
|
*/
|
|
public function testGetName() {
|
|
$config = new HashConfig();
|
|
$user = $this->createUserMock( 0 );
|
|
$experimentName = 'mockExperiment';
|
|
$name = 'ABTestRequirement';
|
|
|
|
$abRequirement = new ABRequirement(
|
|
$config,
|
|
$user,
|
|
$experimentName,
|
|
$name
|
|
);
|
|
|
|
$this->assertEquals( $name, $abRequirement->getName() );
|
|
}
|
|
}
|