17a3f91c9f
I04f9e48a1cf9dee915cf51e1e12b17ff0a595a06 provides neutral values for the Codex tokens in mediawiki.skin.defaults.less in MW core, and expects skins to import the appropriate Codex themes in their mediawiki.skin.variables.less. For both legacy Vector and Vector 2022, import the Codex tokens for the wikimedia-ui-legacy theme. We need to use the legacy theme because Vector and Vector 2022 have a base font size of 14px; the non-legacy theme assumes a base font size of 16px. Remove some variable assignments that are now redundant, because their values are the same as the Codex tokens we're importing. After importing the Codex tokens, override some of their values where necessary so that all variables' values stay the same(*). We should consider whether to remove some of these overrides in a follow-up patch, but keeping everything the same for now makes this change less disruptive. (*) As in the core change, one variable's value does change: - @max-width-breakpoint-tablet from calc(719px) to 719px but this change has no visual impact. Bug: T325237 Depends-On: I3a8c89d8558022077be1f32c6a6f4733b6302948 Change-Id: I3c5c8f9fc4b1841f8f8bdbcf27de82291d1fabbd |
||
|---|---|---|
| .phan | ||
| .storybook | ||
| dev-scripts | ||
| i18n | ||
| includes | ||
| resources | ||
| screenshots | ||
| skinStyles | ||
| stories | ||
| tests | ||
| .eslintignore | ||
| .eslintrc.json | ||
| .eslintrcEs6.json | ||
| .gitignore | ||
| .gitreview | ||
| .nvmrc | ||
| .phpcs.xml | ||
| .stylelintignore | ||
| .stylelintrc.json | ||
| .svgo.config.js | ||
| bundlesize.config.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Doxyfile | ||
| jest.config.js | ||
| jest.setup.js | ||
| jsdoc.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| skin.json | ||
| tsconfig.json | ||
Vector Skin
Installation
See https://www.mediawiki.org/wiki/Skin:Vector.
Configuration options
See skin.json.
Development
Node version
It is recommended to use nvm to use the version of node defined
in .nvmrc during local development. This ensures consistency amongst development environments.
Coding conventions
We strive for compliance with MediaWiki conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions
Additions and deviations from those conventions that are more tailored to this project are noted at:
https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions
Pre-commit tests
A pre-commit hook is installed when executing npm install. By default, it runs
npm test which is useful for automatically validating everything that can be
in a reasonable amount of time. If you wish to defer these tests to be executed
by continuous integration only, set the PRE_COMMIT environment variable to 0:
$ export PRE_COMMIT=0
$ git commit
Or more succinctly:
$ PRE_COMMIT=0 git commit
Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.
Hooks
See hooks.txt.